Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      The idea was to create a new, fresh (and hopefully clean) Solr Admin Interface. [Based on this ML-Thread]

      Features:

      Newly created Wiki-Page: http://wiki.apache.org/solr/ReworkedSolrAdminGUI

      I've quickly created a Github-Repository (Just for me, to keep track of the changes)
      » https://github.com/steffkes/solr-admin

      1. SOLR-2399-wip-notice.patch
        2 kB
        Stefan Matheis (steffkes)
      2. SOLR-2399-sorting-fields.patch
        3 kB
        Stefan Matheis (steffkes)
      3. SOLR-2399-fluid-width.patch
        3 kB
        Stefan Matheis (steffkes)
      4. SOLR-2399-analysis-stopwords.patch
        2 kB
        Stefan Matheis (steffkes)
      5. SOLR-2399-admin-interface.patch
        888 kB
        Ryan McKinley
      6. SOLR-2399-110721.patch
        44 kB
        Stefan Matheis (steffkes)
      7. SOLR-2399-110702.patch
        43 kB
        Stefan Matheis (steffkes)
      8. SOLR-2399-110702.patch
        44 kB
        Stefan Matheis (steffkes)
      9. SOLR-2399-110702.patch
        44 kB
        Stefan Matheis (steffkes)
      10. SOLR-2399-110622.patch
        46 kB
        Stefan Matheis (steffkes)
      11. SOLR-2399-110606.patch
        13 kB
        Stefan Matheis (steffkes)
      12. SOLR-2399-110603-2.patch
        3 kB
        Stefan Matheis (steffkes)
      13. SOLR-2399-110603.patch
        92 kB
        Stefan Matheis (steffkes)
      14. SOLR-2399.patch
        1.19 MB
        Stefan Matheis (steffkes)

        Issue Links

          Activity

          Hide
          Ryan McKinley added a comment -

          Any thoughts on implementing with velocity templates?

          I don't want to slow this down since any effort is great! but long term, it would be great to drop JSP completly

          Show
          Ryan McKinley added a comment - Any thoughts on implementing with velocity templates? I don't want to slow this down since any effort is great! but long term, it would be great to drop JSP completly
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Ryan, actually not - but that is only based on the fact, that i've never worked with them.

          // -Edit

          After having a first look, i'm not really sure what/how that should help? the index.jsp is needed to gather Information about Cores [using org.apache.solr.core.CoreContainer] .. and i (just) don't see, if (and if so, how) it is possible to pass that information to the Velocity-Thingy.

          If that could be done .. no point about dropping that index.jsp out of order

          Show
          Stefan Matheis (steffkes) added a comment - - edited Ryan, actually not - but that is only based on the fact, that i've never worked with them. // -Edit After having a first look, i'm not really sure what/how that should help? the index.jsp is needed to gather Information about Cores [using org.apache.solr.core.CoreContainer] .. and i (just) don't see, if (and if so, how) it is possible to pass that information to the Velocity-Thingy. If that could be done .. no point about dropping that index.jsp out of order
          Hide
          Hoss Man added a comment -

          the index.jsp is needed to gather Information about Cores [using org.apache.solr.core.CoreContainer]

          This is where the core admin handler should be useful – you can use it to get a list of cores and their statuses. In the example solr.xml (and by default if no solr.xml exists) it's available at "/admin/cores" but that can be changed – for now your JSP should be able to ask the CoreContainer for it using getAdminPath()

          (If it would be useful, we could also add a simple bit of info to the SystemInfoRequestHandler ((/corename/admin/system) output to let the UI (and external clients) know what path (if any) they can use to access the CoreAdminHandler if all they have is the URL for a single core.)

          I don't want to slow this down since any effort is great! but long term, it would be great to drop JSP completly

          i agree it would be nice to show off using the velocity writer to style handler responses in the admin ui, but i think that the general approach of using a jsp (or servlet) as the master controller for creating a base HTML page that then uses javascript to query all of the individual handler APIs makes a lot of sense – if for no other reason then that i don't think the velocity writer could really be used on the output of the CoreAdminHandler (can it? .. what context would it load the templates form?)

          Ultimately the problem we're always going to run into is that people can customize the paths of things in their configs - not just CoreAdminHandler but even all of hte various core specific admin handlers.

          I don't think that's something we really have to be worried about right now (the existing admin UI certainly doesn't) but using a simple servlet/index.jsp gives us the ability to at least start with a direct java call to answer the question: "what is the url of the coreadmin handler?" and then from there everything can be dynamicly driven.

          If the logic in the JSP is simple enough, and the real work is done in the javascript, then porting that JSP to velocity should ultimately be pretty straight forward (if there is a strong desire)

          Show
          Hoss Man added a comment - the index.jsp is needed to gather Information about Cores [using org.apache.solr.core.CoreContainer] This is where the core admin handler should be useful – you can use it to get a list of cores and their statuses. In the example solr.xml (and by default if no solr.xml exists) it's available at "/admin/cores" but that can be changed – for now your JSP should be able to ask the CoreContainer for it using getAdminPath() (If it would be useful, we could also add a simple bit of info to the SystemInfoRequestHandler ((/ corename /admin/system) output to let the UI (and external clients) know what path (if any) they can use to access the CoreAdminHandler if all they have is the URL for a single core.) I don't want to slow this down since any effort is great! but long term, it would be great to drop JSP completly i agree it would be nice to show off using the velocity writer to style handler responses in the admin ui, but i think that the general approach of using a jsp (or servlet) as the master controller for creating a base HTML page that then uses javascript to query all of the individual handler APIs makes a lot of sense – if for no other reason then that i don't think the velocity writer could really be used on the output of the CoreAdminHandler (can it? .. what context would it load the templates form?) Ultimately the problem we're always going to run into is that people can customize the paths of things in their configs - not just CoreAdminHandler but even all of hte various core specific admin handlers. I don't think that's something we really have to be worried about right now (the existing admin UI certainly doesn't) but using a simple servlet/index.jsp gives us the ability to at least start with a direct java call to answer the question: "what is the url of the coreadmin handler?" and then from there everything can be dynamicly driven. If the logic in the JSP is simple enough, and the real work is done in the javascript, then porting that JSP to velocity should ultimately be pretty straight forward (if there is a strong desire)
          Hide
          Ryan McKinley added a comment -

          If the logic in the JSP is simple enough, and the real work is done in the javascript, then porting that JSP to velocity should ultimately be pretty straight forward (if there is a strong desire)

          Yes, if anyone is willing to give the admin pages some much needed design love, I really don't want anythign to slow that down. In the future, if there is interest, it would be great to do this w/o JSP, the details of how will take some work.

          Show
          Ryan McKinley added a comment - If the logic in the JSP is simple enough, and the real work is done in the javascript, then porting that JSP to velocity should ultimately be pretty straight forward (if there is a strong desire) Yes, if anyone is willing to give the admin pages some much needed design love, I really don't want anythign to slow that down. In the future, if there is interest, it would be great to do this w/o JSP, the details of how will take some work.
          Hide
          Stefan Matheis (steffkes) added a comment -

          the index.jsp is needed to gather Information about Cores [using org.apache.solr.core.CoreContainer]

          This is where the core admin handler should be useful – you can use it to get a list of cores and their statuses. In the example solr.xml (and by default if no solr.xml exists) it's available at "/admin/cores" but that can be changed – for now your JSP should be able to ask the CoreContainer for it using getAdminPath()

          Yes, will integrate this at the weekend - thanks for the pointer Hoss!

          Having another look at the admin/index.jsp, request.getContextPath() (to get the base-path) should be replaceable w/ variables from the javascript (window or document) environment.

          After refactoring that, we'll only need the index.jsp for accessing the admin-cores path

          Show
          Stefan Matheis (steffkes) added a comment - the index.jsp is needed to gather Information about Cores [using org.apache.solr.core.CoreContainer] This is where the core admin handler should be useful – you can use it to get a list of cores and their statuses. In the example solr.xml (and by default if no solr.xml exists) it's available at "/admin/cores" but that can be changed – for now your JSP should be able to ask the CoreContainer for it using getAdminPath() Yes, will integrate this at the weekend - thanks for the pointer Hoss! Having another look at the admin/index.jsp, request.getContextPath() (to get the base-path) should be replaceable w/ variables from the javascript (window or document) environment. After refactoring that, we'll only need the index.jsp for accessing the admin-cores path
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Short Update, mainly Things that Jan mentioned on the Mailinglist:

          Move the links on top to bottom, reserving the top for navigation.

          done

          The "send email" could be changed to "Community forum" and instead of linking to solr-user@lucene.apache.org, link to http://wiki.apache.org/solr/UsingMailingLists

          done

          Add a link to IRC chat. http://webchat.freenode.net/?channels=#solr That would surely increase the activity on the channel

          done

          Include a Dev/Test/Prod indication:
          It is common to have three different environments, one for test, one for development and one live production. It happens now and then that you do the wrong action on the wrong server so a visual clue as to which environemnt you're in is very useful.
          I propose a simple solid bar on the very top which is RED for prod, YELLOW for test and GREEN for dev. Would it be possible to read a Java system property -Dsolr.environment=dev and based on that set the color of such a top-bar?

          also done - and yes, reading commandline-args is possible =) currently, the interface will check solr.environment and display it's value at the upper right corner. additionally, if the value starts with dev|test|prod the box gets some color-highlight

          Few Minutes ago, pushed the last Update to my GitHub-Repo which includes a (very) basic Tree-View for Zookeeper-Data. and also yes .. that (re-)introduced zookeeper.jsp, which is use for generating json-structured zk-tree-data - based on the existing one, just rearranged a few things

          Show
          Stefan Matheis (steffkes) added a comment - - edited Short Update, mainly Things that Jan mentioned on the Mailinglist: Move the links on top to bottom, reserving the top for navigation. done The "send email" could be changed to "Community forum" and instead of linking to solr-user@lucene.apache.org , link to http://wiki.apache.org/solr/UsingMailingLists done Add a link to IRC chat. http://webchat.freenode.net/?channels=#solr That would surely increase the activity on the channel done Include a Dev/Test/Prod indication: It is common to have three different environments, one for test, one for development and one live production. It happens now and then that you do the wrong action on the wrong server so a visual clue as to which environemnt you're in is very useful. I propose a simple solid bar on the very top which is RED for prod, YELLOW for test and GREEN for dev. Would it be possible to read a Java system property -Dsolr.environment=dev and based on that set the color of such a top-bar? also done - and yes, reading commandline-args is possible =) currently, the interface will check solr.environment and display it's value at the upper right corner. additionally, if the value starts with dev|test|prod the box gets some color-highlight Few Minutes ago, pushed the last Update to my GitHub-Repo which includes a (very) basic Tree-View for Zookeeper-Data. and also yes .. that (re-)introduced zookeeper.jsp, which is use for generating json-structured zk-tree-data - based on the existing one, just rearranged a few things
          Hide
          Jan Høydahl added a comment -

          Cool! I tested. Got a box for environment, but no color.

          I copied your code into admin/ in my solr.war - but it seems that your intention is for it to live in /solr-admin for the moment, is that right?

          I see that you store the state in the URL, but when reloading page, the left menu is not expanded.

          Show
          Jan Høydahl added a comment - Cool! I tested. Got a box for environment, but no color. I copied your code into admin/ in my solr.war - but it seems that your intention is for it to live in /solr-admin for the moment, is that right? I see that you store the state in the URL, but when reloading page, the left menu is not expanded.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Cool! I tested. Got a box for environment, but no color.

          Fine :> Related to the missing color, what was your solr.environment param? perhaps the used regexp is buggy

          I copied your code into admin/ in my solr.war - but it seems that your intention is for it to live in /solr-admin for the moment, is that right?

          Not really intention, it's just to have also access to the existing /admin pages, while developing the new interface finally all paths (where possible) should be relative, so that it doesn't matter if it's admin, solr-admin or something else

          I see that you store the state in the URL, but when reloading page, the left menu is not expanded.

          Yes, that's actually buggy .. don't know exactly why - but will fix that, ofc

          Show
          Stefan Matheis (steffkes) added a comment - Cool! I tested. Got a box for environment, but no color. Fine :> Related to the missing color, what was your solr.environment param? perhaps the used regexp is buggy I copied your code into admin/ in my solr.war - but it seems that your intention is for it to live in /solr-admin for the moment, is that right? Not really intention, it's just to have also access to the existing /admin pages, while developing the new interface finally all paths (where possible) should be relative, so that it doesn't matter if it's admin , solr-admin or something else I see that you store the state in the URL, but when reloading page, the left menu is not expanded. Yes, that's actually buggy .. don't know exactly why - but will fix that, ofc
          Hide
          Jan Høydahl added a comment -

          Tried with -Dsolr.environment=dev and also test and prod. The box shows up, but no color.

          Show
          Jan Høydahl added a comment - Tried with -Dsolr.environment=dev and also test and prod. The box shows up, but no color.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Thanks Jan for testing - after modifying the regex which was used to detect the environment, it's now working correctly [github commit]

          Show
          Stefan Matheis (steffkes) added a comment - Thanks Jan for testing - after modifying the regex which was used to detect the environment, it's now working correctly [ github commit ]
          Hide
          Lance Norskog added a comment -

          RED for prod, YELLOW for test and GREEN for dev.

          About 5% of men are dichromats: they have red/green color-blindness.Thus, production and dev will look the same (:
          I would reserve red for actual problem indicators.Maybe locked and unlocked icons?

          Show
          Lance Norskog added a comment - RED for prod, YELLOW for test and GREEN for dev. About 5% of men are dichromats: they have red/green color-blindness.Thus, production and dev will look the same (: I would reserve red for actual problem indicators.Maybe locked and unlocked icons?
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Lance, thanks for that notice & yes, perhaps we'll need some icon for that. actually there is which should be interpreted as "box/stage/server" ;o
          But, if anyone has suggestions, maybe from the fugue icon-set, i'm happy to change them to something more useful!

          Show
          Stefan Matheis (steffkes) added a comment - - edited Lance, thanks for that notice & yes, perhaps we'll need some icon for that. actually there is which should be interpreted as "box/stage/server" ;o But, if anyone has suggestions, maybe from the fugue icon-set , i'm happy to change them to something more useful!
          Hide
          Stefan Matheis (steffkes) added a comment -

          Jan,

          I see that you store the state in the URL, but when reloading page, the left menu is not expanded.

          Yes, that's actually buggy .. don't know exactly why - but will fix that, ofc

          it's fixed now – refactored the way of loading core-/system-data, should load now a little bit quicker and need less http-requests for gathering needed informations

          Show
          Stefan Matheis (steffkes) added a comment - Jan, I see that you store the state in the URL, but when reloading page, the left menu is not expanded. Yes, that's actually buggy .. don't know exactly why - but will fix that, ofc it's fixed now – refactored the way of loading core-/system-data, should load now a little bit quicker and need less http-requests for gathering needed informations
          Hide
          Stefan Matheis (steffkes) added a comment -

          Again from Jan's List

          Should there also be a tab above all cores, with host-wide stuff?

          • Solr version
          • Host name, port
          • Solr HOME path
          • Zookeeper info and link

          comitted today - not completly happy with the layout of the dashboard, but hopefully okay for now :]
          CoreAdmin is actually missing, yet not really an good idea how (and where) to integrate that, will see.

          Show
          Stefan Matheis (steffkes) added a comment - Again from Jan's List Should there also be a tab above all cores, with host-wide stuff? Solr version Host name, port Solr HOME path Zookeeper info and link comitted today - not completly happy with the layout of the dashboard, but hopefully okay for now :] CoreAdmin is actually missing, yet not really an good idea how (and where) to integrate that, will see.
          Hide
          Jan Høydahl added a comment -

          @Lance: IMHO we design for 95% of the users, not 5%. Keep it simple - RED-YELLOW-GREEN with the addition of a symbol for those 5%. They can even hack the CSS if they like a special color for production.

          Show
          Jan Høydahl added a comment - @Lance: IMHO we design for 95% of the users, not 5%. Keep it simple - RED-YELLOW-GREEN with the addition of a symbol for those 5%. They can even hack the CSS if they like a special color for production.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Additional point from Jan's list:

          Improve the admin-extra.html concept:
          Today, if the file admin-extra.html exists it will be included near top of current admin GUI. This can be useful, but in this new design, it perhaps makes more sense to include the admin-extra.html contents in a widget box on each core. Then each organization can customize and put links to their internal issue trackers etc..

          I've integrated an additional box on the dashboard (will check for an admin-extra.html file) and the possibility to include additional menu-items (will check for an admin-extra.menu-top.html and admin-extra.menu-bottom.html file).

          it's both related to a specific core - is there a need for an additional navigation/box for host-wide stuff?

          Show
          Stefan Matheis (steffkes) added a comment - Additional point from Jan's list: Improve the admin-extra.html concept: Today, if the file admin-extra.html exists it will be included near top of current admin GUI. This can be useful, but in this new design, it perhaps makes more sense to include the admin-extra.html contents in a widget box on each core. Then each organization can customize and put links to their internal issue trackers etc.. I've integrated an additional box on the dashboard (will check for an admin-extra.html file) and the possibility to include additional menu-items (will check for an admin-extra.menu-top.html and admin-extra.menu-bottom.html file). it's both related to a specific core - is there a need for an additional navigation/box for host-wide stuff?
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Another item from Jan's list

          In the "System" tab for each core, it would be great to show a number of key info:

          • # docs
          • Size of index (Mb)
          • Last add/delete timestamp
          • Optimized status (with a button to optimize now)

          it's integrated on the dashboard.

          What actually is not possible, is to display the index-size - that's actually only avaible from ReplicationHandler, right? :/

          one question on Luke's Data: "hasDeletions" says that the Index could/should be optimized, so makes sense to integrate an button there with "commit now"?

          Show
          Stefan Matheis (steffkes) added a comment - - edited Another item from Jan's list In the "System" tab for each core, it would be great to show a number of key info: # docs Size of index (Mb) Last add/delete timestamp Optimized status (with a button to optimize now) it's integrated on the dashboard . What actually is not possible, is to display the index-size - that's actually only avaible from ReplicationHandler , right? :/ one question on Luke's Data: " hasDeletions " says that the Index could/should be optimized, so makes sense to integrate an button there with "commit now"?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Last item for today

          On the "Query" tab for each core:

          • Add an input box for "query type", setting the "qt" param
          • Adding a some links below the input boxes, expanding by JavaScript:
            • dismax params
            • spatial params
            • spellcheck params
            • faceting params

          integrated too - when there is a field missing, please let me know, not sure especially on the spatial-options.

          Show
          Stefan Matheis (steffkes) added a comment - Last item for today On the "Query" tab for each core: Add an input box for "query type", setting the "qt" param Adding a some links below the input boxes, expanding by JavaScript: dismax params spatial params spellcheck params faceting params integrated too - when there is a field missing, please let me know, not sure especially on the spatial-options.
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          A bigger step compared with those one we had yet, we are talking about the Schema-Browser :>

          Just to say:

          • CopyField's are also displayed in the area below the Selection, if defined.
          • Every F/DF/T is clickable, linked with his Detail-Page

          (Explicit) Questions for the Community:

          • TopTerms are actually limited to 50, is that enough? Or is there a need to browse all TopTerms?
          • Analyzers-Detail, hide it for default - with a Toggle-Button (like it is actually)?
          • Analyzers-Detail, Presentation okay - or needs to much space?
          • F/DF/T-Selection, actually there is no possibilty to filter (like f.e. in iTunes; additional field, start typing and the list is restricted) - would that help for those of us, that have a lot of fields?
          Show
          Stefan Matheis (steffkes) added a comment - - edited A bigger step compared with those one we had yet, we are talking about the Schema-Browser :> The current one (screenshot) needs much space (especially for the navigation) The new one (screenshot) tries to put the focus more on details & information The new Field/Dynamic Field/Type-Selection (screenshot) is diplayed in a simple Dropdown, which offers Keyboard-Navigation for Quick-Access The list of "relations" (screenshot) depends on the selected F/DF/T Just to say: CopyField's are also displayed in the area below the Selection, if defined. Every F/DF/T is clickable, linked with his Detail-Page (Explicit) Questions for the Community: TopTerms are actually limited to 50, is that enough? Or is there a need to browse all TopTerms? Analyzers-Detail, hide it for default - with a Toggle-Button (like it is actually)? Analyzers-Detail, Presentation okay - or needs to much space? F/DF/T-Selection, actually there is no possibilty to filter (like f.e. in iTunes; additional field, start typing and the list is restricted) - would that help for those of us, that have a lot of fields?
          Hide
          Ryan McKinley added a comment -

          screenshots look good!

          TopTerms are actually limited to 50, is that enough? Or is there a need to browse all TopTerms?

          I think this is mostly a UI/speed issue – displaying more then 50 terms is good if the UI works well.

          Analyzers-Detail, hide it for default - with a Toggle-Button (like it is actually)?

          I like the looks of your screenshot – looks awesome. Have not tried the patch, but things I would wish for:

          • easy link from field/fieldtype to analysis.jsp, maybe expandable input form?
          • click on 'stopwords.txt' to view it

          Analyzers-Detail, Presentation okay - or needs to much space?

          I like it.

          F/DF/T-Selection, actually there is no possibilty to filter

          typing to restrict would be great. if possible, good to clearly display how many are hidden, and easily click to remove them (with itunes i often forget that something is in the search box, but i am kinda slow sometimes)

          looking good!

          Show
          Ryan McKinley added a comment - screenshots look good! TopTerms are actually limited to 50, is that enough? Or is there a need to browse all TopTerms? I think this is mostly a UI/speed issue – displaying more then 50 terms is good if the UI works well. Analyzers-Detail, hide it for default - with a Toggle-Button (like it is actually)? I like the looks of your screenshot – looks awesome. Have not tried the patch, but things I would wish for: easy link from field/fieldtype to analysis.jsp, maybe expandable input form? click on 'stopwords.txt' to view it Analyzers-Detail, Presentation okay - or needs to much space? I like it. F/DF/T-Selection, actually there is no possibilty to filter typing to restrict would be great. if possible, good to clearly display how many are hidden, and easily click to remove them (with itunes i often forget that something is in the search box, but i am kinda slow sometimes) looking good!
          Hide
          Mark Miller added a comment -

          Hey Stefan,

          I had seen this issue in passing, but had not yet taken a closer look...

          Fantastic stuff! I think this is a sorely needed face lift, and your screen shots look like a brilliant upgrade. Really nice to see some effort put into this area of Solr.

          Show
          Mark Miller added a comment - Hey Stefan, I had seen this issue in passing, but had not yet taken a closer look... Fantastic stuff! I think this is a sorely needed face lift, and your screen shots look like a brilliant upgrade. Really nice to see some effort put into this area of Solr.
          Hide
          Bill Bell added a comment -

          Here are things I need / or bothering me:

          1. Core management - reload and swapping is critical
          2. Replication - Ability to click a button for backup
          3. Change analysis.jsp to allow someone to select pipeline components to try in real time on the data
          4. Ability to password protect the whole GUI without limiting access to update handlers
          5. Ability to edit stopwords.txt, protwords.txt and synonyms and reload.
          6. Ability to click to see the solr.log from Admin
          7. Ability to click to commit, and click to optimize an index
          8. Ability to edit the dataimport.xml file and save it
          9. Fix the dataimport.jsp to fix the scrolling when looking at the xml file - it does not work right. If you made the window bigger the right side is static.
          10. Make DIH (if enabled) an option on the Admin screen (clickable)
          11. I am not a huge fan of editing the schema or solrconfig files, but I would like it easy to navigate the file properties (it is hard to view)
          12. Button to restart/recycle SOLR from the GUI
          13. Show list of slaves on the replication screen and when they last requested the files

          Show
          Bill Bell added a comment - Here are things I need / or bothering me: 1. Core management - reload and swapping is critical 2. Replication - Ability to click a button for backup 3. Change analysis.jsp to allow someone to select pipeline components to try in real time on the data 4. Ability to password protect the whole GUI without limiting access to update handlers 5. Ability to edit stopwords.txt, protwords.txt and synonyms and reload. 6. Ability to click to see the solr.log from Admin 7. Ability to click to commit, and click to optimize an index 8. Ability to edit the dataimport.xml file and save it 9. Fix the dataimport.jsp to fix the scrolling when looking at the xml file - it does not work right. If you made the window bigger the right side is static. 10. Make DIH (if enabled) an option on the Admin screen (clickable) 11. I am not a huge fan of editing the schema or solrconfig files, but I would like it easy to navigate the file properties (it is hard to view) 12. Button to restart/recycle SOLR from the GUI 13. Show list of slaves on the replication screen and when they last requested the files
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Ryan: ty, will take your points on my list - pretty sure, that it should be possible to integrate them
          Mark: ty!

          For today, it's about Logging. Talked about that with Hoss on #solr the last days, so already changed a few things .. on the way, but not finished: http://files.mathe.is/solr-admin/07_logging.png

          Actually thinking about the following points:

          • Tree Structure good way to solve it?
          • Do we need the possibitly to collapse/expand the three/the childrens? The List could be longer (the screenshot is cropped, just for layout reasons) especially while using SolrCloud which adds about 30 Loggers
          • In the current er .. "Interface" you are able to see that the row you're looking at has a level set and in the end (at the right) which is the effective level - for me, that does not matter. if a row/logger, has level-x - that's enough to know. don't need to see if this level is set or inherited.
          • just a quick idea: if you change f.e. org.apache.solr then the interface will automatically update all childrens in realtime, affects all nested/sub loggers w/o a assigned level.

          Thoughts on these points? anyone? :>

          Short Note: i moved Logging to a global level, because it's not configurable on a per-core basis.

          1. Edit

          What i forgot to mention .. actually it's based on a static logging.json-file but will try to change the LogLevelSection Servlet so that it outputs the needed json-structure

          Show
          Stefan Matheis (steffkes) added a comment - - edited Ryan: ty, will take your points on my list - pretty sure, that it should be possible to integrate them Mark: ty! For today, it's about Logging . Talked about that with Hoss on #solr the last days, so already changed a few things .. on the way, but not finished: http://files.mathe.is/solr-admin/07_logging.png Actually thinking about the following points: Tree Structure good way to solve it? Do we need the possibitly to collapse/expand the three/the childrens? The List could be longer (the screenshot is cropped, just for layout reasons) especially while using SolrCloud which adds about 30 Loggers In the current er .. "Interface" you are able to see that the row you're looking at has a level set and in the end (at the right) which is the effective level - for me, that does not matter. if a row/logger, has level-x - that's enough to know. don't need to see if this level is set or inherited. just a quick idea: if you change f.e. org.apache.solr then the interface will automatically update all childrens in realtime, affects all nested/sub loggers w/o a assigned level. Thoughts on these points? anyone? :> Short Note: i moved Logging to a global level, because it's not configurable on a per-core basis. Edit What i forgot to mention .. actually it's based on a static logging.json-file but will try to change the LogLevelSection Servlet so that it outputs the needed json-structure
          Hide
          Upayavira added a comment -

          Your code assumes multicore. If you run it on a single core host, it attempts to load the core admin handler from /solrnull?wt=json, which clearly doesn't make sense!

          You can identify whether you are multicore or not, by testing app.config.core_admin_path == "null". I've managed to get it working, but had to 'fake' an HTTP request to the CoreAdmin (there's no equivalent in single-core solr that I know of). I'll keep hacking and see if I can offer a patch that is a bit more elegant.

          Upayavira

          Show
          Upayavira added a comment - Your code assumes multicore. If you run it on a single core host, it attempts to load the core admin handler from /solrnull?wt=json, which clearly doesn't make sense! You can identify whether you are multicore or not, by testing app.config.core_admin_path == "null". I've managed to get it working, but had to 'fake' an HTTP request to the CoreAdmin (there's no equivalent in single-core solr that I know of). I'll keep hacking and see if I can offer a patch that is a bit more elegant. Upayavira
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Upayavira, thanks for pointing that out! the plan was to check automatically if you're running an single- or multicore installation, seemed that is was broken somewhere along the road :/

          For your possible patch: CoreAdmin is available even for SingleCore Mode, at least in 3.x - i thought i checked this also for 1.4; but will have a look again on that

          1. Edit: Just checked my Code .. would be interesting to know, what your Solr-Installation returns here: https://github.com/steffkes/solr-admin/blob/master/index.jsp#L22 ?

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - - edited Upayavira, thanks for pointing that out! the plan was to check automatically if you're running an single- or multicore installation, seemed that is was broken somewhere along the road :/ For your possible patch: CoreAdmin is available even for SingleCore Mode, at least in 3.x - i thought i checked this also for 1.4; but will have a look again on that Edit: Just checked my Code .. would be interesting to know, what your Solr-Installation returns here: https://github.com/steffkes/solr-admin/blob/master/index.jsp#L22 ? Stefan
          Hide
          Upayavira added a comment -

          It returns null. Which, the JSP treats as a string, so core_admin_path becomes "null". So, you can easily detect single-core that way.

          You need quite different code paths for the two scenarios, as for single core you don't need to do an HTTP request to the core_admin. I'm half-way through an improved version (without a fake HTTP request). I'll see if I can work out how to use github to share it.

          Upayavira

          Show
          Upayavira added a comment - It returns null. Which, the JSP treats as a string, so core_admin_path becomes "null". So, you can easily detect single-core that way. You need quite different code paths for the two scenarios, as for single core you don't need to do an HTTP request to the core_admin. I'm half-way through an improved version (without a fake HTTP request). I'll see if I can work out how to use github to share it. Upayavira
          Hide
          Stefan Matheis (steffkes) added a comment -

          Upayavira, take whatever way you like for the patch - github fork/pull-request, comment here or just send me an email

          related to the Fact, that solr running in singlecore mode shold have no CoreAdmin .. i just checked out Revision 1085057 from branch_3x and trunk – the returned both "/admin/cores" for cores.getAdminPath() while started with a simple java -jar start.jar. Which Version/Configuration is doing something different?

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - Upayavira, take whatever way you like for the patch - github fork/pull-request, comment here or just send me an email related to the Fact, that solr running in singlecore mode shold have no CoreAdmin .. i just checked out Revision 1085057 from branch_3x and trunk – the returned both "/admin/cores" for cores.getAdminPath() while started with a simple java -jar start.jar . Which Version/Configuration is doing something different? Stefan
          Hide
          Upayavira added a comment -

          Now that there are 3.1 releases around, I'll try it with 3.1 and see what I get, as that is where this code will end up.

          Upayavira

          Show
          Upayavira added a comment - Now that there are 3.1 releases around, I'll try it with 3.1 and see what I get, as that is where this code will end up. Upayavira
          Hide
          Stefan Matheis (steffkes) added a comment -

          It will work like expected for everything >= 3.x - Just checked out the 1.3 und 1.4 branches and verified that getAdminPath returns 'null' there ;o

          So, will wait for your patch – and in the meantime, i'll check how the new admin ui will work with the old releases

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - It will work like expected for everything >= 3.x - Just checked out the 1.3 und 1.4 branches and verified that getAdminPath returns ' null ' there ;o So, will wait for your patch – and in the meantime, i'll check how the new admin ui will work with the old releases Stefan
          Hide
          Upayavira added a comment -

          There's no need to test it with old releases. If this code is destined to be a part of Solr, it'd be released with the latest code, so that is the code it needs to work with.

          Upayavira

          Show
          Upayavira added a comment - There's no need to test it with old releases. If this code is destined to be a part of Solr, it'd be released with the latest code, so that is the code it needs to work with. Upayavira
          Hide
          Stefan Matheis (steffkes) added a comment -

          But if we could support the older versions w/o problems, why not? if you don't want to continue w/ the patch - it's ofc okay, but i'll continue checking the new ui for 1.3/1.4 versions and bring the features back to work

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - But if we could support the older versions w/o problems, why not? if you don't want to continue w/ the patch - it's ofc okay, but i'll continue checking the new ui for 1.3/1.4 versions and bring the features back to work Stefan
          Hide
          Upayavira added a comment -

          To give folks an incentive to upgrade?

          I've found another issue. The 3.x branch does not have jvm/memory/raw in response to /solr/admin/system?wt=json. I've made a (crude but working) patch, which I've put here:

          https://github.com/upayavira/solr-admin/commit/6abc78fe6f15d79bd8d566282d4ee8e5af4cb27d

          Let me know if you can work with this ( me=git newbie )

          Upayavira

          Show
          Upayavira added a comment - To give folks an incentive to upgrade? I've found another issue. The 3.x branch does not have jvm/memory/raw in response to /solr/admin/system?wt=json. I've made a (crude but working) patch, which I've put here: https://github.com/upayavira/solr-admin/commit/6abc78fe6f15d79bd8d566282d4ee8e5af4cb27d Let me know if you can work with this ( me=git newbie ) Upayavira
          Hide
          Upayavira added a comment -

          Hah, I see you've fixed this already. But I deal with KB and GB too

          Show
          Upayavira added a comment - Hah, I see you've fixed this already. But I deal with KB and GB too
          Hide
          Upayavira added a comment -

          It seems to me that the first task here is to reach a feature-for-feature replacement for the existing UI. I'd like to help if I can. I've gone through the two UIs, and here's the stuff I note as missing/incomplete:

          • "current time" is not shown
          • cwd not working
          • ping adds the ping duration to the link. Add "ms" to make it clearer what this is
          • there's no "debug explain others" option on the advanced query page
          • it would be good to add mouseover tooltips to fields, eg. fq, wt, etc
          • output type (wt) is missing from query page
          • thread dump is missing: http://localhost:8983/solr/admin/threaddump.jsp
          • Java properties are JVM specific, not core specific, so should be on the dashboard
          • Distribution page is missing: http://localhost:8983/solr/admin/distributiondump.jsp

          Upayavira

          Show
          Upayavira added a comment - It seems to me that the first task here is to reach a feature-for-feature replacement for the existing UI. I'd like to help if I can. I've gone through the two UIs, and here's the stuff I note as missing/incomplete: "current time" is not shown cwd not working ping adds the ping duration to the link. Add "ms" to make it clearer what this is there's no "debug explain others" option on the advanced query page it would be good to add mouseover tooltips to fields, eg. fq, wt, etc output type (wt) is missing from query page thread dump is missing: http://localhost:8983/solr/admin/threaddump.jsp Java properties are JVM specific, not core specific, so should be on the dashboard Distribution page is missing: http://localhost:8983/solr/admin/distributiondump.jsp Upayavira
          Hide
          Upayavira added a comment -

          I've updated my github repo with an implementation of thread dumps. Could look nicer, but it works well.

          Show
          Upayavira added a comment - I've updated my github repo with an implementation of thread dumps. Could look nicer, but it works well.
          Hide
          Erick Erickson added a comment -

          Sorry, hit the assign button by mistake....

          Show
          Erick Erickson added a comment - Sorry, hit the assign button by mistake....
          Hide
          Upayavira added a comment -

          https://github.com/upayavira/solr-admin/commit/a96d7b8bc63cb5ae6125c0a2c91302f553782ef2

          • added current time (note, it is the time the overall page was loaded, not "now").
          • fixed cwd. I've added 'ms' to ping and made it stand out more.
          • fixed threaddump to make it work multicore
          • moved java properties to global level
          • removed replication link - info is already on dashboard

          IMO this is now ready for testing - folks, please try it on your browsers (I've seen it work on Firefox/Chrome on Linux and Firefox on Mac). Anyone able to try it on IE?

          Show
          Upayavira added a comment - https://github.com/upayavira/solr-admin/commit/a96d7b8bc63cb5ae6125c0a2c91302f553782ef2 added current time (note, it is the time the overall page was loaded, not "now"). fixed cwd. I've added 'ms' to ping and made it stand out more. fixed threaddump to make it work multicore moved java properties to global level removed replication link - info is already on dashboard IMO this is now ready for testing - folks, please try it on your browsers (I've seen it work on Firefox/Chrome on Linux and Firefox on Mac). Anyone able to try it on IE?
          Hide
          Stefan Matheis (steffkes) added a comment -

          So, long time silence ..

          I've updated my github repo with a few things .. fixes and also a new threaddump-list, which was originally created by Upayavira, thanks!

          Also started a new Wiki-Page http://wiki.apache.org/solr/ReworkedSolrAdminGUI - i'm not really good at marketing, so the Page is really basic and everybody is invited to update it.

          As Upayavira stated last Tuesday there are still a few Things missing, compared to the current Admin-UI .. but i'd like to now: Which are the Features that you will need to give the reworked UI a try? One of the listed features? Or, will it be easier, if the Code would work from /solr/admin?

          Please let me know – Feedback is really appreciated

          Show
          Stefan Matheis (steffkes) added a comment - So, long time silence .. I've updated my github repo with a few things .. fixes and also a new threaddump-list, which was originally created by Upayavira, thanks! Also started a new Wiki-Page http://wiki.apache.org/solr/ReworkedSolrAdminGUI - i'm not really good at marketing, so the Page is really basic and everybody is invited to update it. As Upayavira stated last Tuesday there are still a few Things missing, compared to the current Admin-UI .. but i'd like to now: Which are the Features that you will need to give the reworked UI a try? One of the listed features? Or, will it be easier, if the Code would work from /solr/admin? Please let me know – Feedback is really appreciated
          Hide
          Erick Erickson added a comment -

          OK, I've finally figured out Git enough (another newbie with Git). First of all, I'm really glad you're taking this on, it'll be a vast improvement. If you only knew how poor my page design ability is, you'd understand why I'm so glad someone else is doing this...

          One thing I noticed on a cursory look. The analysis page with the red/yellow is really jarring to people "of a certain age" like me. Can you tone the background colors waaaay down to a soft pastel? I'm talking the palest yellow and red (or blue?) you can still see.

          And when I type long strings to be analyzed, the display for each part (index/query) runs all over. I don't know what the right fix is, possibly a slider for each side (if it's not too hard)?

          Love the drop-down on that page!

          On the "schema browser" page, selecting a type from the drop-down shows nothing.

          I'm not quite sure what request caused the following to pop out in my log, but here's the partial stack trace:

          Apr 18, 2011 5:17:32 PM org.apache.solr.core.SolrCore execute
          INFO: [] webapp=/solr path=/admin/file/ params=

          {file=admin-extra.menu-bottom.html}

          status=400 QTime=4
          Apr 18, 2011 5:17:32 PM org.apache.solr.common.SolrException log
          SEVERE: org.apache.solr.common.SolrException: Can not find: admin-extra.menu-top.html [C:\apache-trunk\solr\example\solr
          \.\conf\admin-extra.menu-top.html]
          at org.apache.solr.handler.admin.ShowFileRequestHandler.handleRequestBody(ShowFileRequestHandler.java:152)
          at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:129)
          at org.apache.solr.core.SolrCore.execute(SolrCore.java:1290)
          at org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:353)
          at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:248)
          at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)

          I may get some more time to look later this evening. Is there anything useful I can do?

          Best
          Erick

          Show
          Erick Erickson added a comment - OK, I've finally figured out Git enough (another newbie with Git). First of all, I'm really glad you're taking this on, it'll be a vast improvement. If you only knew how poor my page design ability is, you'd understand why I'm so glad someone else is doing this... One thing I noticed on a cursory look. The analysis page with the red/yellow is really jarring to people "of a certain age" like me. Can you tone the background colors waaaay down to a soft pastel? I'm talking the palest yellow and red (or blue?) you can still see. And when I type long strings to be analyzed, the display for each part (index/query) runs all over. I don't know what the right fix is, possibly a slider for each side (if it's not too hard)? Love the drop-down on that page! On the "schema browser" page, selecting a type from the drop-down shows nothing. I'm not quite sure what request caused the following to pop out in my log, but here's the partial stack trace: Apr 18, 2011 5:17:32 PM org.apache.solr.core.SolrCore execute INFO: [] webapp=/solr path=/admin/file/ params= {file=admin-extra.menu-bottom.html} status=400 QTime=4 Apr 18, 2011 5:17:32 PM org.apache.solr.common.SolrException log SEVERE: org.apache.solr.common.SolrException: Can not find: admin-extra.menu-top.html [C:\apache-trunk\solr\example\solr \.\conf\admin-extra.menu-top.html] at org.apache.solr.handler.admin.ShowFileRequestHandler.handleRequestBody(ShowFileRequestHandler.java:152) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:129) at org.apache.solr.core.SolrCore.execute(SolrCore.java:1290) at org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:353) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:248) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) I may get some more time to look later this evening. Is there anything useful I can do? Best Erick
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Erick,

          I may get some more time to look later this evening. Is there anything useful I can do?

          That was already helpful – thank you I'd just say: continue using it .. and just let us know, where you found something that could/should be changed, from your perspective.

          OK, I've finally figured out Git enough (another newbie with Git)

          Ah, never thought about that .. would it be easier to use an svn-repository instead of git? may that be a (or at least, the) reason, that only a few people will have a look at it?

          One thing I noticed on a cursory look. The analysis page with the red/yellow is really jarring to people "of a certain age" like me. Can you tone the background colors waaaay down to a soft pastel? I'm talking the palest yellow and red (or blue?) you can still see.

          oh, i think you found the poorest page we actually have ;o of course that would be fixed from a layout-view, and there are still features missing. i'm still not sure, if a two-column layout would work for most cases - because like you actually realized, with longer strings .. there is not enough space :/ Vertical Scrolling is not useful in this scenario. perhaps we should try to rearrange the analysis-output a little bit

          On the "schema browser" page, selecting a type from the drop-down shows nothing.

          yes, the schema browser currently works only for fields, and neihter dynamic-fields nor types - will add this over the weekend :> but just to be sure, your address-bar changed after selecting a new option from the drop-down, right?

          I'm not quite sure what request caused the following to pop out in my log, but here's the partial stack trace:

          Apr 18, 2011 5:17:32 PM org.apache.solr.core.SolrCore execute
          INFO: [] webapp=/solr path=/admin/file/ params={file=admin-extra.menu-bottom.html} status=400 QTime=4

          That's a new "feature" :] where you could easily extend the menu on the left side of the ui, like i mentioned in this comment (12/Mrz/11 15:02)

          And, just to say it again: using it, will give us input what is important for yo. so continue there, and let uns know what you think. no difference if it's a non-working thing or a almost-working thing that should be changed or just a new idea that you have while working with it!

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - - edited Erick, I may get some more time to look later this evening. Is there anything useful I can do? That was already helpful – thank you I'd just say: continue using it .. and just let us know, where you found something that could/should be changed, from your perspective. OK, I've finally figured out Git enough (another newbie with Git) Ah, never thought about that .. would it be easier to use an svn-repository instead of git? may that be a (or at least, the) reason, that only a few people will have a look at it? One thing I noticed on a cursory look. The analysis page with the red/yellow is really jarring to people "of a certain age" like me. Can you tone the background colors waaaay down to a soft pastel? I'm talking the palest yellow and red (or blue?) you can still see. oh, i think you found the poorest page we actually have ;o of course that would be fixed from a layout-view, and there are still features missing. i'm still not sure, if a two-column layout would work for most cases - because like you actually realized, with longer strings .. there is not enough space :/ Vertical Scrolling is not useful in this scenario. perhaps we should try to rearrange the analysis-output a little bit On the "schema browser" page, selecting a type from the drop-down shows nothing. yes, the schema browser currently works only for fields, and neihter dynamic-fields nor types - will add this over the weekend :> but just to be sure, your address-bar changed after selecting a new option from the drop-down, right? I'm not quite sure what request caused the following to pop out in my log, but here's the partial stack trace: Apr 18, 2011 5:17:32 PM org.apache.solr.core.SolrCore execute INFO: [] webapp=/solr path=/admin/file/ params={file=admin-extra.menu-bottom.html} status=400 QTime=4 That's a new "feature" :] where you could easily extend the menu on the left side of the ui, like i mentioned in this comment (12/Mrz/11 15:02) And, just to say it again: using it, will give us input what is important for yo. so continue there, and let uns know what you think. no difference if it's a non-working thing or a almost-working thing that should be changed or just a new idea that you have while working with it! Stefan
          Hide
          Erick Erickson added a comment -

          Schema browser page: Yep, after selecting the "geohash" type the URL changed to: http://localhost:8983/solr/admin/#/singlecore/schema-browser/type/geohash

          Analysis page: I was thinking of two horizontal scrollbars, one for each pane, not vertical ones. But I have no idea how hard that would be, if it's more than 15 minutes I'd probably defer it. I suspect 95% of the usefulness of that page can be had with two or three words anyway.... Or maybe just a single slider that moved both panes? Because the two-column layout actually nicely brings attention to the fact that index and query time analysis are not necessarily the same, a point that often escapes folks just starting.

          About Git. It's perfectly reasonable to attach patches to this JIRA that are "working copies" and not intended to be committed. I'm not sure how a Git patch plays with SVN. If you want I'll be happy to try out any GIT-generated patch files on my system, we can do that offline.

          What IDE are you using? I usually just cheat and have Idea create patches for me, it "just works" and I haven't had to fiddle with it. I think that IntelliJ reasonably happily works with both VCSs, but can't say that's true from experience. I'm pretty sure Eclipse has the same capabilities...

          Erick

          Show
          Erick Erickson added a comment - Schema browser page: Yep, after selecting the "geohash" type the URL changed to: http://localhost:8983/solr/admin/#/singlecore/schema-browser/type/geohash Analysis page: I was thinking of two horizontal scrollbars, one for each pane, not vertical ones. But I have no idea how hard that would be, if it's more than 15 minutes I'd probably defer it. I suspect 95% of the usefulness of that page can be had with two or three words anyway.... Or maybe just a single slider that moved both panes? Because the two-column layout actually nicely brings attention to the fact that index and query time analysis are not necessarily the same, a point that often escapes folks just starting. About Git. It's perfectly reasonable to attach patches to this JIRA that are "working copies" and not intended to be committed. I'm not sure how a Git patch plays with SVN. If you want I'll be happy to try out any GIT-generated patch files on my system, we can do that offline. What IDE are you using? I usually just cheat and have Idea create patches for me, it "just works" and I haven't had to fiddle with it. I think that IntelliJ reasonably happily works with both VCSs, but can't say that's true from experience. I'm pretty sure Eclipse has the same capabilities... Erick
          Hide
          Jan Høydahl added a comment -

          Git and svn patches do not go well together. There are hairy scripts to work around that somehow, but I think for this issue, the easiest way to create a patch is the manual way:

          svn co <path-to-lucene-trunk> lucene-trunk
          cd lucene-trunk
          unzip <new-admin-stuff-from-git>
          svn patch > SOLR-2399.patch
          
          Show
          Jan Høydahl added a comment - Git and svn patches do not go well together. There are hairy scripts to work around that somehow, but I think for this issue, the easiest way to create a patch is the manual way: svn co <path-to-lucene-trunk> lucene-trunk cd lucene-trunk unzip < new -admin-stuff-from-git> svn patch > SOLR-2399.patch
          Hide
          Upayavira added a comment -

          Patching/etc really aren't much of an issue with this ticket. It is mostly a completely new tree of files. It may be a question of merging two directory trees (the new code relying on the output of one or two old jsp files) but there's not a great deal more than that to it.

          Git in this scenario is simply a useful tool for collaboration before the code gets anywhere near SVN.

          Upayavira

          Show
          Upayavira added a comment - Patching/etc really aren't much of an issue with this ticket. It is mostly a completely new tree of files. It may be a question of merging two directory trees (the new code relying on the output of one or two old jsp files) but there's not a great deal more than that to it. Git in this scenario is simply a useful tool for collaboration before the code gets anywhere near SVN. Upayavira
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          So, it's weekend .. time to work on the analysis page – what else ;o

          Analysis page: I was thinking of two horizontal scrollbars, one for each pane, not vertical ones. But I have no idea how hard that would be, if it's more than 15 minutes I'd probably defer it. I suspect 95% of the usefulness of that page can be had with two or three words anyway.... Or maybe just a single slider that moved both panes? Because the two-column layout actually nicely brings attention to the fact that index and query time analysis are not necessarily the same, a point that often escapes folks just starting.

          i've tried a few things, i think it's okay, no?
          normal: current vs. new, verbose: current vs. new

          just to note: "verbose output" requires no page-reload, all needed information is already fetched in this state. if longer strings are used, the two columns will move among themselves.

          Show
          Stefan Matheis (steffkes) added a comment - - edited So, it's weekend .. time to work on the analysis page – what else ;o Analysis page: I was thinking of two horizontal scrollbars, one for each pane, not vertical ones. But I have no idea how hard that would be, if it's more than 15 minutes I'd probably defer it. I suspect 95% of the usefulness of that page can be had with two or three words anyway.... Or maybe just a single slider that moved both panes? Because the two-column layout actually nicely brings attention to the fact that index and query time analysis are not necessarily the same, a point that often escapes folks just starting. i've tried a few things, i think it's okay, no? normal: current vs. new , verbose: current vs. new just to note: "verbose output" requires no page-reload, all needed information is already fetched in this state. if longer strings are used, the two columns will move among themselves.
          Hide
          Ryan McKinley added a comment -

          Stefan... this is looking great!

          A couple things to note:

          • seeing the parameters to each Tokenizer/Filer is pretty important. The {splitOnCaseChange=1,... }
          • Maybe tooltips for P -> Position Offset, T -> Type, T -> Term etc?
          • With tooltips, it would be pretty nice to show full information when you hover over an element the normal view.
          Show
          Ryan McKinley added a comment - Stefan... this is looking great! A couple things to note: seeing the parameters to each Tokenizer/Filer is pretty important. The {splitOnCaseChange=1,... } Maybe tooltips for P -> Position Offset, T -> Type, T -> Term etc? With tooltips, it would be pretty nice to show full information when you hover over an element the normal view.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Thanks Ryan,

          seeing the parameters to each Tokenizer/Filer is pretty important. The {splitOnCaseChange=1,... }

          FieldAnalysisRequestHandler seems to be a little bit shy – it's not included in it's ouput, will fill another ticket for this.

          Maybe tooltips for P -> Position Offset, T -> Type, T -> Term etc?

          normally, they shoud be there? i've used a the html-element <abbr> with title-Attribute, which should work in every current Browser - even IE6 ;D Which one did you use? or just from looking at the screenshots? then yes, there is nothing like this shown :>

          With tooltips, it would be pretty nice to show full information when you hover over an element the normal view.

          hm yes .. played around w/ that .. the main 'problem' is, that the full text (f.e. "Position") is really long and takes much space. but will see, if i could cut off the description a little bit, so that there is more that one character .. something like Pos for Position, Text, Type & Range for Start, End perhaps?

          Show
          Stefan Matheis (steffkes) added a comment - Thanks Ryan, seeing the parameters to each Tokenizer/Filer is pretty important. The {splitOnCaseChange=1,... } FieldAnalysisRequestHandler seems to be a little bit shy – it's not included in it's ouput, will fill another ticket for this. Maybe tooltips for P -> Position Offset, T -> Type, T -> Term etc? normally, they shoud be there? i've used a the html-element <abbr> with title -Attribute, which should work in every current Browser - even IE6 ;D Which one did you use? or just from looking at the screenshots? then yes, there is nothing like this shown :> With tooltips, it would be pretty nice to show full information when you hover over an element the normal view. hm yes .. played around w/ that .. the main 'problem' is, that the full text (f.e. "Position") is really long and takes much space. but will see, if i could cut off the description a little bit, so that there is more that one character .. something like Pos for Position, Text, Type & Range for Start, End perhaps?
          Hide
          Ryan McKinley added a comment -

          will fill another ticket for this.

          Ahh yes – i think there may already be one

          or just from looking at the screenshots?

          just looking at screenshots!

          is really long and takes much space

          I was thinking a tooltip that loads a div and takes the space to make a full display... not the built in hover text stuff. Just a wish

          anyway, looking great.

          Show
          Ryan McKinley added a comment - will fill another ticket for this. Ahh yes – i think there may already be one or just from looking at the screenshots? just looking at screenshots! is really long and takes much space I was thinking a tooltip that loads a div and takes the space to make a full display... not the built in hover text stuff. Just a wish anyway, looking great.
          Hide
          Uwe Schindler added a comment -

          In general, the screenshots look fine, but:

          Please list all attributes (even if you think that they are unimportant). For debugging/understanding TokenStreams this is veeeeery important. E.g. new Japanese TokenStreams have most information of the analysis steps in the attributes not the token text alone: Since Lucene 2.9, lots of analyzers add many more attributes to tokens that are required to display if you want to understand what the streams are doing (please look at the current analysis.jsp output). So please also display the full class name of all attributes at least as hover and also the raw tokens, if the RequestHandler returns them.

          The current output is now useless for advanced debugging.

          Show
          Uwe Schindler added a comment - In general, the screenshots look fine, but: Please list all attributes (even if you think that they are unimportant). For debugging/understanding TokenStreams this is veeeeery important. E.g. new Japanese TokenStreams have most information of the analysis steps in the attributes not the token text alone: Since Lucene 2.9, lots of analyzers add many more attributes to tokens that are required to display if you want to understand what the streams are doing (please look at the current analysis.jsp output). So please also display the full class name of all attributes at least as hover and also the raw tokens, if the RequestHandler returns them. The current output is now useless for advanced debugging.
          Hide
          Uwe Schindler added a comment -

          To understand what I mean, look at the screenshot here:
          https://code.google.com/p/lucene-gosen/

          All this information is returned by FieldAnalysisRequestHandler.

          Show
          Uwe Schindler added a comment - To understand what I mean, look at the screenshot here: https://code.google.com/p/lucene-gosen/ All this information is returned by FieldAnalysisRequestHandler.
          Hide
          Stefan Matheis (steffkes) added a comment -

          The current output is now useless for advanced debugging.

          Good to know .. so, i'll drop the current state, because it's not that flexible as needed - ty Uwe.

          To understand what I mean, look at the screenshot here: https://code.google.com/p/lucene-gosen/

          I'll have a detailed look (already found some japanse strings in the tests ..), and see how we could integrate this. it's a huge bunch of information, really much more then i've ever seen on any analysis-page ;o

          Show
          Stefan Matheis (steffkes) added a comment - The current output is now useless for advanced debugging. Good to know .. so, i'll drop the current state, because it's not that flexible as needed - ty Uwe. To understand what I mean, look at the screenshot here: https://code.google.com/p/lucene-gosen/ I'll have a detailed look (already found some japanse strings in the tests ..), and see how we could integrate this. it's a huge bunch of information, really much more then i've ever seen on any analysis-page ;o
          Hide
          Erick Erickson added a comment -

          Stefan:

          Is this up on your Git repo? Git really isn't that hard, I'll be glad to bring it down and see it in real life.....

          Erick

          Show
          Erick Erickson added a comment - Stefan: Is this up on your Git repo? Git really isn't that hard, I'll be glad to bring it down and see it in real life..... Erick
          Hide
          Ryan McKinley added a comment -
          Show
          Ryan McKinley added a comment - erick, check: https://github.com/steffkes/solr-admin
          Hide
          Stefan Matheis (steffkes) added a comment -

          . Is this up on your Git repo? Git really isn't that hard, I'll be glad to bring it down and see it in real life.....

          Yes Erick Normally i'm working on things .. commit & push them to my github repo and post a comment here afterwards. So you should find everything i'm talking about there

          Show
          Stefan Matheis (steffkes) added a comment - . Is this up on your Git repo? Git really isn't that hard, I'll be glad to bring it down and see it in real life..... Yes Erick Normally i'm working on things .. commit & push them to my github repo and post a comment here afterwards. So you should find everything i'm talking about there
          Hide
          Upayavira added a comment -

          I've just seen the admin console fail on IE9, with and without compatability mode. Basically, the menu box showed up, but nothing on the right hand box, and no "loading" message, when running on Solr 3.1. The same system worked nicely on Firefox Windows, Firefox Mac, etc.

          Show
          Upayavira added a comment - I've just seen the admin console fail on IE9, with and without compatability mode. Basically, the menu box showed up, but nothing on the right hand box, and no "loading" message, when running on Solr 3.1. The same system worked nicely on Firefox Windows, Firefox Mac, etc.
          Hide
          Stefan Matheis (steffkes) added a comment -

          So, made a bit progress on another Topic – the Dataimport Screen.

          The Ideas behind:

          • Make it clear, that the config could not be edited in this screen. So by default it's hidden, could be toggled and has Syntax-Highlighting (as seen in the screen)
          • Update the (Progress-)Status in Screen, while a Import is Running (actually, the interval is 2s)
          Show
          Stefan Matheis (steffkes) added a comment - So, made a bit progress on another Topic – the Dataimport Screen . The Ideas behind: Make it clear, that the config could not be edited in this screen. So by default it's hidden, could be toggled and has Syntax-Highlighting (as seen in the screen) Update the (Progress-)Status in Screen, while a Import is Running (actually, the interval is 2s)
          Hide
          Stefan Matheis (steffkes) added a comment -

          Upayavira, yes that's right .. i'm developing on Win7 with FF3. The Interface should work in Chrome, maybe also in Safari / Opera. Bugfixing – especially for IE – will come later

          Show
          Stefan Matheis (steffkes) added a comment - Upayavira, yes that's right .. i'm developing on Win7 with FF3. The Interface should work in Chrome, maybe also in Safari / Opera. Bugfixing – especially for IE – will come later
          Hide
          Stefan Matheis (steffkes) added a comment -

          Just because i had a quick Idea for it this morning – the Core-Admin Screen.

          "Add Core" will open an additional Layer within a Form where you could type all required informations. Actually the Functionality for the Buttons is missing, will be added tomorrow

          Show
          Stefan Matheis (steffkes) added a comment - Just because i had a quick Idea for it this morning – the Core-Admin Screen . "Add Core" will open an additional Layer within a Form where you could type all required informations. Actually the Functionality for the Buttons is missing, will be added tomorrow
          Hide
          Otis Gospodnetic added a comment -

          Thanks for doing all this, Stefan!

          I looked at the Analysis screenshot and found it a bit hard to "eyeball" quickly because the whole things feels very pale, which makes it hard for an eye to quickly jump from tokenizer, to token filter, to next token filter, etc. It's also not immediately obvious what left side vs. right side are, so maybe a more visible "Index-time Analysis" and "Query-time Analysis" may help.

          Show
          Otis Gospodnetic added a comment - Thanks for doing all this, Stefan! I looked at the Analysis screenshot and found it a bit hard to "eyeball" quickly because the whole things feels very pale, which makes it hard for an eye to quickly jump from tokenizer, to token filter, to next token filter, etc. It's also not immediately obvious what left side vs. right side are, so maybe a more visible "Index-time Analysis" and "Query-time Analysis" may help.
          Hide
          Ryan McKinley added a comment -

          Stefan – this stuff is looking great! Would you mind uploading a snapshot of your repo to this issue? I would like to start a branch in the apache repo, but we need to have the proper Apache release boxes ticked (part of the process when you upload a patch)

          Show
          Ryan McKinley added a comment - Stefan – this stuff is looking great! Would you mind uploading a snapshot of your repo to this issue? I would like to start a branch in the apache repo, but we need to have the proper Apache release boxes ticked (part of the process when you upload a patch)
          Hide
          Ryan McKinley added a comment -

          A few more comments....

          Rather then use: java-properties.jsp
          can the JS hit:
          http://localhost:8983/solr/admin/properties
          or
          http://localhost:8983/solr/admin/properties?wt=json

          I like the landing dashboard you have, but it would be nice to have an big (optional) link to:
          http://localhost:8983/solr/browse
          so that people starting with solr can see solr in action easily

          looking good!

          Show
          Ryan McKinley added a comment - A few more comments.... Rather then use: java-properties.jsp can the JS hit: http://localhost:8983/solr/admin/properties or http://localhost:8983/solr/admin/properties?wt=json I like the landing dashboard you have, but it would be nice to have an big (optional) link to: http://localhost:8983/solr/browse so that people starting with solr can see solr in action easily looking good!
          Hide
          Stefan Matheis (steffkes) added a comment -

          Thanks for doing all this, Stefan!

          I'm happy to contribute

          I looked at the Analysis screenshot and found it a bit hard to "eyeball" quickly because the whole things feels very pale, which makes it hard for an eye to quickly jump from tokenizer, to token filter, to next token filter, etc. It's also not immediately obvious what left side vs. right side are, so maybe a more visible "Index-time Analysis" and "Query-time Analysis" may help.

          Thanks for the Feedback, really appreciated. Tried to Focus on the Text .. maybe there is too much "gray" around, yes :/
          Maybe a vertical divider (from top to bottom) would help to realize the index vs. query thingy? more whitespace between both columns perhaps? What was the Text you've used for analysis? (Just to get a feeling, how your page looks like :>)

          Show
          Stefan Matheis (steffkes) added a comment - Thanks for doing all this, Stefan! I'm happy to contribute I looked at the Analysis screenshot and found it a bit hard to "eyeball" quickly because the whole things feels very pale, which makes it hard for an eye to quickly jump from tokenizer, to token filter, to next token filter, etc. It's also not immediately obvious what left side vs. right side are, so maybe a more visible "Index-time Analysis" and "Query-time Analysis" may help. Thanks for the Feedback, really appreciated. Tried to Focus on the Text .. maybe there is too much "gray" around, yes :/ Maybe a vertical divider (from top to bottom) would help to realize the index vs. query thingy? more whitespace between both columns perhaps? What was the Text you've used for analysis? (Just to get a feeling, how your page looks like :>)
          Hide
          Stefan Matheis (steffkes) added a comment -

          Rather then use: java-properties.jsp
          can the JS hit: http://localhost:8983/solr/admin/properties

          Ha, nice – already integrated, dropped out the .jsp. But noticed the the line.seperator is not 'encoded', already started an ticket for this: SOLR-2490

          I like the landing dashboard you have, but it would be nice to have an big (optional) link to:
          http://localhost:8983/solr/browse
          so that people starting with solr can see solr in action easily

          Hmm, would be useful too have another "admin-extra.html" File also for the global Dashboard, not only on Core-Level? We could point to the Velocity-Thingy but default, and everybody is able to extend this for his own needs.

          Show
          Stefan Matheis (steffkes) added a comment - Rather then use: java-properties.jsp can the JS hit: http://localhost:8983/solr/admin/properties Ha, nice – already integrated , dropped out the .jsp. But noticed the the line.seperator is not 'encoded', already started an ticket for this: SOLR-2490 I like the landing dashboard you have, but it would be nice to have an big (optional) link to: http://localhost:8983/solr/browse so that people starting with solr can see solr in action easily Hmm, would be useful too have another "admin-extra.html" File also for the global Dashboard, not only on Core-Level? We could point to the Velocity-Thingy but default, and everybody is able to extend this for his own needs.
          Hide
          Otis Gospodnetic added a comment -

          Stefan - I only looked at the screenshot you provided..... and now I can't find the link, I thought it was in this issue.

          Show
          Otis Gospodnetic added a comment - Stefan - I only looked at the screenshot you provided..... and now I can't find the link, I thought it was in this issue.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Stefan - I only looked at the screenshot you provided..... and now I can't find the link, I thought it was in this issue.

          Ah okay, thought you've already played around. Here is the screen again: http://files.mathe.is/solr-admin/04_analysis.png

          Show
          Stefan Matheis (steffkes) added a comment - Stefan - I only looked at the screenshot you provided..... and now I can't find the link, I thought it was in this issue. Ah okay, thought you've already played around. Here is the screen again: http://files.mathe.is/solr-admin/04_analysis.png
          Hide
          Otis Gospodnetic added a comment -

          Right, so if you look at the names of tokenizers and filters there, they are super light, almost like the background. I think making them stand out more would be better - darker font, bolder...

          Show
          Otis Gospodnetic added a comment - Right, so if you look at the names of tokenizers and filters there, they are super light, almost like the background. I think making them stand out more would be better - darker font, bolder...
          Hide
          Stefan Matheis (steffkes) added a comment -

          Right, so if you look at the names of tokenizers and filters there, they are super light, almost like the background. I think making them stand out more would be better - darker font, bolder...

          Correct - just used on another monitor .. depends heavily on the settings, brightness/contrast – will put that screen back on the todo-list and try a few things. will let you know if it's done :>

          Additional Thoughts Otis? Does not matter if they are related to existing Screens or other Features!

          Show
          Stefan Matheis (steffkes) added a comment - Right, so if you look at the names of tokenizers and filters there, they are super light, almost like the background. I think making them stand out more would be better - darker font, bolder... Correct - just used on another monitor .. depends heavily on the settings, brightness/contrast – will put that screen back on the todo-list and try a few things. will let you know if it's done :> Additional Thoughts Otis? Does not matter if they are related to existing Screens or other Features!
          Hide
          Stefan Matheis (steffkes) added a comment -

          Used this rainy Saturday to complete the Replication Page

          The possible Actions depend on Master/Slave-Configuration. The Iterations-List contains all Dates, per default only the latest ones [successful & failed] are displayed. Yellow Background (in the Index-Section) indicates a difference between the Slave- and the Master-Data.

          Short Screencast to see how the progress-bar will look while replicating (WIP-State two days ago): http://screencast.com/t/W1JcBaHO42C

          Show
          Stefan Matheis (steffkes) added a comment - Used this rainy Saturday to complete the Replication Page The possible Actions depend on Master/Slave-Configuration. The Iterations-List contains all Dates, per default only the latest ones [successful & failed] are displayed. Yellow Background (in the Index-Section) indicates a difference between the Slave- and the Master-Data. Short Screencast to see how the progress-bar will look while replicating (WIP-State two days ago): http://screencast.com/t/W1JcBaHO42C
          Hide
          Stefan Matheis (steffkes) added a comment -

          Short Installation Guidance, for those who are interested

          svn co https://svn.apache.org/repos/asf/lucene/dev/trunk/ apache-solr-trunk
          cd apache-solr-trunk/solr/src/webapp/web
          rm -rf admin index.jsp
          git clone git://github.com/steffkes/solr-admin.git
          mv solr-admin/* ./
          rm -rf solr-admin
          cd ../../../
          ant example

          If there is no git client on your system, use https://github.com/steffkes/solr-admin/tarball/master

          Show
          Stefan Matheis (steffkes) added a comment - Short Installation Guidance, for those who are interested svn co https: //svn.apache.org/repos/asf/lucene/dev/trunk/ apache-solr-trunk cd apache-solr-trunk/solr/src/webapp/web rm -rf admin index.jsp git clone git: //github.com/steffkes/solr-admin.git mv solr-admin/* ./ rm -rf solr-admin cd ../../../ ant example If there is no git client on your system, use https://github.com/steffkes/solr-admin/tarball/master
          Hide
          Mark Miller added a comment -

          bq Used this rainy Saturday to complete the Replication Page

          Looking good!

          Show
          Mark Miller added a comment - bq Used this rainy Saturday to complete the Replication Page Looking good!
          Hide
          Simon Willnauer added a comment -

          hey stefan,

          I need to tell you this is great stuff here. It seems like you are working on this for a while and you are making great progress. Yet, it seems like you are at the point where we should move forward and see how we can land this on lucene trunk. Can you quickly wrap up what is missing here so we can get it ready for commit?

          Show
          Simon Willnauer added a comment - hey stefan, I need to tell you this is great stuff here. It seems like you are working on this for a while and you are making great progress. Yet, it seems like you are at the point where we should move forward and see how we can land this on lucene trunk. Can you quickly wrap up what is missing here so we can get it ready for commit?
          Hide
          Robert Muir added a comment -

          I agree Simon. Just looking at the screenshots, the improvement is so significant here: let's figure out some way to get this in and go iteratively from here?

          If there are concerns about any particulars maybe as a workaround in the worst case we could temporarily keep a 'old admin UI' link or something, so that you can always do what you did before but with the new UI as a default?

          Show
          Robert Muir added a comment - I agree Simon. Just looking at the screenshots, the improvement is so significant here: let's figure out some way to get this in and go iteratively from here? If there are concerns about any particulars maybe as a workaround in the worst case we could temporarily keep a 'old admin UI' link or something, so that you can always do what you did before but with the new UI as a default?
          Hide
          Ryan McKinley added a comment -

          Stuff is looking great stefan.

          Right now the big issues I see are:

          • it works best in chrome. FF has some errors, and i have not even tried IE
          • logging page is mostly a stub

          I took your templates and added a header that points to this issue.

          I would like to commit soon (today) and iterate from there

          Show
          Ryan McKinley added a comment - Stuff is looking great stefan. Right now the big issues I see are: it works best in chrome. FF has some errors, and i have not even tried IE logging page is mostly a stub I took your templates and added a header that points to this issue. I would like to commit soon (today) and iterate from there
          Hide
          Ryan McKinley added a comment -

          to be clear, i think we should keep the old interface around until the kinks are worked out with this one.

          Show
          Ryan McKinley added a comment - to be clear, i think we should keep the old interface around until the kinks are worked out with this one.
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Thanks Ryan,

          it works best in chrome. FF has some errors, and i have not even tried IE

          Just wondering that something works in Chrome and not in FF?

          logging page is mostly a stub

          not only "mostly" :/ the data is completely static - the updating-part has to be done, planned for next week – SOLR-2459 is already created for this

          I took your templates and added a header that points to this issue.

          Ah okay, i've done a basic notice today in the morning, and updated this notice right know with your text. Just that people are getting this information instead of overlooking it (comparison screenshot) so perhaps we could use this one instead of the plain-text thingy? ;>

          I would like to commit soon (today) and iterate from there

          Yes, of course – fine

          to be clear, i think we should keep the old interface around until the kinks are worked out with this one.

          Yes, at least to ensure that typical "hey, to to analysis.jsp"-Links from various Tutorials are still working. Will have a look on that, when the features are done – maybe we could change the configuration of jetty, to redirect the users .. later

          Show
          Stefan Matheis (steffkes) added a comment - - edited Thanks Ryan, it works best in chrome. FF has some errors, and i have not even tried IE Just wondering that something works in Chrome and not in FF? logging page is mostly a stub not only "mostly" :/ the data is completely static - the updating-part has to be done, planned for next week – SOLR-2459 is already created for this I took your templates and added a header that points to this issue. Ah okay, i've done a basic notice today in the morning, and updated this notice right know with your text. Just that people are getting this information instead of overlooking it ( comparison screenshot ) so perhaps we could use this one instead of the plain-text thingy? ;> I would like to commit soon (today) and iterate from there Yes, of course – fine to be clear, i think we should keep the old interface around until the kinks are worked out with this one. Yes, at least to ensure that typical "hey, to to analysis.jsp"-Links from various Tutorials are still working. Will have a look on that, when the features are done – maybe we could change the configuration of jetty, to redirect the users .. later
          Hide
          Ryan McKinley added a comment -

          just added this stuff to trunk.

          Thanks stefan!

          Keep the patches coming, and I will get them in as fast as possible

          Show
          Ryan McKinley added a comment - just added this stuff to trunk. Thanks stefan! Keep the patches coming, and I will get them in as fast as possible
          Hide
          Stefan Matheis (steffkes) added a comment -

          Realized that my work-in-progress commits (and the related instrouctions to integrate them) were confusing. Attached patch will fix this

          Show
          Stefan Matheis (steffkes) added a comment - Realized that my work-in-progress commits (and the related instrouctions to integrate them) were confusing. Attached patch will fix this
          Hide
          Ryan McKinley added a comment -

          thanks stefan, i added that patch.

          re FF problems... when I look at:
          http://localhost:8983/solr/#/singlecore/analysis

          I see:
          uncaught exception: Syntax error, unrecognized expression: [value=fieldname=text]
          in firebug

          also, the spinner next to the field name drop down does not stop spinning.

          Also, the schema-browser is not showing up as expected (also in Chrome)

          Show
          Ryan McKinley added a comment - thanks stefan, i added that patch. re FF problems... when I look at: http://localhost:8983/solr/#/singlecore/analysis I see: uncaught exception: Syntax error, unrecognized expression: [value=fieldname=text] in firebug also, the spinner next to the field name drop down does not stop spinning. Also, the schema-browser is not showing up as expected (also in Chrome)
          Hide
          Stefan Matheis (steffkes) added a comment -

          uncaught exception: Syntax error, unrecognized expression: [value=fieldname=text]

          Yes, FF (seemed to be Version 4, works for 3.x) changed the behaviour of Javascript-Selectors. Already fixed the Handling for the Analysis-Page and the Schema-Browser-Page.

          also, the spinner next to the field name drop down does not stop spinning.

          same problem as above, javascript stopped working at the exception and does not remove the spinner-icon (read: also fixed)

          Also, the schema-browser is not showing up as expected (also in Chrome)

          Checked that, the Terms-Table is not displayed correctly, needs to much space, but the intro-page of the schema-browser comes up .. also selecting a field (either from the dropdown, or the information on the right hand side) works for me, not for you Ryan?

          Show
          Stefan Matheis (steffkes) added a comment - uncaught exception: Syntax error, unrecognized expression: [value=fieldname=text] Yes, FF (seemed to be Version 4, works for 3.x) changed the behaviour of Javascript-Selectors. Already fixed the Handling for the Analysis-Page and the Schema-Browser-Page . also, the spinner next to the field name drop down does not stop spinning. same problem as above, javascript stopped working at the exception and does not remove the spinner-icon (read: also fixed) Also, the schema-browser is not showing up as expected (also in Chrome) Checked that, the Terms-Table is not displayed correctly, needs to much space, but the intro-page of the schema-browser comes up .. also selecting a field (either from the dropdown, or the information on the right hand side) works for me, not for you Ryan?
          Hide
          Simon Willnauer added a comment -

          Ryan thanks for committing this. I think you should add a CHANGES.TXT entry to honor Stefans contribution, this is a huge change and a good one too. Once we close this make sure you add it.

          simon

          Show
          Simon Willnauer added a comment - Ryan thanks for committing this. I think you should add a CHANGES.TXT entry to honor Stefans contribution, this is a huge change and a good one too. Once we close this make sure you add it. simon
          Hide
          Ryan McKinley added a comment -

          I plan to add the CHANGES.TXT when the basic pluming is all in place and can resolve this issue. We can then add new JIRA issues to improve the various parts.

          HUGE thanks to Stefan – a nice looking admin UI makes solr feel like it was built this century.

          Show
          Ryan McKinley added a comment - I plan to add the CHANGES.TXT when the basic pluming is all in place and can resolve this issue. We can then add new JIRA issues to improve the various parts. HUGE thanks to Stefan – a nice looking admin UI makes solr feel like it was built this century.
          Hide
          Shawn Heisey added a comment -

          I've been concentrating on getting 3.1 into production, so I haven't tried this out, only seen the screenshot and read the discussion.

          Two questions: a) Is this suitable for inclusion in 3.2? b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome.

          Show
          Shawn Heisey added a comment - I've been concentrating on getting 3.1 into production, so I haven't tried this out, only seen the screenshot and read the discussion. Two questions: a) Is this suitable for inclusion in 3.2? b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome.
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Shawn,

          a) Is this suitable for inclusion in 3.2?

          Honestly, i don't know if all is working right now. The main parts should do, but it is possible that there are changes made from 3.x to 4.x. First i'd like to finish the Features for trunk, afterwards we'll see – but of course i'd happy if you'd give it a try. Just clone (or download the tarball) from https://github.com/steffkes/solr-admin

          b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome.

          Actually it's just rendered through the Browser's XML-Capabilities, so no chance to inline other files. But if you could attach your solr-config (including all related files), i'll have a look and see what's possible. Perhaps we could render the XML-Files with javascript on the client-side, like it's already done for the dataimport-config

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - - edited Shawn, a) Is this suitable for inclusion in 3.2? Honestly, i don't know if all is working right now. The main parts should do, but it is possible that there are changes made from 3.x to 4.x. First i'd like to finish the Features for trunk, afterwards we'll see – but of course i'd happy if you'd give it a try. Just clone (or download the tarball) from https://github.com/steffkes/solr-admin b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome. Actually it's just rendered through the Browser's XML-Capabilities, so no chance to inline other files. But if you could attach your solr-config (including all related files), i'll have a look and see what's possible. Perhaps we could render the XML-Files with javascript on the client-side, like it's already done for the dataimport-config Stefan
          Hide
          Stefan Matheis (steffkes) added a comment -

          Shawn,

          b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome.

          Thanks for your Config-Files. I'd say it's possible – but not while using an absolute path to reference the file you want to include. The ShowFileRequestHandler works only for files in SOLR's conf/-Directory and (additionally) requires an relative path for the file=-Parameter!

          I'll try to create an quick Prototyp, so that we can have a look next Week.

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - Shawn, b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome. Thanks for your Config-Files. I'd say it's possible – but not while using an absolute path to reference the file you want to include. The ShowFileRequestHandler works only for files in SOLR's conf/ -Directory and (additionally) requires an relative path for the file= -Parameter! I'll try to create an quick Prototyp, so that we can have a look next Week. Stefan
          Hide
          Stefan Matheis (steffkes) added a comment -

          Attached Patch (based on Rev 1131117/simonw) includes all changes which have been made since Rev 1127987/ryan.

          Show
          Stefan Matheis (steffkes) added a comment - Attached Patch (based on Rev 1131117/simonw) includes all changes which have been made since Rev 1127987/ryan.
          Hide
          Ryan McKinley added a comment -

          added that patch in revision: 1131137

          Stefan – can you make sure it came in OK?

          stuff is looking great!

          In a quick check in FF, the issues i noticed are:

          • On replication page when replication is not configured, it spins forever
          • schema browser has a funny character to the right of "Please Select"
          • sometimes the schema-browser page does not load when i click on it – perhaps because it has a '-' in the name?

          thanks Stefan!

          Show
          Ryan McKinley added a comment - added that patch in revision: 1131137 Stefan – can you make sure it came in OK? stuff is looking great! In a quick check in FF, the issues i noticed are: On replication page when replication is not configured, it spins forever schema browser has a funny character to the right of "Please Select" sometimes the schema-browser page does not load when i click on it – perhaps because it has a '-' in the name? thanks Stefan!
          Hide
          Ryan McKinley added a comment -

          Another small thing:

          • on the analysis page. When you select 'Verbose Output' can it keep that setting for a subsequent call?

          What do you think about trying full width layout rather then the fixed 800px?

          Show
          Ryan McKinley added a comment - Another small thing: on the analysis page. When you select 'Verbose Output' can it keep that setting for a subsequent call? What do you think about trying full width layout rather then the fixed 800px?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Stefan – can you make sure it came in OK?

          Yes, all fine. Just realized that the dashboard was broken through my refactoring yesterday - fixed that.

          On replication page when replication is not configured, it spins forever

          Correct, also fixed. Works now the same way as Dataimport does; shows a basic "not defined" error. Will see if we could disable those menu-items already at the beginning. actually the problem is, that this data is only fetched on the dashboard .. so if the user uses another page to enter the admin, it's missing :/

          schema browser has a funny character to the right of "Please Select"

          Good to know, it's a Ellipsis-Character there .. indicating that the Page is not UTF-8 ;o it's on the list

          sometimes the schema-browser page does not load when i click on it – perhaps because it has a '-' in the name?

          Normally the dash should not be a problem .. other pages have also one. perhaps it's not clear that the user have to select one entry from the shown dropdown? it's starting with this screen and after selecting 'id' from the dropdown it's like this screen - not for you ryan?

          Mentioned Bugs fixed with attached Patch (based on Rev 1131152/mikemccand)

          Show
          Stefan Matheis (steffkes) added a comment - Stefan – can you make sure it came in OK? Yes, all fine. Just realized that the dashboard was broken through my refactoring yesterday - fixed that. On replication page when replication is not configured, it spins forever Correct, also fixed. Works now the same way as Dataimport does; shows a basic "not defined" error. Will see if we could disable those menu-items already at the beginning. actually the problem is, that this data is only fetched on the dashboard .. so if the user uses another page to enter the admin, it's missing :/ schema browser has a funny character to the right of "Please Select" Good to know, it's a Ellipsis-Character there .. indicating that the Page is not UTF-8 ;o it's on the list sometimes the schema-browser page does not load when i click on it – perhaps because it has a '-' in the name? Normally the dash should not be a problem .. other pages have also one. perhaps it's not clear that the user have to select one entry from the shown dropdown? it's starting with this screen and after selecting 'id' from the dropdown it's like this screen - not for you ryan? Mentioned Bugs fixed with attached Patch (based on Rev 1131152/mikemccand)
          Hide
          Stefan Matheis (steffkes) added a comment -

          on the analysis page. When you select 'Verbose Output' can it keep that setting for a subsequent call?

          Good idea, added to the list. Otis's suggestions are already there, will try to integrate that on the next work-part for the analysis page.

          What do you think about trying full width layout rather then the fixed 800px?

          That was already mentioned this week on the IRC-Channel – will try to use relative units so that it will hopefully scale on your screen, perhaps we have to restrict the max-width for the really big screens.

          Show
          Stefan Matheis (steffkes) added a comment - on the analysis page. When you select 'Verbose Output' can it keep that setting for a subsequent call? Good idea, added to the list. Otis's suggestions are already there, will try to integrate that on the next work-part for the analysis page. What do you think about trying full width layout rather then the fixed 800px? That was already mentioned this week on the IRC-Channel – will try to use relative units so that it will hopefully scale on your screen, perhaps we have to restrict the max-width for the really big screens.
          Hide
          Ryan McKinley added a comment -

          just added your changes.

          About the schema-browser page not loading... I am not talking about the schema-browser tab not loading at all. The minimum steps to reproduce on my windows FF 4.0.1:

          1. load: http://localhost:8983/solr/#/singlecore/analysis
          2. click on 'Schema Browser' – it loads the page
          3. click on 'Analysis' – it loads the Analysis page
          4. click on 'Schema Browser' – the page says looking at the analysis page, but URL says schema-browser

          are you seeing the same thing?

          Show
          Ryan McKinley added a comment - just added your changes. About the schema-browser page not loading... I am not talking about the schema-browser tab not loading at all. The minimum steps to reproduce on my windows FF 4.0.1: load: http://localhost:8983/solr/#/singlecore/analysis click on 'Schema Browser' – it loads the page click on 'Analysis' – it loads the Analysis page click on 'Schema Browser' – the page says looking at the analysis page, but URL says schema-browser are you seeing the same thing?
          Hide
          Stefan Matheis (steffkes) added a comment -

          just added your changes.

          ty, works

          are you seeing the same thing?

          oh, indeed. ty for pointing this out. never worked on the schema-browser and changed the page :/ perhaps it's a quick fix, otherwise "it's on the list" =)

          Show
          Stefan Matheis (steffkes) added a comment - just added your changes. ty, works are you seeing the same thing? oh, indeed. ty for pointing this out. never worked on the schema-browser and changed the page :/ perhaps it's a quick fix, otherwise "it's on the list" =)
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Shawn,

          b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome.

          I'll try to create an quick Prototyp, so that we can have a look next Week.

          Here we go: http://files.mathe.is/solr-admin/xinclude/ (tested on Win/FF, should also work on Chrome) – it's really basic for the first step, no highlight, no loading-indicator or things like that. Wait for the solrconfig.xml File being loaded, and then hit the green T between Line-Number and the content; that will load the referenced file and display it below the selected row/line.

          Something a User (read: you ;>) could work with?

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - - edited Shawn, b) Can the XML display code be made smart enough to deal with xinclude? My solrconfig.xml file is mostly made up of xincludes. If there's no good way to expand them inline, just making it possible to click on them to see the included file would be awesome. I'll try to create an quick Prototyp, so that we can have a look next Week. Here we go: http://files.mathe.is/solr-admin/xinclude/ (tested on Win/FF, should also work on Chrome) – it's really basic for the first step, no highlight, no loading-indicator or things like that. Wait for the solrconfig.xml File being loaded, and then hit the green T between Line-Number and the content; that will load the referenced file and display it below the selected row/line. Something a User (read: you ;>) could work with? Stefan
          Hide
          Stefan Matheis (steffkes) added a comment -

          Attached Patch changes UI from fixed to fluid width. works not perfectly for every resolution, so please try it out. Have a look at Pages where the content has two Columns (Schema-Browser, Dataimport, Query-Form)

          Show
          Stefan Matheis (steffkes) added a comment - Attached Patch changes UI from fixed to fluid width. works not perfectly for every resolution, so please try it out. Have a look at Pages where the content has two Columns (Schema-Browser, Dataimport, Query-Form)
          Hide
          Ryan McKinley added a comment -

          added in in revision: 1132475

          This looks great!

          Do you think the footer might look better left justified?

          Show
          Ryan McKinley added a comment - added in in revision: 1132475 This looks great! Do you think the footer might look better left justified?
          Hide
          Ryan McKinley added a comment -

          also, it might be nice to put in a min-width – so that when you make the window small, it forces a scrollbar.

          On the maximum size, i think things look good

          Show
          Ryan McKinley added a comment - also, it might be nice to put in a min-width – so that when you make the window small, it forces a scrollbar. On the maximum size, i think things look good
          Hide
          Erick Erickson added a comment -

          The Chrome issues will go away if you install the XMLTree extension here: https://chrome.google.com/webstore/search?q=xmltree

          NOTE: XML Viewer doesn't help with this problem. I only really ran into this because I have a freshly-formatted machine, I suspect lots of chrome users have already installed this or something similar.

          Show
          Erick Erickson added a comment - The Chrome issues will go away if you install the XMLTree extension here: https://chrome.google.com/webstore/search?q=xmltree NOTE: XML Viewer doesn't help with this problem. I only really ran into this because I have a freshly-formatted machine, I suspect lots of chrome users have already installed this or something similar.
          Hide
          Erick Erickson added a comment -

          This one is odd, adding stopwords seems to break analysis...

          I put this in both the index and query time boxes on the "analyze" page:

          This is a test of the early warning system

          I added these to the stopwords.txt file
          an
          the
          this
          a
          is

          and tried to analyze the field "text". Nothing shows up. If I remove the stopwords from stopwords.txt it works fine.

          No errors appear in the log file. The old admin gives results though...

          BTW, this whole effort is a long-needed makeover, I'm glad you've taken it on. Can I do something other than complain?

          Oh, for the drop-down for choosing fields or types, would it be possible to order them alphabetically like the schema browser?

          Erick

          Show
          Erick Erickson added a comment - This one is odd, adding stopwords seems to break analysis... I put this in both the index and query time boxes on the "analyze" page: This is a test of the early warning system I added these to the stopwords.txt file an the this a is and tried to analyze the field "text". Nothing shows up. If I remove the stopwords from stopwords.txt it works fine. No errors appear in the log file. The old admin gives results though... BTW, this whole effort is a long-needed makeover, I'm glad you've taken it on. Can I do something other than complain? Oh, for the drop-down for choosing fields or types, would it be possible to order them alphabetically like the schema browser? Erick
          Hide
          Joan Codina added a comment -

          I did some changes to the current version of the Schema-Browser, some time ago.. you can find it in this issue #SOLR-2440.
          It has some features that I found interesting:
          A: Drill down, so you can select a word in the list of most common words and perform a query.
          B. Select the list of fields to be the output of the query.

          apart from sorting and showing the field names in alphabetical order and not capitalised.

          Show
          Joan Codina added a comment - I did some changes to the current version of the Schema-Browser, some time ago.. you can find it in this issue # SOLR-2440 . It has some features that I found interesting: A: Drill down, so you can select a word in the list of most common words and perform a query. B. Select the list of fields to be the output of the query. apart from sorting and showing the field names in alphabetical order and not capitalised.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Erick,

          This one is odd, adding stopwords seems to break analysis...

          Hm, did not handle removed tokens correctly. Patch attached

          Oh, for the drop-down for choosing fields or types, would it be possible to order them alphabetically like the schema browser?

          Yes, Patch attached too.

          BTW, this whole effort is a long-needed makeover, I'm glad you've taken it on. Can I do something other than complain?

          Thanks For me, it's just fine .. continue using the interface, as you normally would use it. We need just more feedback, other usecases, other schema-/field-definitions, ... – to see where things are not working as expected!

          Show
          Stefan Matheis (steffkes) added a comment - Erick, This one is odd, adding stopwords seems to break analysis... Hm, did not handle removed tokens correctly. Patch attached Oh, for the drop-down for choosing fields or types, would it be possible to order them alphabetically like the schema browser? Yes, Patch attached too. BTW, this whole effort is a long-needed makeover, I'm glad you've taken it on. Can I do something other than complain? Thanks For me, it's just fine .. continue using the interface, as you normally would use it. We need just more feedback, other usecases, other schema-/field-definitions, ... – to see where things are not working as expected!
          Hide
          Stefan Matheis (steffkes) added a comment -

          Joan,

          A: Drill down, so you can select a word in the list of most common words and perform a query.

          Added to the list, will extend the Query-Form so that's possible to predefine Field-Values

          B. Select the list of fields to be the output of the query.

          Regarding your patch, that's directly related, right? Selected Field will be used for the query and is the only listed field for the fl= param. Never though about that, thanks - will add this also.

          apart from sorting and showing the field names in alphabetical order and not capitalised.

          thats the current state, the values are just taken from the /admin/luke-Handler

          Show
          Stefan Matheis (steffkes) added a comment - Joan, A: Drill down, so you can select a word in the list of most common words and perform a query. Added to the list, will extend the Query-Form so that's possible to predefine Field-Values B. Select the list of fields to be the output of the query. Regarding your patch, that's directly related, right? Selected Field will be used for the query and is the only listed field for the fl= param. Never though about that, thanks - will add this also. apart from sorting and showing the field names in alphabetical order and not capitalised. thats the current state, the values are just taken from the /admin/luke-Handler
          Hide
          Ryan McKinley added a comment -

          check revision: 1132724

          Show
          Ryan McKinley added a comment - check revision: 1132724
          Hide
          Stefan Matheis (steffkes) added a comment -

          check revision: 1132724

          Yes, works.


          Attached Patch fixes a few smaller Things:

          • Ryan: schema browser has a funny character to the right of "Please Select"

          • Ryan: sometimes the schema-browser page does not load when i click on it – perhaps because it has a '-' in the name?

          • Also on the Schema/Config Page, i've replaced the iframe – which just shows the raw xml files – through the javascript highlighter (already used for dataimport-config), so will now work also in chrome (w/o extensions). still missing the xinclude-feature – feedback anyone?
          • New Style for 'Ping' in Navigation, if the /admin/ping handler is not available - like in example + multicore-mode.
          • Core-Admin is now also fluid-width aware
          Show
          Stefan Matheis (steffkes) added a comment - check revision: 1132724 Yes, works. Attached Patch fixes a few smaller Things: Ryan: schema browser has a funny character to the right of "Please Select" Ryan: sometimes the schema-browser page does not load when i click on it – perhaps because it has a '-' in the name? Also on the Schema/Config Page, i've replaced the iframe – which just shows the raw xml files – through the javascript highlighter (already used for dataimport-config), so will now work also in chrome (w/o extensions). still missing the xinclude-feature – feedback anyone? New Style for 'Ping' in Navigation, if the /admin/ping handler is not available - like in example + multicore-mode. Core-Admin is now also fluid-width aware
          Hide
          Ryan McKinley added a comment -

          trying to apply this patch, i get:
          "the chunk size did not match the number of added /removed lines!"

          any ideas? Did you make this patch differently then before?

          Show
          Ryan McKinley added a comment - trying to apply this patch, i get: "the chunk size did not match the number of added /removed lines!" any ideas? Did you make this patch differently then before?
          Hide
          Stefan Matheis (steffkes) added a comment -

          any ideas? Did you make this patch differently then before?

          hm, not really :/ same commands as the patches before. applying it locally, works as expected:

          $ patch -p0 < SOLR-2399-110606.patch
          patching file solr/src/webapp/web/tpl/schema-browser.html
          patching file solr/src/webapp/web/tpl/dataimport.html
          patching file solr/src/webapp/web/tpl/cores.html
          patching file solr/src/webapp/web/css/screen.css
          patching file solr/src/webapp/web/css/syntax.css
          patching file solr/src/webapp/web/js/script.js

          will have a look on this tomorrow, sorry ryan

          Show
          Stefan Matheis (steffkes) added a comment - any ideas? Did you make this patch differently then before? hm, not really :/ same commands as the patches before. applying it locally, works as expected: $ patch -p0 < SOLR-2399-110606.patch patching file solr/src/webapp/web/tpl/schema-browser.html patching file solr/src/webapp/web/tpl/dataimport.html patching file solr/src/webapp/web/tpl/cores.html patching file solr/src/webapp/web/css/screen.css patching file solr/src/webapp/web/css/syntax.css patching file solr/src/webapp/web/js/script.js will have a look on this tomorrow, sorry ryan
          Hide
          Ryan McKinley added a comment -

          Ok, i tried on linux and it applied OK. TortiseSVN sometimes barfs when it shouldnt.

          committed in revision: 1132826

          Show
          Ryan McKinley added a comment - Ok, i tried on linux and it applied OK. TortiseSVN sometimes barfs when it shouldnt. committed in revision: 1132826
          Hide
          Ryan McKinley added a comment -

          few minor comments...

          • Navigation to Schema Browser works great – thanks

          again, this is great stuff. thanks!

          Show
          Ryan McKinley added a comment - few minor comments... on http://localhost:8983/solr/#/singlecore/schema-browser/field/text in the "Top 10/405 Terms:" with the more/less links. I'm not sure adding 10 at a time is really useful. I would rather click 'more' and get all 50, and have 'less' just go back to 10. Navigation to Schema Browser works great – thanks again, this is great stuff. thanks!
          Hide
          Shawn Heisey added a comment -

          The xinclude stuff looks pretty cool! A suggestion on it: shade the background of the entire expanded section, so it stands out better. Thanks for including this!

          Show
          Shawn Heisey added a comment - The xinclude stuff looks pretty cool! A suggestion on it: shade the background of the entire expanded section, so it stands out better. Thanks for including this!
          Hide
          Uwe Schindler added a comment -

          SOLR-2400 is now solved, we can now upgrade the analysis functionality. I only want to strongly suggest:

          • show all attributes listed in the JSON/XML file, also rawBytes, KeywordAttribute,... Simply iterate over all JSON nodes and print them out
          • don't use 1-letter title ("T") for the first column, simply show here the attribute name (with everything before # removed). As hover text use the full attribute name including # and class name (if available).
          • a special case should maybe only be done for start and endOffset, they could be combined in one line.

          I wanted to hack this, but my JavaScript knowledge is limited. I have one security issue found (XSS), see below.

          I had to debug some TokenStreams today and had to switch to the old analysis.jsp to do it, the new interface is not very helpful for complex attributes like japanese ones.

          Show
          Uwe Schindler added a comment - SOLR-2400 is now solved, we can now upgrade the analysis functionality. I only want to strongly suggest: show all attributes listed in the JSON/XML file, also rawBytes, KeywordAttribute,... Simply iterate over all JSON nodes and print them out don't use 1-letter title ("T") for the first column, simply show here the attribute name (with everything before # removed). As hover text use the full attribute name including # and class name (if available). a special case should maybe only be done for start and endOffset, they could be combined in one line. I wanted to hack this, but my JavaScript knowledge is limited. I have one security issue found (XSS), see below. I had to debug some TokenStreams today and had to switch to the old analysis.jsp to do it, the new interface is not very helpful for complex attributes like japanese ones.
          Hide
          Uwe Schindler added a comment -

          The GUI contains some security relevant problems (may be used for XSS):

          It never escapes any text from solr when building HTML using strings, e.g. "<td>" + somethingEntered + "</td>"
          You should use the HTML escaping method possibly provided by jQuery or insert the object manually into dom, instead of formatting then HTML source code.

          Show
          Uwe Schindler added a comment - The GUI contains some security relevant problems (may be used for XSS): It never escapes any text from solr when building HTML using strings, e.g. "<td>" + somethingEntered + "</td>" You should use the HTML escaping method possibly provided by jQuery or insert the object manually into dom, instead of formatting then HTML source code.
          Hide
          noah added a comment -

          The admin interface doesn't load in Safari 5 due to the use of variables and properties named 'class'.
          Simple patch available here: https://gist.github.com/1030496

          Show
          noah added a comment - The admin interface doesn't load in Safari 5 due to the use of variables and properties named 'class'. Simple patch available here: https://gist.github.com/1030496
          Hide
          Erick Erickson added a comment -

          Stefan:

          Minor nit. If you refresh the stats page, everything shows up collapsed. Is it possible to show the same view as it was when the refresh was hit? The use-case here is that I wanted to watch how many documents were in the index as a job was running, so I wanted the "search" node expanded just as it was when I hit refresh...

          Really minor nit, though.

          Show
          Erick Erickson added a comment - Stefan: Minor nit. If you refresh the stats page, everything shows up collapsed. Is it possible to show the same view as it was when the refresh was hit? The use-case here is that I wanted to watch how many documents were in the index as a job was running, so I wanted the "search" node expanded just as it was when I hit refresh... Really minor nit, though.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Shawn:
          Of course, it's just a quick prototype to demonstrate the functionality. The Layout will change if it's integrated

          Uwe:
          Thanks for the Changes! Yes, the Analysis-Page has a few things that needs to be changed - mainly regarding layout/arrangement, but also functionality. Will see if i can finish working on that next Week.

          noah:
          Thanks, it's integrated .. id as property works w/o problems? The Layout on Safari looks good, compared to the provided Screenshots?

          Erick:
          that was a quick change :> every entry has now it's own url .. so after reloading the page, the view will be the same as before.

          Show
          Stefan Matheis (steffkes) added a comment - Shawn: Of course, it's just a quick prototype to demonstrate the functionality. The Layout will change if it's integrated Uwe: Thanks for the Changes! Yes, the Analysis-Page has a few things that needs to be changed - mainly regarding layout/arrangement, but also functionality. Will see if i can finish working on that next Week. noah: Thanks, it's integrated .. id as property works w/o problems? The Layout on Safari looks good, compared to the provided Screenshots? Erick: that was a quick change :> every entry has now it's own url .. so after reloading the page, the view will be the same as before.
          Hide
          Young Kim added a comment -

          Out of curiosity, does is this compatible with 3.2.0 or just 4.0? I've followed the instructions (with 3.2.0 of course), and I keep on hitting a build failed.

          Show
          Young Kim added a comment - Out of curiosity, does is this compatible with 3.2.0 or just 4.0? I've followed the instructions (with 3.2.0 of course), and I keep on hitting a build failed.
          Hide
          Ryan McKinley added a comment -

          right now this only works with 4.0

          Once all the kinks are worked out – and the things it depends on are ported to 3.x, this will likely also get ported to 3.x

          Show
          Ryan McKinley added a comment - right now this only works with 4.0 Once all the kinks are worked out – and the things it depends on are ported to 3.x, this will likely also get ported to 3.x
          Hide
          Ryan McKinley added a comment -

          On the 'java-properties' page, is the UI assuming ':' is the path seperator? On windows (where the path seperator is ';') the display looks like:

              C
              \java\jdk1.6.0_25\jre\lib\resources.jar;C
              \java\jdk1.6.0_25\jre\lib\rt.jar;C
              \java\jdk1.6.0_25\jre\lib\sunrsasign.jar;C
              \java\jdk1.6.0_25\jre\lib\jsse.jar;C
              \java\jdk1.6.0_25\jre\lib\jce.jar;C
              \java\jdk1.6.0_25\jre\lib\charsets.jar;C
              \java\jdk1.6.0_25\jre\lib\modules\jdk.boot.jar;C
              \java\jdk1.6.0_25\jre\classes
          

          Can this use the value of path.seperator to split?

          Show
          Ryan McKinley added a comment - On the 'java-properties' page, is the UI assuming ':' is the path seperator? On windows (where the path seperator is ';') the display looks like: C \java\jdk1.6.0_25\jre\lib\resources.jar;C \java\jdk1.6.0_25\jre\lib\rt.jar;C \java\jdk1.6.0_25\jre\lib\sunrsasign.jar;C \java\jdk1.6.0_25\jre\lib\jsse.jar;C \java\jdk1.6.0_25\jre\lib\jce.jar;C \java\jdk1.6.0_25\jre\lib\charsets.jar;C \java\jdk1.6.0_25\jre\lib\modules\jdk.boot.jar;C \java\jdk1.6.0_25\jre\classes Can this use the value of path.seperator to split?
          Hide
          Ryan McKinley added a comment -

          Should the Ping query append a random number so that it avoids HTTP cache?

          Show
          Ryan McKinley added a comment - Should the Ping query append a random number so that it avoids HTTP cache?
          Hide
          Ryan McKinley added a comment -

          Something for the wishlist... on the threads page, it would be great to have a button to expand (and collapse?) all the stack traces. Its hard to figure out which thread is doing what just from the title.

          Show
          Ryan McKinley added a comment - Something for the wishlist... on the threads page, it would be great to have a button to expand (and collapse?) all the stack traces. Its hard to figure out which thread is doing what just from the title.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Okay, there we go :>

          On the 'java-properties' page, is the UI assuming ':' is the path seperator?
          Can this use the value of path.seperator to split?

          Yes & Yes - Done [commit]

          Should the Ping query append a random number so that it avoids HTTP cache?

          Good Idea! - Done [commit]

          Something for the wishlist... on the threads page, it would be great to have a button to expand (and collapse?) all the stack traces. Its hard to figure out which thread is doing what just from the title.

          I've added an Button at the Top and the Bottom of the Table to show/hide all of them w/ one click [commit]


          Attached Patch contains all git-changes since our last SVN-Commit. Could you also include those images Ryan? They will not go into the SVN-Diff because of their binary type :/

          Thanks!

          Show
          Stefan Matheis (steffkes) added a comment - Okay, there we go :> On the 'java-properties' page, is the UI assuming ':' is the path seperator? Can this use the value of path.seperator to split? Yes & Yes - Done [ commit ] Should the Ping query append a random number so that it avoids HTTP cache? Good Idea! - Done [ commit ] Something for the wishlist... on the threads page, it would be great to have a button to expand (and collapse?) all the stack traces. Its hard to figure out which thread is doing what just from the title. I've added an Button at the Top and the Bottom of the Table to show/hide all of them w/ one click [ commit ] Attached Patch contains all git-changes since our last SVN-Commit. Could you also include those images Ryan? They will not go into the SVN-Diff because of their binary type :/ https://github.com/steffkes/solr-admin/raw/master/img/ico/toolbox.png https://github.com/steffkes/solr-admin/raw/master/img/ico/zone.png https://github.com/steffkes/solr-admin/raw/master/img/ico/system-monitor--exclamation.png Thanks!
          Hide
          Ryan McKinley added a comment -

          Thanks Stefan. Added in #1138323

          Show
          Ryan McKinley added a comment - Thanks Stefan. Added in #1138323
          Hide
          Ryan McKinley added a comment -

          in #1138328, I added a min-width value – this should keep things from looking rediculous when it gets really small

          Show
          Ryan McKinley added a comment - in #1138328, I added a min-width value – this should keep things from looking rediculous when it gets really small
          Hide
          Stefan Matheis (steffkes) added a comment -

          Young,

          ..., and I keep on hitting a build failed.

          Why did your build fail? Like Ryan already said, the UI is for trunk .. but the code should still build even on 3.x branches?

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - Young, ..., and I keep on hitting a build failed. Why did your build fail? Like Ryan already said, the UI is for trunk .. but the code should still build even on 3.x branches? Stefan
          Hide
          Stefan Matheis (steffkes) added a comment -

          So, after a few hours hacking .. it's hopefully a step into the right direction for the Analysis-Page! :>

          Please, have a look and let me know, what you're thinking. I've changed various things:

          • Vertical Separation should be more clear now (Index- vs. Query-Time)
          • Filter- & Tokenizer-Names are placed on the left Side (so it should be easier to follow each token through all the steps, Full Name on MouseOver)
          • Property-Names are not longer abbreviated
          • All Properties (except match and positionHistory) are displayed
          • If the Property-Name contains a #-Sign, only the latter part is displayed (Full Name on MouseOver)

          Uwe, maybe you could give it a try w/ lucene-gosen? These are the required changes (since the last svn-commit).

            Version 1980 First Try Current Page
          Normal Screenshot Screenshot Screenshot
          Verbose Screenshot Screenshot Screenshot

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - So, after a few hours hacking .. it's hopefully a step into the right direction for the Analysis-Page! :> Please, have a look and let me know, what you're thinking. I've changed various things: Vertical Separation should be more clear now (Index- vs. Query-Time) Filter- & Tokenizer-Names are placed on the left Side (so it should be easier to follow each token through all the steps, Full Name on MouseOver) Property-Names are not longer abbreviated All Properties (except match and positionHistory ) are displayed If the Property-Name contains a #-Sign, only the latter part is displayed (Full Name on MouseOver) Uwe, maybe you could give it a try w/ lucene-gosen? These are the required changes (since the last svn-commit).   Version 1980 First Try Current Page Normal Screenshot Screenshot Screenshot Verbose Screenshot Screenshot Screenshot Stefan
          Hide
          Stefan Matheis (steffkes) added a comment -

          First Feedback from #solr:

          <hossman_> in the new ones, it's easy to overlook that "sonic" and "viewsonic" are at the same position
          <hossman_> steffkes: i think what i would suggest is to keep your new layout, treat position as special and put some sort of visual indicator on terms that are at the same position

          <hossman_> oh yeah ... i ment to ask about that ... i'm assuming you look at the capital letters in the class name?
          <hossman_> i think it's an assume way to save space, definitely a good idea for verbose==false (as long as you can mouse over it or something to see the full name)
          <hossman_> for verbose==true ... not sure

          regarding the two-column-layout / Index- vs. Query-Time:
          <elyograg> I see now. I think they might need headers to indicate which is which. Not strictly required if your screen is wide enough, but if it wraps below, it may not be immediately apparent.

          Show
          Stefan Matheis (steffkes) added a comment - First Feedback from #solr: <hossman_> in the new ones, it's easy to overlook that "sonic" and "viewsonic" are at the same position <hossman_> steffkes: i think what i would suggest is to keep your new layout, treat position as special and put some sort of visual indicator on terms that are at the same position <hossman_> oh yeah ... i ment to ask about that ... i'm assuming you look at the capital letters in the class name? <hossman_> i think it's an assume way to save space, definitely a good idea for verbose==false (as long as you can mouse over it or something to see the full name) <hossman_> for verbose==true ... not sure regarding the two-column-layout / Index- vs. Query-Time : <elyograg> I see now. I think they might need headers to indicate which is which. Not strictly required if your screen is wide enough, but if it wraps below, it may not be immediately apparent.
          Hide
          Robert Muir added a comment -

          Uwe, maybe you could give it a try w/ lucene-gosen? These are the required changes (since the last svn-commit).

          If Uwe doesn't have the time, I'll try to investigate this in the next few days, once I stop laughing about "Version 1980".

          we have a version that works with trunk here, https://lucene-gosen.googlecode.com/svn/branches/4x

          Show
          Robert Muir added a comment - Uwe, maybe you could give it a try w/ lucene-gosen? These are the required changes (since the last svn-commit). If Uwe doesn't have the time, I'll try to investigate this in the next few days, once I stop laughing about "Version 1980". we have a version that works with trunk here, https://lucene-gosen.googlecode.com/svn/branches/4x
          Hide
          Stefan Matheis (steffkes) added a comment -

          we have a version that works with trunk here, https://lucene-gosen.googlecode.com/svn/branches/4x

          great .. that was easy to install – even for me

          The Results for gosen .. just took text from the TestToStringUtil-Class:

            Version 1980 First Try Current Page
          Normal (ja) Screenshot Screenshot Screenshot
          Verbose (ja) Screenshot Screenshot Screenshot
          Show
          Stefan Matheis (steffkes) added a comment - we have a version that works with trunk here, https://lucene-gosen.googlecode.com/svn/branches/4x great .. that was easy to install – even for me The Results for gosen .. just took text from the TestToStringUtil -Class:   Version 1980 First Try Current Page Normal (ja) Screenshot Screenshot Screenshot Verbose (ja) Screenshot Screenshot Screenshot
          Hide
          Uwe Schindler added a comment -

          Traumhaft! Danke! (Very nice! Thanks!)

          Can you provide the patch and upload it here (for current trunk), please also give the svn rev against what version it is?

          Show
          Uwe Schindler added a comment - Traumhaft! Danke! (Very nice! Thanks!) Can you provide the patch and upload it here (for current trunk), please also give the svn rev against what version it is?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Patch attached, based on SVN-Rev 1142186
          Includes few XSS-Fixes and the new Analysis-Page

          Show
          Stefan Matheis (steffkes) added a comment - Patch attached, based on SVN-Rev 1142186 Includes few XSS-Fixes and the new Analysis-Page
          Hide
          Ryan McKinley added a comment -

          I'm away from a computer till the 4th... Uwe, go ahead and commit Stefan's patch if you like...

          screenshots look great. As always, thanks Stefan!

          Show
          Ryan McKinley added a comment - I'm away from a computer till the 4th... Uwe, go ahead and commit Stefan's patch if you like... screenshots look great. As always, thanks Stefan!
          Hide
          Uwe Schindler added a comment -

          OK, will do once I have reviewed it locally. I have some small issues, but they are minor.

          Show
          Uwe Schindler added a comment - OK, will do once I have reviewed it locally. I have some small issues, but they are minor.
          Hide
          Mark Miller added a comment -

          Hey Stefan,

          With the old UI, we repackage Solr a bit so that instead of running under the Solr context, it runs under the root context, but the Solr dispatch filter picks up anything sent to /solr. With the old UI, this worked fine - in general all links are still relative to Solr (there are one or two broken links that I'd like to fix).

          With this however, all links end up being eg root/admin rather than say root/solr/admin.

          I've started poking around a bit, but I'm not quite sure where data-basepath is being picked up.

          Is there an easy change that can be made that allows the links (ajax calls and others) to resolve similarly to how they do with the older admin UI?

          Show
          Mark Miller added a comment - Hey Stefan, With the old UI, we repackage Solr a bit so that instead of running under the Solr context, it runs under the root context, but the Solr dispatch filter picks up anything sent to /solr. With the old UI, this worked fine - in general all links are still relative to Solr (there are one or two broken links that I'd like to fix). With this however, all links end up being eg root/admin rather than say root/solr/admin. I've started poking around a bit, but I'm not quite sure where data-basepath is being picked up. Is there an easy change that can be made that allows the links (ajax calls and others) to resolve similarly to how they do with the older admin UI?
          Hide
          Ryan McKinley added a comment -

          Hey Mark-

          I also repackaged it... the only thing you really need to change is in index.jsp

              app_config.solr_path = 'your path here'; //<%= request.getContextPath() %>';
              app_config.core_admin_path = 'and here'; //<%= cores.getAdminPath() %>';
              app_config.zookeeper_path = 'zookeeper.jsp';
          
          Show
          Ryan McKinley added a comment - Hey Mark- I also repackaged it... the only thing you really need to change is in index.jsp app_config.solr_path = 'your path here'; //<%= request.getContextPath() %>'; app_config.core_admin_path = 'and here'; //<%= cores.getAdminPath() %>'; app_config.zookeeper_path = 'zookeeper.jsp';
          Hide
          Mark Miller added a comment -

          Nice, thanks Ryan.

          Show
          Mark Miller added a comment - Nice, thanks Ryan.
          Hide
          Mark Miller added a comment -

          So the other problem I get, which is odd, because it doesn't seem to be a problem with solr trunk for me, but it complains about the javascript variable class in script.js (L969) when i repackage.

          If I change that to clazz, all complaints go away and then I can modify app_config.solr_path and things seem to go well from there. This is a reserved word in javascript, so I'm not super surprised it's causing me grief (in firefox and chrome), but what does surprise me is that when i load the admin page in straight solr trunk, it causes me no grief.

          Show
          Mark Miller added a comment - So the other problem I get, which is odd, because it doesn't seem to be a problem with solr trunk for me, but it complains about the javascript variable class in script.js (L969) when i repackage. If I change that to clazz, all complaints go away and then I can modify app_config.solr_path and things seem to go well from there. This is a reserved word in javascript, so I'm not super surprised it's causing me grief (in firefox and chrome), but what does surprise me is that when i load the admin page in straight solr trunk, it causes me no grief.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Mark,

          changing the Pathes should be really easy, like Ryan said. So, should we use something other then request.getContextPath()? Maybe combined with a Conditional?

          but it complains about the javascript variable class in script.js (L969) when i repackage.

          that's already changed :> Or did you use another Version?

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - Mark, changing the Pathes should be really easy, like Ryan said. So, should we use something other then request.getContextPath() ? Maybe combined with a Conditional? but it complains about the javascript variable class in script.js (L969) when i repackage. that's already changed :> Or did you use another Version? Stefan
          Hide
          Erik Hatcher added a comment -

          Perhaps we should close this issue and open new ones since this one is getting incredibly long in comments and it's already been committed.

          But... one issue I have is that the schema/config views don't take advantage of my browsers ability to render XML as a collapsible/expandable tree structure. It's surely nice as it is now for browsers that don't do XML like this... so maybe we leave it like it is but also provide a direct link to the show file request handler for those files like the old-school admin links do. Thoughts?

          Show
          Erik Hatcher added a comment - Perhaps we should close this issue and open new ones since this one is getting incredibly long in comments and it's already been committed. But... one issue I have is that the schema/config views don't take advantage of my browsers ability to render XML as a collapsible/expandable tree structure. It's surely nice as it is now for browsers that don't do XML like this... so maybe we leave it like it is but also provide a direct link to the show file request handler for those files like the old-school admin links do. Thoughts?
          Hide
          Stefan Matheis (steffkes) added a comment -

          ... so maybe we leave it like it is but also provide a direct link to the show file request handler for those files like the old-school admin links do. Thoughts?

          Either this, yes – or we add tabs to the relevant views. The current one as first and an additional one with "raw view"?

          Show
          Stefan Matheis (steffkes) added a comment - ... so maybe we leave it like it is but also provide a direct link to the show file request handler for those files like the old-school admin links do. Thoughts? Either this, yes – or we add tabs to the relevant views. The current one as first and an additional one with "raw view"?
          Hide
          Mark Miller added a comment -

          So, should we use something other then request.getContextPath()? Maybe combined with a Conditional?

          Not sure yet - if there is something easy we can figure out, sounds great - otherwise I'm pretty happy that it's as easy to configure as it is already anyway.

          that's already changed :> Or did you use another Version?

          Ah, cool - I have a slightly older version of trunk.

          Show
          Mark Miller added a comment - So, should we use something other then request.getContextPath()? Maybe combined with a Conditional? Not sure yet - if there is something easy we can figure out, sounds great - otherwise I'm pretty happy that it's as easy to configure as it is already anyway. that's already changed :> Or did you use another Version? Ah, cool - I have a slightly older version of trunk.
          Hide
          Hoss Man added a comment -

          I also repackaged it... the only thing you really need to change is in index.jsp

          Hmmm... is that really necessary?

          SolrDispatchFilter already has the notion of a "path-prefix" setting that can be specified in the web.xml and defaults to null. it uses that wen proxying to build up the correct urls for things like the per core admin pages and what not anytime it proxies a request to the JSPs.

          couldn't we just make SolrDispatchFilter add the pathPrefix to the HttpServletRequest as an attribute, and then no one would ever need to modify the index.jsp ... it could just derive all the paths from request.getContextPath() and request.getAttribute("solr-path-prefix").

          right?

          Show
          Hoss Man added a comment - I also repackaged it... the only thing you really need to change is in index.jsp Hmmm... is that really necessary? SolrDispatchFilter already has the notion of a "path-prefix" setting that can be specified in the web.xml and defaults to null. it uses that wen proxying to build up the correct urls for things like the per core admin pages and what not anytime it proxies a request to the JSPs. couldn't we just make SolrDispatchFilter add the pathPrefix to the HttpServletRequest as an attribute, and then no one would ever need to modify the index.jsp ... it could just derive all the paths from request.getContextPath() and request.getAttribute("solr-path-prefix"). right?
          Hide
          Uwe Schindler added a comment -

          One additional question on the new analysis page:

          • Does your code also support CharFilters? I just ask because I had no time to try it out, it just came into my mind when i worked on FieldAnalysisReqHandler. The problem is that CharFilters return a different set of attributes and only one token.
          Show
          Uwe Schindler added a comment - One additional question on the new analysis page: Does your code also support CharFilters? I just ask because I had no time to try it out, it just came into my mind when i worked on FieldAnalysisReqHandler. The problem is that CharFilters return a different set of attributes and only one token.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Does your code also support CharFilters?

          Thanks Uwe – actually it does not. i've just checked the default-enabled fields & types from the example package. I'll try to fix that and update my last patch.

          <?xml version="1.0" encoding="UTF-8"?>
          <response>
              <lst name="responseHeader">
                  <int name="status">0</int>
                  <int name="QTime">1</int>
              </lst>
              <lst name="analysis">
                  <lst name="field_types">
                      <lst name="text_char_norm">
                          <lst name="index">
                              <str name="org.apache.lucene.analysis.charfilter.MappingCharFilter">Foo</str>
                              <arr name="org.apache.lucene.analysis.core.WhitespaceTokenizer">
                                  <lst>
                                      <str name="text">Foo</str>
                                      <str name="raw_bytes">[46 6f 6f]</str>
                                      <int name="start">0</int>
                                      <int name="end">3</int>
                                      <int name="position">1</int>
                                      <arr name="positionHistory">
                                          <int>1</int>
                                      </arr>
                                      <str name="type">word</str>
                                  </lst>
                              </arr>
                          </lst>
                      </lst>
                  </lst>
                  <lst name="field_names"/></lst>
          </response>

          will create an virtual object for CharFilters so that they have on property text - should be okay? Especially in Combination with other Filters & Tokenizer which have more than that.

          Show
          Stefan Matheis (steffkes) added a comment - Does your code also support CharFilters? Thanks Uwe – actually it does not. i've just checked the default-enabled fields & types from the example package. I'll try to fix that and update my last patch. <?xml version= "1.0" encoding= "UTF-8" ?> <response> <lst name= "responseHeader" > <int name= "status" > 0 </int> <int name= "QTime" > 1 </int> </lst> <lst name= "analysis" > <lst name= "field_types" > <lst name= "text_char_norm" > <lst name= "index" > <str name= "org.apache.lucene.analysis.charfilter.MappingCharFilter" > Foo </str> <arr name= "org.apache.lucene.analysis.core.WhitespaceTokenizer" > <lst> <str name= "text" > Foo </str> <str name= "raw_bytes" > [46 6f 6f] </str> <int name= "start" > 0 </int> <int name= "end" > 3 </int> <int name= "position" > 1 </int> <arr name= "positionHistory" > <int> 1 </int> </arr> <str name= "type" > word </str> </lst> </arr> </lst> </lst> </lst> <lst name= "field_names" /> </lst> </response> will create an virtual object for CharFilters so that they have on property text - should be okay? Especially in Combination with other Filters & Tokenizer which have more than that.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Patch based on SVN-Rev 1143882, works now also with CharFilter-Output.

          Screenshot: Normal, Verbose

          Show
          Stefan Matheis (steffkes) added a comment - Patch based on SVN-Rev 1143882 , works now also with CharFilter-Output. Screenshot: Normal , Verbose
          Hide
          Robert Muir added a comment -

          its great to see all this progress here!

          I had one suggestion, I felt this way about Version 1980 too... should we default the verbose checbox for analysis to "on"? I could be in the minority here, am I the only one who clicks verbose every time when using this?

          Show
          Robert Muir added a comment - its great to see all this progress here! I had one suggestion, I felt this way about Version 1980 too... should we default the verbose checbox for analysis to "on"? I could be in the minority here, am I the only one who clicks verbose every time when using this?
          Hide
          Erik Hatcher added a comment -

          verbose default to on please, yes: +1 - I always check that myself, and teach it that way to others.

          Show
          Erik Hatcher added a comment - verbose default to on please, yes: +1 - I always check that myself, and teach it that way to others.
          Hide
          Uwe Schindler added a comment -

          verbose on: +1

          Show
          Uwe Schindler added a comment - verbose on: +1
          Hide
          Stefan Matheis (steffkes) added a comment -

          verbose on: +1

          I've updated the last Patch, now based on SVN-Rev 1144392 – verbose activated per default

          Show
          Stefan Matheis (steffkes) added a comment - verbose on: +1 I've updated the last Patch, now based on SVN-Rev 1144392 – verbose activated per default
          Hide
          Mark Miller added a comment -

          This is great stuff - brings Solr's admin UI into the modern age. The Solr website could use some similar love

          I'd love to get off forrest and onto the new CMS - and get off our wiki software as well. Then perhaps Stefan could lend us some more of his skills

          We have plenty of need for this type of contributor IMO.

          Show
          Mark Miller added a comment - This is great stuff - brings Solr's admin UI into the modern age. The Solr website could use some similar love I'd love to get off forrest and onto the new CMS - and get off our wiki software as well. Then perhaps Stefan could lend us some more of his skills We have plenty of need for this type of contributor IMO.
          Hide
          Ryan McKinley added a comment -

          Hey Stefan-

          I have been out for a while... not sure what the state of your patches vs /trunk are. Do you want to make a new patch and I will get things up to date?

          Maybe we should close this ticket and open a few smaller ones for remaining TODO items.

          ryan

          Show
          Ryan McKinley added a comment - Hey Stefan- I have been out for a while... not sure what the state of your patches vs /trunk are. Do you want to make a new patch and I will get things up to date? Maybe we should close this ticket and open a few smaller ones for remaining TODO items. ryan
          Hide
          Stefan Matheis (steffkes) added a comment -

          Ryan,

          there was not really progress since a few days ... but i realized, that the directory structure was changed .. so i've updated the last patch, it's now based on SVN-Rev 1149113.

          Closing this ticket and continue with smaller todo-tickets sounds good, yes

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - Ryan, there was not really progress since a few days ... but i realized, that the directory structure was changed .. so i've updated the last patch, it's now based on SVN-Rev 1149113 . Closing this ticket and continue with smaller todo-tickets sounds good, yes Stefan
          Hide
          Ryan McKinley added a comment -

          This issue has become too large, so lets move subsequent work to SOLR-2667

          Show
          Ryan McKinley added a comment - This issue has become too large, so lets move subsequent work to SOLR-2667
          Hide
          hadi added a comment -

          I download the solr-admin patch, is it possible just overwrite the solr-admin files into the admin folder in tomcat/webapp? or it needs to add into the source and rebuild it with ant?
          also i want to use it with solr 3.3

          Show
          hadi added a comment - I download the solr-admin patch, is it possible just overwrite the solr-admin files into the admin folder in tomcat/webapp? or it needs to add into the source and rebuild it with ant? also i want to use it with solr 3.3
          Hide
          Stefan Matheis (steffkes) added a comment -

          hadi,

          I download the solr-admin patch, is it possible just overwrite the solr-admin files into the admin folder in tomcat/webapp? or it needs to add into the source and rebuild it with ant?

          just updating the files in your webapp folder should be fine

          also i want to use it with solr 3.3

          this instead, i guess, will not work completely. some parts of the new ui are relying on features which are only available on trunk. but i'd like to see if the other parts works like expected, if you'd give a try?

          Stefan

          Show
          Stefan Matheis (steffkes) added a comment - hadi, I download the solr-admin patch, is it possible just overwrite the solr-admin files into the admin folder in tomcat/webapp? or it needs to add into the source and rebuild it with ant? just updating the files in your webapp folder should be fine also i want to use it with solr 3.3 this instead, i guess, will not work completely. some parts of the new ui are relying on features which are only available on trunk. but i'd like to see if the other parts works like expected, if you'd give a try? Stefan

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Stefan Matheis (steffkes)
            • Votes:
              8 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development