[SOLR-2393] Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.0-ALPHA
• Assignee: Unassigned
• Reporter: Bill Bell
• Created: 28/Feb/11 04:22
• Updated: 20/Mar/12 03:33

Description

From Ryan McKinley to Jan Høydahl:

PhoneticFilterFactory could check
"DoubleMetaphone".equals( encoder ) and then create the specialized
Filter.

I don't feel strongly, but we could have:
EncoderFilter – just uses 'encode()'
DoubleMetaphoneFilter - uses special double metaphone stuff

EncoderFilterFactory – always uses EncoderFilter, and is not
semantically bound to 'phonetic'
PhoneticFilterFactory – picks the best phonetic filter impl (encoder
or double metaphone)

then deprecate:
PhoneticFilter
DoubleMetaphoneFilterFactory