Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2393

Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      From Ryan McKinley to Jan H√łydahl:

      PhoneticFilterFactory could check
      "DoubleMetaphone".equals( encoder ) and then create the specialized
      Filter.

      I don't feel strongly, but we could have:
      EncoderFilter – just uses 'encode()'
      DoubleMetaphoneFilter - uses special double metaphone stuff

      EncoderFilterFactory – always uses EncoderFilter, and is not
      semantically bound to 'phonetic'
      PhoneticFilterFactory – picks the best phonetic filter impl (encoder
      or double metaphone)

      then deprecate:
      PhoneticFilter
      DoubleMetaphoneFilterFactory

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              billnbell Bill Bell
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: