Solr
  1. Solr
  2. SOLR-2391

Replace remaining occurences of text/xml mime types to application/xml

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      There are some more W3C "deprecated" mime types in Solr's ResponseWriters. Also the XSLTResponseWriter incorrectly parses media-type + encoding <xsl:output> properties (exaples are not 100% correct). 100% correct examples would set media-type to application/xml and encoding to UTF-8 in xsl:output.

      1. SOLR-2391.patch
        9 kB
        Uwe Schindler
      2. SOLR-2391.patch
        14 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment - - edited

          Here some fixes to the XSLs and Content-Types:

          • Replaced text/xml by application/xml everywhere
          • <xsl:output media-type=.... should never contain charset, this is put into <xsl:output encoding=... - problem was XSLTRequestHandler ignoring this property, which is fixed now
          • ping.jsp is broken because it used deprecated and already removed methods - removed.
          • XMLRequestHandlers stylesheet parameter for browser-side XSL transform was restricted to a not-working absolute /admin folder, that was hardcoded as /admin. Removed that completely and made the XSL parameter totally unparsed. In my opinion, this should be removed, client side XSL is a no-go. Also the escaping was missing!
          Show
          Uwe Schindler added a comment - - edited Here some fixes to the XSLs and Content-Types: Replaced text/xml by application/xml everywhere <xsl:output media-type=.... should never contain charset, this is put into <xsl:output encoding=... - problem was XSLTRequestHandler ignoring this property, which is fixed now ping.jsp is broken because it used deprecated and already removed methods - removed. XMLRequestHandlers stylesheet parameter for browser-side XSL transform was restricted to a not-working absolute /admin folder, that was hardcoded as /admin. Removed that completely and made the XSL parameter totally unparsed. In my opinion, this should be removed, client side XSL is a no-go. Also the escaping was missing!
          Hide
          Uwe Schindler added a comment -

          Updated patch. Will commit soon!

          Show
          Uwe Schindler added a comment - Updated patch. Will commit soon!
          Hide
          Uwe Schindler added a comment -

          Committed trunk revision: 1075190
          Committed 3.x revision: 1075192

          Show
          Uwe Schindler added a comment - Committed trunk revision: 1075190 Committed 3.x revision: 1075192
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development