Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      The UIMA tests fail frequently in hudson now.

      I am not sure if this is due to not being able to connect to specific sites,
      but if this is the case it would be better to use a Mock component instead
      that doesn't need to do this.

      1. SOLR2387_2b.patch
        52 kB
        Tommaso Teofili
      2. SOLR2387_2.patch
        30 kB
        Tommaso Teofili
      3. SOLR2387.patch
        25 kB
        Tommaso Teofili

        Activity

        Hide
        Tommaso Teofili added a comment -

        Hello Robert,
        this is due to an issue on the alchemy remote service for language detection, I've made a quick patch to fix it now that don't use such a service however I'm gonna make a new patch as soon as possible to mock such calls.

        Show
        Tommaso Teofili added a comment - Hello Robert, this is due to an issue on the alchemy remote service for language detection, I've made a quick patch to fix it now that don't use such a service however I'm gonna make a new patch as soon as possible to mock such calls.
        Hide
        Robert Muir added a comment -

        this is due to an issue on the alchemy remote service for language detection, I've made a quick patch to fix it now that don't use such a service however I'm gonna make a new patch as soon as possible to mock such calls.

        Hi Tommaso, this sounds great! For now, I applied your workaround so the test can be re-enabled.

        Show
        Robert Muir added a comment - this is due to an issue on the alchemy remote service for language detection, I've made a quick patch to fix it now that don't use such a service however I'm gonna make a new patch as soon as possible to mock such calls. Hi Tommaso, this sounds great! For now, I applied your workaround so the test can be re-enabled.
        Hide
        Hoss Man added a comment -

        just to clarify the current state of things: it appears (based on my naive understanding of UIMA) that currently the tests still rely on an external site responding appropriately, but now we rely on a differnet external site (open calais)

        is that correct?

        Show
        Hoss Man added a comment - just to clarify the current state of things: it appears (based on my naive understanding of UIMA) that currently the tests still rely on an external site responding appropriately, but now we rely on a differnet external site (open calais) is that correct?
        Hide
        Tommaso Teofili added a comment -

        Hi Hoss,
        At the moment tests make calls to 2 remote services (one from OpenCalais and one from AlchemyAPI), I am working on a patch to completely avoid such calls to remote sites to grant tests' isolation.

        Show
        Tommaso Teofili added a comment - Hi Hoss, At the moment tests make calls to 2 remote services (one from OpenCalais and one from AlchemyAPI), I am working on a patch to completely avoid such calls to remote sites to grant tests' isolation.
        Hide
        Robert Muir added a comment -

        Thats correct: we can move the issue to 3.2 for future improvements (e.g. using mocks instead of real actual sites we need to connect to).

        However, I committed Tommaso's workaround for 3.1 so its "stable" at the moment... I don't think it needs to block the release.

        Show
        Robert Muir added a comment - Thats correct: we can move the issue to 3.2 for future improvements (e.g. using mocks instead of real actual sites we need to connect to). However, I committed Tommaso's workaround for 3.1 so its "stable" at the moment... I don't think it needs to block the release.
        Hide
        Tommaso Teofili added a comment -

        Hi all, I've prepared this patch which completely removes remote calls and tests the non-remote annotators (Tokenizer and HMM Tagger) as long as custom annotators one could write (see DummySentimentAnnotator and DummyEntityAnnotator).
        This patch also fixes two minor issues with runtime parameters fetch appearing when there were comments in <runtimeParameters> element and when the runtime parameter to override was not a String.
        Mocked annotators tests' patch will come separately.

        Show
        Tommaso Teofili added a comment - Hi all, I've prepared this patch which completely removes remote calls and tests the non-remote annotators (Tokenizer and HMM Tagger) as long as custom annotators one could write (see DummySentimentAnnotator and DummyEntityAnnotator). This patch also fixes two minor issues with runtime parameters fetch appearing when there were comments in <runtimeParameters> element and when the runtime parameter to override was not a String. Mocked annotators tests' patch will come separately.
        Hide
        Tommaso Teofili added a comment -

        Forgot to 'svn add' some files, this is the correct one

        Show
        Tommaso Teofili added a comment - Forgot to 'svn add' some files, this is the correct one
        Hide
        Robert Muir added a comment -

        Tommaso, thanks for the work here!

        I think for 3.1, the existing workaround you provided is relatively stable so I propose we should do the new-and-improved tests for 3.2.

        Show
        Robert Muir added a comment - Tommaso, thanks for the work here! I think for 3.1, the existing workaround you provided is relatively stable so I propose we should do the new-and-improved tests for 3.2.
        Hide
        Tommaso Teofili added a comment -

        Ok Robert, that sounds good.

        Show
        Tommaso Teofili added a comment - Ok Robert, that sounds good.
        Hide
        Robert Muir added a comment -

        setting to 3.2 for the new mock tests

        Show
        Robert Muir added a comment - setting to 3.2 for the new mock tests
        Hide
        Robert Muir added a comment -

        Committed revision 1084045. (trunk)
        Committed revision 1084047. (branch_3x)

        Show
        Robert Muir added a comment - Committed revision 1084045. (trunk) Committed revision 1084047. (branch_3x)
        Hide
        Robert Muir added a comment -

        Tommaso, thanks again!

        Show
        Robert Muir added a comment - Tommaso, thanks again!
        Hide
        Robert Muir added a comment -

        Bulk close for 3.2

        Show
        Robert Muir added a comment - Bulk close for 3.2

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development