Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2320

ReplicationHandler doesn't return master details unless it's also configured as a slave

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.4, 1.4.1
    • 3.1, 4.0-ALPHA
    • replication (java)
    • None

    Description

      While investigating SOLR-2314 i found a bug which seems to be the opposite of the behavior described there – so i'm filing a seperate bug to track it.

      if ReplicationHandler is only configured as a master, "command=details" requests won't include the "master" section. that section is only output if it is also configured as a slave.

      the method responsible for the details command generates the "master" details just fine, but the code to add it to the response seems to have erroneously been nested inside an if that only evaluates to true if there is a non-null SnapPuller (ie: it's also a slave)

      Attachments

        1. SOLR-2320.patch
          0.8 kB
          Chris M. Hostetter
        2. SOLR-2320.patch
          3 kB
          Chris M. Hostetter
        3. SOLR-2320.patch
          14 kB
          Chris M. Hostetter

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hossman Chris M. Hostetter
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment