[SOLR-2292] Lock down NamedList API, remove inefficent and esoteric methods

• Type: Task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 4.9, 6.0
• Assignee: Unassigned
• Reporter: Chris M. Hostetter
• Created: 21/Dec/10 17:45
• Updated: 09/May/16 18:46

Description

Over in SOLR-2288, rmuir made some good points about locking down the NamedList API to protect people...

I looked at your patch, and personally I think NamedList should really be type-safe.
If users want to use it in a type-unsafe way, thats fine, but the container itself shouldn't be List<Object>.

...

Separately, i just want to say the following about NamedList:

All uses of this API should really be reviewed. I'm quite aware that it warns you about the fact that its slow for certain operations,
but in my opinion these slow operations such as get(String, int) should be deprecated and removed.

Any users that are using NamedList in this way, especially in loops, are very likely using the wrong datastructure.

(emphasis added by me)

Issue Links

• relates to: SOLR-912 org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList
• relates to: SOLR-2288 clean up compiler warnings