Solr
  1. Solr
  2. SOLR-2285

excess SolrEventListeners created and then thrown away

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4, 1.4.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      As noted by Jørgen Trosby on the solr mailing list (subj: "SolrEventListeners are instantiated twice", "Mon, 11 Oct 2010 18:11:07 +0200") there is a problem with how SolrEventListeners are being created and initialized

      the bug is two fold:

      • the UpdatedHandler and the SolrCore both independently loop over all SolrEventListeners looking for the two classes of use cases they directly care about (postCommit/postOptimize vs newSearcher/firstSearcher) – in both cases they construct every declared listener even if it is not a type they care about
      • even when UpdatedHandler is finding a postCommit it cared about, it throws it away and constructing it again.

        Activity

        Hide
        Hoss Man added a comment -

        patch with test to verify and a fix.

        still testing this

        Show
        Hoss Man added a comment - patch with test to verify and a fix. still testing this
        Hide
        Hoss Man added a comment -

        trunk: Committed revision 1048886.
        3x: Committed revision 1048890.

        Show
        Hoss Man added a comment - trunk: Committed revision 1048886. 3x: Committed revision 1048890.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development