Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2280

commitWithin ignored for a delete query

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      The commitWithin option on an UpdateRequest is only honored for requests containing new documents. It does not, for example, work with a delete query. The following doesn't work as expected:

      UpdateRequest request = new UpdateRequest();
      request.deleteById("id123");
      request.setCommitWithin(1000);
      solrServer.request(request);
      

      In my opinion, the commitWithin attribute should be permitted on the <delete/> xml tag as well as <add/>. Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too. Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

        Attachments

        1. SOLR-2280-3x.patch
          25 kB
          Jan Høydahl
        2. SOLR-2280-3x.patch
          28 kB
          Jan Høydahl
        3. SOLR-2280-3x.patch
          31 kB
          Jan Høydahl
        4. SOLR-2280.patch
          24 kB
          Juan Grande
        5. SOLR-2280.patch
          24 kB
          Juan Grande
        6. SOLR-2280.patch
          24 kB
          Jan Høydahl
        7. SOLR-2280.patch
          27 kB
          Jan Høydahl
        8. SOLR-2280.patch
          28 kB
          Jan Høydahl
        9. SOLR-2280.patch
          28 kB
          Jan Høydahl

          Activity

            People

            • Assignee:
              juangrande Juan Grande
              Reporter:
              dsmiley David Smiley
            • Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: