Bild für Projekt hochgeladen: 'Solr'
  1. Solr
  2. SOLR-2263

RawResponseWriter should properly stream binary as well as textual files

Dateien anhängenScreenshot anhängenWähler anzeigenVorgang beobachtenBeobachter verwaltenUnteraufgabe erstellenVerknüpfungKlonenVerfasser des Kommenta...Zeichenfolge im Kommen...Update Comment VisibilityKommentare löschen
    XMLWordAusdruckbarJSON

    Details

    • Typ: Verbesserung
    • Status: Geschlossen
    • Priorität: Schwer
    • Lösung: Behoben
    • betrifft Version(en): Keine
    • Lösungsversion(en): 3.1, 4.0-ALPHA
    • Komponente(n): Admin UI
    • Stichwörter:
      Keine

      Beschreibung

      I noticed that the RawRequestHandler can NOT properly serve up binary data like images, only textual documents. I dug around for a while and it appears that reading in content via Streams, but sending them out via Writer doesn't work, because of character encoding problems.

      I wanted RawRequestHandler to work with binary images because the /browse handler in 3.x uses some autocomplete functionality that looks for a "indicator.gif" in the /velocity directory. And I'd like to be able to add other binary images to my velocity based search interface.

      After much digging around, I realized that if I made RawResponseWriter implement BinaryQueryResponseWriter, then everything works. I was able to stream both binary images and text documents to the browser.

      Not sure if this is the right path to go, and if there are other ramifications that I don't grok on making this change, so wanted to put it up for discussion.

        Anhänge

          Aktivität

          $i18n.getText('security.level.explanation', $currentSelection) Anzeigbar durch alle Benutzer
          Abbrechen

            Personen

            • Bearbeiter:
              Nicht zugewiesen
              Autor:
              epugh David Eric Pugh

              Daten

              • Erstellt:
                Aktualisiert:
                Erledigt:

                Vorgangsbereitstellung