Solr
  1. Solr
  2. SOLR-2225

CoreContainer#register should use checkDefault to normalize the core name

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA, 5.0
    • Component/s: multicore
    • Labels:
      None

      Description

      fail case:

      start with default collection set to collection1
      remove core collection1
      default collection on CoreContainer is still set to collection1
      add core collection1
      it doesn't act like the default core

      we might do as the summary suggests, or when the default core is removed, we reset to no default core until one is again explicitly set

        Issue Links

          Activity

          Mark Miller created issue -
          Hide
          Mark Miller added a comment -

          I don't remember this at all - digging in though.

          Show
          Mark Miller added a comment - I don't remember this at all - digging in though.
          Hide
          Robert Muir added a comment -

          There isn't any patch here yet, can we move out to 3.2?

          Show
          Robert Muir added a comment - There isn't any patch here yet, can we move out to 3.2?
          Yonik Seeley made changes -
          Field Original Value New Value
          Fix Version/s Next [ 12315093 ]
          Fix Version/s 3.1 [ 12314371 ]
          Fix Version/s 4.0 [ 12314992 ]
          Mark Miller made changes -
          Fix Version/s 3.2 [ 12316172 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s Next [ 12315093 ]
          Hide
          Mark Miller added a comment -

          Fix + test.

          Show
          Mark Miller added a comment - Fix + test.
          Mark Miller made changes -
          Attachment SOLR-2225.patch [ 12476917 ]
          Hide
          Robert Muir added a comment -

          Bulk move 3.2 -> 3.3

          Show
          Robert Muir added a comment - Bulk move 3.2 -> 3.3
          Robert Muir made changes -
          Fix Version/s 3.3 [ 12316471 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s 3.2 [ 12316172 ]
          Robert Muir made changes -
          Fix Version/s 3.4 [ 12316683 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s 3.3 [ 12316471 ]
          Hide
          Robert Muir added a comment -

          3.4 -> 3.5

          Show
          Robert Muir added a comment - 3.4 -> 3.5
          Robert Muir made changes -
          Fix Version/s 3.5 [ 12317876 ]
          Fix Version/s 3.4 [ 12316683 ]
          Simon Willnauer made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Fix Version/s 3.5 [ 12317876 ]
          Robert Muir made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Hide
          Mark Miller added a comment -

          I've updated this test and somehow this passes now - another issue must have solved it. I'll just commit the new test.

          Show
          Mark Miller added a comment - I've updated this test and somehow this passes now - another issue must have solved it. I'll just commit the new test.
          markrmiller committed 1357998 (1 file)
          Reviews: none

          SOLR-2225: new test around default core handling

          Mark Miller made changes -
          Fix Version/s 5.0 [ 12321664 ]
          Mark Miller made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          markrmiller committed 1358002 (4 files)
          Hoss Man made changes -
          Link This issue relates to SOLR-2605 [ SOLR-2605 ]
          Hide
          Hoss Man added a comment -

          i didn't dig into this, but based on the description of the problem i would bet money it was fixed by the changes in SOLR-2605.

          Show
          Hoss Man added a comment - i didn't dig into this, but based on the description of the problem i would bet money it was fixed by the changes in SOLR-2605 .
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development