Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-222

writeLockTimeout doesn't have effect

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Component/s: update
    • Labels:
      None

      Description

      writeLockTimeout is set in SolrIndexWriter.init() method as follows:

      if (config.writeLockTimeout != -1) setWriteLockTimeout(config.writeLockTimeout);

      but this doesn't have effect because setWriteLockTimeout() is an instance method of IndexWriter and at this moment,
      IndexWriter's constructor had already been executed and write.lock had beed obtained in the constructor.

      To have effect, we should use IndexWriter.setDefaultWriteLockTimeout() class method before creating SolrIndexWriter instance.

      With the attached patch, I moved setWriteLockTimeout() to SolrCore and change it to IndexWriter.setDefaultWriteLockTimeout().
      I'm not sure it is an appropriate place, but it works.

      regards,

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              koji Koji Sekiguchi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: