Solr
  1. Solr
  2. SOLR-2180

Requests to Embedded Solr (often) leave old Searchers open

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.2, 1.5, 3.1, 4.0-ALPHA
    • Fix Version/s: 1.4.2, 3.1, 4.0-ALPHA
    • Component/s: search
    • Labels:
      None

      Description

      SolrEmbeddedServer.request() fails to call SolrQueryRequest.close() at the very end of a successful request. This (in some situations) causes EmbeddedSolr to leave old Searchers open until the Solr core stops (core unload, the JVM restarts). This leaves old Solr and Lucene caches in place, which causes a memory leak.

      A fix for this was committed on the trunk on Sunday, Oct/15/2010.

      Revision r1023599 to SolrEmbeddedServer

      This should be backported, or the problem checked for, in 1.4.2 and 3.1.

        Activity

        Hide
        Yonik Seeley added a comment -

        My reading of it was that it was only on an exception would the request not be closed (which is still a serious bug though).
        I was cranking on tests and overlooked that this change had a broader impact.

        Show
        Yonik Seeley added a comment - My reading of it was that it was only on an exception would the request not be closed (which is still a serious bug though). I was cranking on tests and overlooked that this change had a broader impact.
        Hide
        Yonik Seeley added a comment -

        I packported to 3.x and 1.4.x

        It's unclear exactly what would have triggered this bug... the SearchHandler.handleRequest normally catches exceptions and returns normally, so a normal query exception wouldn't have. I'm sure there were some ways though.

        Show
        Yonik Seeley added a comment - I packported to 3.x and 1.4.x It's unclear exactly what would have triggered this bug... the SearchHandler.handleRequest normally catches exceptions and returns normally, so a normal query exception wouldn't have. I'm sure there were some ways though.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Lance Norskog
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development