Solr
  1. Solr
  2. SOLR-2173

Suggester should always rebuild Lookup data if Lookup.load fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1, 4.0-ALPHA
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      See also the comments here. Currently available Lookup implementations don't implement load/save - these calls always return false.

      This means that Lookup dictionary is lost on searcher reload (or core reload) and needs to be rebuilt. However, this breaks the semantics of spellcheck.build=true, because with this patch the dictionary will always be recreated, even if this parameter is false... Still, this may be less surprising to users than a vanishing autosuggest functionality after commit.

      1. SOLR-2173.patch
        2 kB
        Andrzej Bialecki

        Activity

        Hide
        Andrzej Bialecki added a comment -

        Patch to fix the issue and a unit test.

        Show
        Andrzej Bialecki added a comment - Patch to fix the issue and a unit test.
        Hide
        Yonik Seeley added a comment -

        Seems like a reasonable approach to me.

        Show
        Yonik Seeley added a comment - Seems like a reasonable approach to me.
        Hide
        Andrzej Bialecki added a comment -

        Committed to trunk (1025781) and branch_3x (1025783). Thanks!

        Show
        Andrzej Bialecki added a comment - Committed to trunk (1025781) and branch_3x (1025783). Thanks!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Andrzej Bialecki
            Reporter:
            Andrzej Bialecki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development