Solr
  1. Solr
  2. SOLR-2111

treat facet exceptions consistently

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
      In distrib mode, it will cause the whole request to fail.

      1. SOLR-2111.patch
        24 kB
        Yonik Seeley

        Activity

        Hide
        Yonik Seeley added a comment -

        I'm also thinking that as long as we are treating facet exceptions in this way, an exception should be caught per facet-command (i.e. the first exception should not prevent the next facet command from completing).

        Show
        Yonik Seeley added a comment - I'm also thinking that as long as we are treating facet exceptions in this way, an exception should be caught per facet-command (i.e. the first exception should not prevent the next facet command from completing).
        Hide
        Yonik Seeley added a comment -

        The direction I'm currently thinking of taking on this is to change facet_counts/exception to a List<String> (from a single String now) to support listing multiple exceptions.

        Show
        Yonik Seeley added a comment - The direction I'm currently thinking of taking on this is to change facet_counts/exception to a List<String> (from a single String now) to support listing multiple exceptions.
        Hide
        Yonik Seeley added a comment -

        Here's a patch that implements the suggestion above: "exception" is now a list, an exception in one faceting command doesn't cause the preceding ones to fail, and all shard faceting exceptions are added during aggregation.

        Show
        Yonik Seeley added a comment - Here's a patch that implements the suggestion above: "exception" is now a list, an exception in one faceting command doesn't cause the preceding ones to fail, and all shard faceting exceptions are added during aggregation.
        Hide
        Yonik Seeley added a comment -

        committed.

        Show
        Yonik Seeley added a comment - committed.
        Hide
        Koji Sekiguchi added a comment -

        back port to branch_3x.

        Show
        Koji Sekiguchi added a comment - back port to branch_3x.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development