Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: spellchecker
-
Labels:None
Description
In DistributedSpellCheckTest, if I add 10 additional documents to the index with field "lowerfilt" containing "The quack red fox jumped over the lazy brown dogs.", then the shard'ed SpellCheckComponent wants to correct "quick" to "quack". The control, non-shared'ed component correctly does not try to correct "quick". The test subsequently fails.
Issue Links
- is related to
-
SOLR-785
Distributed SpellCheckComponent
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Committed. Thanks James!
I think there are 2 related problems here:
1. DistributedSpellCheckComponentTest.java runs the test 4 times: first with 1 shard, then with 2 shards, etc. In between iterations, it does not clear the Jetty data directories so the first shard from the 2-shard iteration has all the data from the 1-shard iteration, etc. I can work around this by adding "del(":");" as the first line in doTest(). Unfortunately doing this makes the test fail. I think the problem with the Tester is masking a failing test.
2. The Component ought to report a word as misspelled if ALL of the shards report it as not in the dictionary. However, the current implementation returns a word as misspelled if ANY shard reports it as not in the dictionary.
This second patch version resolves the second issue. The problem with the test may warrant its own issue. (I used the workaround here).
This patch demos the problem.
Bulk close for 3.1.0 release