Solr
  1. Solr
  2. SOLR-2081

BaseResponseWriter isStreamingDocs causes SingleResponseWriter.end to be called 2x

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Response Writers
    • Labels:
      None

      Description

      I noticed while working on the slew of Geo issues that there was another bug in BaseResponseWriter.java. Basically if you have isStreamingDocs set to true (causing writeDoc to be called), you get 2 calls of SIngleResponseWriter.end(), which is bad (I was getting two </channel></rss> endings in the GeoRssResponseWriter). This patch fixes the issue.

        Issue Links

          Activity

          Chris A. Mattmann created issue -
          Hide
          Chris A. Mattmann added a comment -

          Simple patch for BaseResponeWriter that fixes the issue.

          Show
          Chris A. Mattmann added a comment - Simple patch for BaseResponeWriter that fixes the issue.
          Chris A. Mattmann made changes -
          Field Original Value New Value
          Attachment SOLR-2081.Mattmann.082310.patch.txt [ 12452824 ]
          Chris A. Mattmann made changes -
          Link This issue blocks SOLR-2074 [ SOLR-2074 ]
          Hide
          Hoss Man added a comment -

          Committed revision 1037965. ... trunk
          Committed revision 1037969. ... 3x

          thanks chris.

          Show
          Hoss Man added a comment - Committed revision 1037965. ... trunk Committed revision 1037969. ... 3x thanks chris.
          Hoss Man made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.0 [ 12314992 ]
          Resolution Fixed [ 1 ]
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release
          Grant Ingersoll made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks SOLR-2074 [ SOLR-2074 ]
          Gavin made changes -
          Link This issue is depended upon by SOLR-2074 [ SOLR-2074 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          91d 10h 11m 1 Hoss Man 23/Nov/10 02:16
          Resolved Resolved Closed Closed
          127d 13h 29m 1 Grant Ingersoll 30/Mar/11 16:45

            People

            • Assignee:
              Unassigned
              Reporter:
              Chris A. Mattmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development