Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2081

BaseResponseWriter isStreamingDocs causes SingleResponseWriter.end to be called 2x

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Response Writers
    • Labels:
      None

      Description

      I noticed while working on the slew of Geo issues that there was another bug in BaseResponseWriter.java. Basically if you have isStreamingDocs set to true (causing writeDoc to be called), you get 2 calls of SIngleResponseWriter.end(), which is bad (I was getting two </channel></rss> endings in the GeoRssResponseWriter). This patch fixes the issue.

        Issue Links

          Activity

          Hide
          chrismattmann Chris A. Mattmann added a comment -

          Simple patch for BaseResponeWriter that fixes the issue.

          Show
          chrismattmann Chris A. Mattmann added a comment - Simple patch for BaseResponeWriter that fixes the issue.
          Hide
          hossman Hoss Man added a comment -

          Committed revision 1037965. ... trunk
          Committed revision 1037969. ... 3x

          thanks chris.

          Show
          hossman Hoss Man added a comment - Committed revision 1037965. ... trunk Committed revision 1037969. ... 3x thanks chris.
          Hide
          gsingers Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          gsingers Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              Unassigned
              Reporter:
              chrismattmann Chris A. Mattmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development