Solr
  1. Solr
  2. SOLR-2057

DataImportHandler never calls UpdateRequestProcessor.finish()

    Details

      Description

      I was experimenting with custom UpdateRequestProcessor implementations and noticed that the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back down to the fact that SolrWriter in the data import handler never calls the finish() method on its UpdateRequestProcessor.

      1. SOLR-2057.patch
        12 kB
        Koji Sekiguchi
      2. SOLR-2057.patch
        11 kB
        Drew Farris

        Activity

        Hide
        Drew Farris added a comment -

        This patch against branch_3x adds a finish() method to SolrWriter which in turn calls UpdateRequestProcessor.finish().

        It appears that other classes call finish() regardless of the update's final state, so I added a call to finish to DocBuilder in what seems like an appropriate location near the end of execute()

        Updated unit tests to add a TestUpdateRequestProcessor, and validate that the appropriate methods are being called in the major cases.

        Show
        Drew Farris added a comment - This patch against branch_3x adds a finish() method to SolrWriter which in turn calls UpdateRequestProcessor.finish(). It appears that other classes call finish() regardless of the update's final state, so I added a call to finish to DocBuilder in what seems like an appropriate location near the end of execute() Updated unit tests to add a TestUpdateRequestProcessor, and validate that the appropriate methods are being called in the major cases.
        Hide
        Koji Sekiguchi added a comment -

        Thank you for contributing the patch, Drew. Looks great!

        I needed to change the update processor class name in contentstream-solrconfig.xml to pass test.
        I'll commit in a few days.

        Show
        Koji Sekiguchi added a comment - Thank you for contributing the patch, Drew. Looks great! I needed to change the update processor class name in contentstream-solrconfig.xml to pass test. I'll commit in a few days.
        Hide
        Koji Sekiguchi added a comment -

        trunk: Committed revision 1030098.
        branch_3x: Committed revision 1030114.

        Thanks, Drew!

        Show
        Koji Sekiguchi added a comment - trunk: Committed revision 1030098. branch_3x: Committed revision 1030114. Thanks, Drew!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Koji Sekiguchi
            Reporter:
            Drew Farris
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development