Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-204

Let solrconfig.xml configure the SolrDispatchFilter to handle /select

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.2
    • None
    • None

    Description

      The major reason to make everythign use the SolrDispatchFilter is that we would have consistent error handling. Currently,

      SolrServlet spits back errors using:
      PrintWriter writer = response.getWriter();
      writer.write(msg);

      and the SolrDispatchFilter spits them back using:
      res.sendError( code, ex.getMessage() );

      Using "sendError" lets the servlet container format the code so it shows up ok in a browser. Without it, you may have to view source to see the error.

      Aditionaly, SolrDispatchFilter is more decerning about including stack trace. It only includes a stack trace of 500 or an unknown response code.

      Eventually, the error should probably be formatted in the requested format - SOLR-141.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ryantxu Ryan McKinley
            ryantxu Ryan McKinley
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment