Solr
  1. Solr
  2. SOLR-2047

ReplicationHandler should accept bool type for enable flag

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: replication (java)
    • Labels:
      None

      Description

      Currently, the type of enable flag in ReplicationHandler is str:

      <lst name="slave">
        <str name="enable">true</str>
        <str name="masterUrl">http://localhost:8983/solr/replication</str>
        <str name="pollInterval">00:00:60</str>
      </lst>
      

      It should be bool.

      1. SOLR-2047.patch
        2 kB
        Koji Sekiguchi

        Activity

        Hide
        Koji Sekiguchi added a comment -

        Patch attached. This fix can accept bool type. It also accept str type for back-compat. Now "on" and "yes" are recognized for both bool and str.

        Show
        Koji Sekiguchi added a comment - Patch attached. This fix can accept bool type. It also accept str type for back-compat. Now "on" and "yes" are recognized for both bool and str.
        Hide
        Koji Sekiguchi added a comment -

        trunk: Committed revision 985672.
        branch_3x: Committed revision 985681.

        Show
        Koji Sekiguchi added a comment - trunk: Committed revision 985672. branch_3x: Committed revision 985681.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Koji Sekiguchi
            Reporter:
            Koji Sekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development