Solr
  1. Solr
  2. SOLR-2036

remove automatic fieldCache ram size estimation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.2, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Don't estimate the size of the fieldCache entries, even on "insanity" (which can happen from perfectly sane Solr uses)
      http://search.lucidimagination.com/search/document/afdb2f0002fb8866/solr_1_4_stats_page_slow

      1. SOLR-2036.patch
        1.0 kB
        Yonik Seeley

        Activity

        Hide
        Yonik Seeley added a comment -

        From the referenced email thread:

        we just deployed Solr 1.4.1 and the stats page takes over a minute to load for us as well and began causing OutOfMemory errors

        It looks like the ram estimator puts every object into a map to keep track if it's been visited before - so this is definitely the source of the memory issues.

        Show
        Yonik Seeley added a comment - From the referenced email thread: we just deployed Solr 1.4.1 and the stats page takes over a minute to load for us as well and began causing OutOfMemory errors It looks like the ram estimator puts every object into a map to keep track if it's been visited before - so this is definitely the source of the memory issues.
        Hide
        Yonik Seeley added a comment -

        I think I just spotted a bug: the sanity checker itself does the ram-size estimation... so the slowdown and OOM issues would happen even if there was not "insanity". I'll work up a patch.

        Show
        Yonik Seeley added a comment - I think I just spotted a bug: the sanity checker itself does the ram-size estimation... so the slowdown and OOM issues would happen even if there was not "insanity". I'll work up a patch.
        Hide
        Yonik Seeley added a comment -

        This patch should fix the bug and also remove ram estimation when insanity is detected.

        Show
        Yonik Seeley added a comment - This patch should fix the bug and also remove ram estimation when insanity is detected.
        Hide
        Yonik Seeley added a comment -

        committed to trunk and the 3.1 and 1.4 branches.

        Show
        Yonik Seeley added a comment - committed to trunk and the 3.1 and 1.4 branches.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development