Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2027

SolrJ FacetField should never return null from getValues()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.1
    • Fix Version/s: 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      In some circumstances, FacetField.getValues() will return null. I'd like for my iteration code to simply be:

      for (c : ff.getValues() { 
        // ...
      }
      

      However this will throw an NPE if I don't wrap this in either a null check or this check: ff.getValueCount() > 0

      I propose that getValues() return a Collections.EMPTY_LIST if the internal value is null.

        Attachments

          Activity

            People

            • Assignee:
              cmale Chris Male
              Reporter:
              dsmiley David Smiley
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: