Solr
  1. Solr
  2. SOLR-2008

SolrCore.close should shutdown updateHandler before searchExecutor

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3, 1.4, 1.4.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      As noted on the mailing list...

      http://markmail.org/message/cvihm2m6aqhrfbo5

      a RejectedExecutionException can occur when shutting down a solr core if the UpdateHandler.close() wants to do an autocommit - because the searchExecutor has already been closed.

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          Yandong: the code has been refactored and re-worked quite a bit, but i think you are correct - the fundemental crux of the issue (which order these things should be closed) does seem to have been reverted.

          I've opened SOLR-3861 to investigate.

          Yandong: are you seeing actual problems because of this (The (ie: RejectedExecutionExceptions) or is this just a discrepancy you noticed reviewing hte code? – either way please share your comments in SOLR-3861

          Show
          Hoss Man added a comment - Yandong: the code has been refactored and re-worked quite a bit, but i think you are correct - the fundemental crux of the issue (which order these things should be closed) does seem to have been reverted. I've opened SOLR-3861 to investigate. Yandong: are you seeing actual problems because of this (The (ie: RejectedExecutionExceptions) or is this just a discrepancy you noticed reviewing hte code? – either way please share your comments in SOLR-3861
          Hide
          Yandong Yao added a comment -

          Just compared solr-4.0-beta source code and diff at http://mail-archives.apache.org/mod_mbox/lucene-commits/201007.mbox/%3C20100720180640.535952388906@eris.apache.org%3E,

          seems the fix in this patch are not in solr-4.0-beta. Please help to check, thanks!

          Show
          Yandong Yao added a comment - Just compared solr-4.0-beta source code and diff at http://mail-archives.apache.org/mod_mbox/lucene-commits/201007.mbox/%3C20100720180640.535952388906@eris.apache.org%3E , seems the fix in this patch are not in solr-4.0-beta. Please help to check, thanks!
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release
          Hide
          Hoss Man added a comment -

          Committed revision 965938. - trunk
          Committed revision 965940. - branch 3x

          Show
          Hoss Man added a comment - Committed revision 965938. - trunk Committed revision 965940. - branch 3x

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development