If you truly believe this (I think you are wrong), then we should do the following:
it's right there in the javadoc for SolrExampleTestBase
* This should include tests against the example solr config
...it has subclasses that use Jetty, and other subclasses that use embedded solr.
the example config used in said tests shouldnt load up shit from contrib.
the example config is the example config – it's the config we put up on a pedestal in each release and say "this is what you should start with when writing your own config". we should test that those configs are actually usable w/o errors – that was the goal of the test
If the example configs suggest loading stuff from contrib, then we need to test that too.
...if they are really unit tests as you claim...
a) I never claimed they were unit tests ... i called them "tests".
b) I have no interest in getting into a philosophical debate about unit vs functional vs integration tests.
c) I never stated an opinion about whether we need to test the usage of these configs in both in embedded clients and in jetty.
i didn't write the test, and i didn't defend the use of Jetty for this – so pick a fight with someone else if that's your goal. All i did was point out that changing the test to use configs different from those in the example directory defeats the point of the tests.