Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-198

RunExecutableListener always waits for the subprocess completion regardless of wait="false"

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.2
    • 1.2
    • None
    • None

    Description

      Although the type of the value of "wait" attribute is boolean in solrconfig.xml:

      <listener event="postCommit" class="solr.RunExecutableListener">
      <str name="exe">snapshooter</str>
      <str name="dir">solr/bin</str>
      <bool name="wait">false</bool>
      <arr name="args"> <str>arg1</str> <str>arg2</str> </arr>
      <arr name="env"> <str>MYVAR=val1</str> </arr>
      </listener>

      RunExecutableListener trys to get the value as a string:

      if ("false".equals(args.get("wait"))) wait=false;

      therefore, it always waits for the subprocess completion, even if you set wait="false" . The above line would probably be like this:

      if (Boolean.FALSE.equals(args.get("wait"))) wait=false;

      regards,

      Attachments

        1. RunExecutableListener.java.diff
          0.5 kB
          Koji Sekiguchi

        Activity

          People

            Unassigned Unassigned
            okoji091 Koji Sekiguchi
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: