Solr
  1. Solr
  2. SOLR-198

RunExecutableListener always waits for the subprocess completion regardless of wait="false"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2
    • Component/s: None
    • Labels:
      None

      Description

      Although the type of the value of "wait" attribute is boolean in solrconfig.xml:

      <listener event="postCommit" class="solr.RunExecutableListener">
      <str name="exe">snapshooter</str>
      <str name="dir">solr/bin</str>
      <bool name="wait">false</bool>
      <arr name="args"> <str>arg1</str> <str>arg2</str> </arr>
      <arr name="env"> <str>MYVAR=val1</str> </arr>
      </listener>

      RunExecutableListener trys to get the value as a string:

      if ("false".equals(args.get("wait"))) wait=false;

      therefore, it always waits for the subprocess completion, even if you set wait="false" . The above line would probably be like this:

      if (Boolean.FALSE.equals(args.get("wait"))) wait=false;

      regards,

        Activity

        Koji Sekiguchi created issue -
        Koji Sekiguchi made changes -
        Field Original Value New Value
        Attachment RunExecutableListener.java.diff [ 12354433 ]
        tf0054 made changes -
        Affects Version/s 1.2 [ 12312235 ]
        Yonik Seeley made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hoss Man made changes -
        Fix Version/s 1.2 [ 12312235 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Koji Sekiguchi
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development