Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1953

It may be possible for temporary files to accumulator until the Solr process is shut down

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.1, 1.5
    • Fix Version/s: 6.4, 7.0
    • Component/s: update

      Description

      While researching SOLR-1951, the behavior of commons-fileupload in handling multipart form posts came into question. commons-fileupload creates a temporary file for the main content area of such posts, and purportedly has a background thread which cleans up these files. However, Mark Miller discovered that the javadoc in this matter may be incorrect, and that commons-fileupload may in fact just be adding files to the JVM's list of files needing cleanup on exit.

      If so, this will show up in two ways: first, temporary files will accumulate in the java.io.tmpdir area. Second, non-heap memory for the JVM will slowly increase over time (since the file pointers the JVM tracks in this way are not kept in the java heap).

      I will attach a potential fix; however, this ticket should be viewed as a workitem for the need for further research in this area.

        Attachments

        1. SOLR-1953.patch
          0.7 kB
          Karl Wright
        2. SOLR-1953.patch
          2 kB
          Mark Miller
        3. SOLR-1953.patch
          11 kB
          Mark Miller

          Issue Links

            Activity

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                kwright@metacarta.com Karl Wright
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: