Solr
  1. Solr
  2. SOLR-1939

DataImportHandler reports success after running out of disk space

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Labels:

      Description

      DataImportHandler reports success after running out of disk space (.properties file is updated with new time stamps and status page reports success). Out of disk space exceptions should be treated more like datasource-level exceptions than like document-level exceptions (i.e. they should cause the import to report failure).

      Original discussion here:
      http://lucene.472066.n3.nabble.com/DataImportHandler-and-running-out-of-disk-space-td835125.html

      1. notes_for_SOLR1939.rtf
        36 kB
        John Whelan
      2. SOLR-1939.patch
        3 kB
        John Whelan

        Activity

        Hide
        Robert Muir added a comment -

        Bulk move 3.2 -> 3.3

        Show
        Robert Muir added a comment - Bulk move 3.2 -> 3.3
        Hide
        Robert Muir added a comment -

        3.4 -> 3.5

        Show
        Robert Muir added a comment - 3.4 -> 3.5
        Hide
        Hoss Man added a comment -

        Bulk changing fixVersion 3.6 to 4.0 for any open issues that are unassigned and have not been updated since March 19.

        Email spam suppressed for this bulk edit; search for hoss20120323nofix36 to identify all issues edited

        Show
        Hoss Man added a comment - Bulk changing fixVersion 3.6 to 4.0 for any open issues that are unassigned and have not been updated since March 19. Email spam suppressed for this bulk edit; search for hoss20120323nofix36 to identify all issues edited
        Hide
        Hoss Man added a comment -

        Removing fix version since this issue hasn't gotten much attention lately and doesn't appear to be a priority for anyone.

        As always: if someone wants to take on this work they are welcome to do so at any time and the target release can be revisited

        Show
        Hoss Man added a comment - Removing fix version since this issue hasn't gotten much attention lately and doesn't appear to be a priority for anyone. As always: if someone wants to take on this work they are welcome to do so at any time and the target release can be revisited
        Hide
        John Whelan added a comment -

        I added an attempt at a fix for this issue. I also attached a 'notes' file that discusses some of the shortcomings of the fix. (This is my first attempt at following http://wiki.apache.org/solr/HowToContribute )

        Show
        John Whelan added a comment - I added an attempt at a fix for this issue. I also attached a 'notes' file that discusses some of the shortcomings of the fix. (This is my first attempt at following http://wiki.apache.org/solr/HowToContribute )
        Hide
        Erick Erickson added a comment -

        2013 Old JIRA cleanup

        Show
        Erick Erickson added a comment - 2013 Old JIRA cleanup
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks for the patch John and sorry that I'm so late in reviewing it.

        I think a better way to handle this would be to throw a SEVERE level wrapped exception from the SolrWriter itself instead of handling it in DocBuilder. That is also how data source level exceptions are handled.

        The problem with this patch is that it aborts on any IOException which means that a connect or read timeout can also abort indexing. So we need to be very careful about throwing this only if Solr runs out of disk space.

        Show
        Shalin Shekhar Mangar added a comment - Thanks for the patch John and sorry that I'm so late in reviewing it. I think a better way to handle this would be to throw a SEVERE level wrapped exception from the SolrWriter itself instead of handling it in DocBuilder. That is also how data source level exceptions are handled. The problem with this patch is that it aborts on any IOException which means that a connect or read timeout can also abort indexing. So we need to be very careful about throwing this only if Solr runs out of disk space.

          People

          • Assignee:
            Unassigned
            Reporter:
            Wojtek Piaseczny
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development