Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1938

make ElisionFilterFactory user-friendly

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.1, 4.0-ALPHA
    • Schema and Analysis
    • None

    Description

      The ElisionFilterFactory is useful for removing french articles from words (e.g. l'avion -> avion, see its tests).

      But the factory itself isnt very friendly, you need to provide an actual text file listing these, which is sorta overkill
      Such a text file would look like:

      # below are my articles
      l
      m
      t
      ...
      

      I propose instead of throwing a RuntimeException if you dont provide the articles param, to just use the default set
      already in ElisionFilter: (l, m, t, qu, n, s, j)

      It wont backwards break anyone as if they weren't providing it, they were getting RuntimeException before.

      Attachments

        1. SOLR-1938.patch
          2 kB
          Robert Muir

        Activity

          People

            rcmuir Robert Muir
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: