Solr
  1. Solr
  2. SOLR-1889

Change default value of 'mm' param to depend on explicit/implicit value of q.op

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: search
    • Labels:
      None

      Description

      The 'mm' param for the dismax parser has always defaulted to 100%, but many first time users seem to expect that the default behavior of dismax should work similar to the standard QParser, and be influenced by the schema configured default query op, or the q.op query param.

      we should change the default value for "mm" to be equivalent to 100% if the derived value of "q.op" would be AND, and to be 1 if the derived value of "q.op" would be OR. We should document this in CHANGES.txt so people who are upgrading know that if they have q.op=OR, but they still want a default mm value of 100%, they should add it as a configured default for their request handlers.

        Activity

        Hide
        Hoss Man added a comment -

        Committed revision 950710.

        Show
        Hoss Man added a comment - Committed revision 950710.
        Hide
        Hoss Man added a comment -

        Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

        A unique token for finding these 240 issues in the future: hossversioncleanup20100527

        Show
        Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
        Hide
        Hoss Man added a comment -

        Path that refactors both the q.op and mm param parsing logic into utility methods and updates the mm logic to take q.op into account.

        its not as clean as i thought it would be becuse of how QParser eals with params vs localParams, but it's functional

        Show
        Hoss Man added a comment - Path that refactors both the q.op and mm param parsing logic into utility methods and updates the mm logic to take q.op into account. its not as clean as i thought it would be becuse of how QParser eals with params vs localParams, but it's functional
        Hide
        Eric Pugh added a comment -

        Recently ran into this where the 'mm' was forcing perfect matches, and leading to the standard parser being great, but dismax being terrible!

        Show
        Eric Pugh added a comment - Recently ran into this where the 'mm' was forcing perfect matches, and leading to the standard parser being great, but dismax being terrible!

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development