Solr
  1. Solr
  2. SOLR-1876

Convert all tokenstreams and tests to use CharTermAttribute

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      See the improvements in LUCENE-2302.

      TermAttribute has been deprecated for flexible indexing, as terms can really be anything, as long as they can
      be serialized to byte[].

      For character-terms, a CharTermAttribute has been created, with a more friendly API. Additionally this attribute
      implements the CharSequence and Appendable interfaces.

      We should convert all Solr tokenstreams to use this new attribute.

        Issue Links

          Activity

          Robert Muir created issue -
          Robert Muir made changes -
          Field Original Value New Value
          Link This issue is part of LUCENE-2372 [ LUCENE-2372 ]
          Hide
          Robert Muir added a comment -

          This patch does the following:

          • Converts all tokenstreams to use CharTermAttribute
          • Makes all non-final concrete TokenStreams and Analyzers final (see LUCENE-2389)
          • enables both lucene and solr assertions when running solr core and contrib tests (previously disabled!)

          All tests pass, and also pass with the additional assertions if you apply LUCENE-2389

          Show
          Robert Muir added a comment - This patch does the following: Converts all tokenstreams to use CharTermAttribute Makes all non-final concrete TokenStreams and Analyzers final (see LUCENE-2389 ) enables both lucene and solr assertions when running solr core and contrib tests (previously disabled!) All tests pass, and also pass with the additional assertions if you apply LUCENE-2389
          Robert Muir made changes -
          Attachment SOLR-1876.patch [ 12441350 ]
          Uwe Schindler made changes -
          Link This issue is part of LUCENE-2389 [ LUCENE-2389 ]
          Hide
          Uwe Schindler added a comment -

          Looks good, I will check this in more detail later.

          Show
          Uwe Schindler added a comment - Looks good, I will check this in more detail later.
          Hide
          Uwe Schindler added a comment -

          OK, all is fine!

          Show
          Uwe Schindler added a comment - OK, all is fine!
          Robert Muir made changes -
          Assignee Robert Muir [ rcmuir ]
          Hide
          Robert Muir added a comment -

          Committed revision 932862.

          Thanks for the review and help Uwe!

          Show
          Robert Muir added a comment - Committed revision 932862. Thanks for the review and help Uwe!
          Robert Muir made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Uwe Schindler made changes -
          Fix Version/s 4.0 [ 12314992 ]
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release
          Grant Ingersoll made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          18h 24m 1 Robert Muir 11/Apr/10 11:26
          Resolved Resolved Closed Closed
          353d 5h 19m 1 Grant Ingersoll 30/Mar/11 16:45

            People

            • Assignee:
              Robert Muir
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development