Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1876

Convert all tokenstreams and tests to use CharTermAttribute

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      See the improvements in LUCENE-2302.

      TermAttribute has been deprecated for flexible indexing, as terms can really be anything, as long as they can
      be serialized to byte[].

      For character-terms, a CharTermAttribute has been created, with a more friendly API. Additionally this attribute
      implements the CharSequence and Appendable interfaces.

      We should convert all Solr tokenstreams to use this new attribute.

        Issue Links

          Activity

          Hide
          rcmuir Robert Muir added a comment -

          This patch does the following:

          • Converts all tokenstreams to use CharTermAttribute
          • Makes all non-final concrete TokenStreams and Analyzers final (see LUCENE-2389)
          • enables both lucene and solr assertions when running solr core and contrib tests (previously disabled!)

          All tests pass, and also pass with the additional assertions if you apply LUCENE-2389

          Show
          rcmuir Robert Muir added a comment - This patch does the following: Converts all tokenstreams to use CharTermAttribute Makes all non-final concrete TokenStreams and Analyzers final (see LUCENE-2389 ) enables both lucene and solr assertions when running solr core and contrib tests (previously disabled!) All tests pass, and also pass with the additional assertions if you apply LUCENE-2389
          Hide
          thetaphi Uwe Schindler added a comment -

          Looks good, I will check this in more detail later.

          Show
          thetaphi Uwe Schindler added a comment - Looks good, I will check this in more detail later.
          Hide
          thetaphi Uwe Schindler added a comment -

          OK, all is fine!

          Show
          thetaphi Uwe Schindler added a comment - OK, all is fine!
          Hide
          rcmuir Robert Muir added a comment -

          Committed revision 932862.

          Thanks for the review and help Uwe!

          Show
          rcmuir Robert Muir added a comment - Committed revision 932862. Thanks for the review and help Uwe!
          Hide
          gsingers Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          gsingers Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              rcmuir Robert Muir
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development