Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      We can optimize PatternReplaceFilter:

      • don't need to create Strings since CharTermAttribute implements CharSequence, just match directly against it.
      • reuse the matcher, since CharTermAttribute is reused, too.
      • don't create Strings/waste time in replaceAll/replaceFirst if the term doesn't match the regex at all... check with find() first.

      There is more that could be done to make it faster for terms that do match, but this is simple and a start.

        Issue Links

          Activity

          Hide
          rcmuir Robert Muir added a comment -

          Committed revision 932752.

          Show
          rcmuir Robert Muir added a comment - Committed revision 932752.
          Hide
          hossman Hoss Man added a comment -

          Correcting Fix Version based on CHANGES.txt, see this thread for more details...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Show
          hossman Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
          Hide
          gsingers Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          gsingers Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              rcmuir Robert Muir
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development