[SOLR-1874] optimize patternreplacefilter

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1
• Fix Version/s: 3.1, 4.0-ALPHA
• Component/s: Schema and Analysis
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 09/Apr/10 16:23
• Updated: 30/Mar/11 15:45
• Resolved: 10/Apr/10 15:56

Description

We can optimize PatternReplaceFilter:

• don't need to create Strings since CharTermAttribute implements CharSequence, just match directly against it.
• reuse the matcher, since CharTermAttribute is reused, too.
• don't create Strings/waste time in replaceAll/replaceFirst if the term doesn't match the regex at all... check with find() first.

There is more that could be done to make it faster for terms that do match, but this is simple and a start.

Issue Links

• is related to: LUCENE-2372 Replace deprecated TermAttribute by new CharTermAttribute