Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1857

cleanup and sync analysis with lucene trunk

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      Solr works on the lucene trunk, but uses a lot of deprecated APIs.
      Additionally two factories are missing, the Keyword and StemmerOverride filters.
      The code can be improved with 3.x's generics support, removing casts, etc.
      Finally there is some code duplication with lucene, and some cleanup (such as deprecating factories for stuff thats deprecated in trunk).

      1. SOLR-1857.patch
        195 kB
        Robert Muir

        Activity

        Hide
        rcmuir Robert Muir added a comment -

        attached is a regrettably large patch to sync us up, and clean things up a bit.

        this removes all use of deprecated lucene APIs, except via things that are now deprecated in Solr itself.

        All tests pass.

        Show
        rcmuir Robert Muir added a comment - attached is a regrettably large patch to sync us up, and clean things up a bit. this removes all use of deprecated lucene APIs, except via things that are now deprecated in Solr itself. All tests pass.
        Hide
        rcmuir Robert Muir added a comment -

        if no one objects, I would like to commit in a day or two. If anyone wants to review, thats great... i know its large...

        Show
        rcmuir Robert Muir added a comment - if no one objects, I would like to commit in a day or two. If anyone wants to review, thats great... i know its large...
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        I just did a 5 min review, not line-by-line, but seems fine in general.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - I just did a 5 min review, not line-by-line, but seems fine in general.
        Hide
        rcmuir Robert Muir added a comment -

        I just did a 5 min review, not line-by-line, but seems fine in general.

        Thanks for the review Yonik, I'll move forward then and commit soon...

        I'll open an issue next for the default schema speedups... looking forward to this

        Show
        rcmuir Robert Muir added a comment - I just did a 5 min review, not line-by-line, but seems fine in general. Thanks for the review Yonik, I'll move forward then and commit soon... I'll open an issue next for the default schema speedups... looking forward to this
        Hide
        rcmuir Robert Muir added a comment -

        Committed revision 929782.

        Show
        rcmuir Robert Muir added a comment - Committed revision 929782.
        Hide
        hossman Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        hossman Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        gsingers Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        gsingers Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            rcmuir Robert Muir
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development