Solr
  1. Solr
  2. SOLR-1845

terms component response format uses list instead of map

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      The terms component uses a named list instead of simple ordered map for it's top-level data structure.
      Access by name is more important, so it should be a map.

      1. SOLR-1845.patch
        2 kB
        Yonik Seeley

        Activity

        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Yonik Seeley added a comment -

        Committed.

        Show
        Yonik Seeley added a comment - Committed.
        Hide
        Hoss Man added a comment -

        Ah .. sorry, my ignorance of TermsComponent is showing ... i though "features" was a term in the "terms" list for some field (specified higher up outside your snippet)

        carry on.

        Show
        Hoss Man added a comment - Ah .. sorry, my ignorance of TermsComponent is showing ... i though "features" was a term in the "terms" list for some field (specified higher up outside your snippet) carry on.
        Hide
        Yonik Seeley added a comment -

        Attaching patch.
        This is mostly a back compat issue for JSON based output formats.

        Show
        Yonik Seeley added a comment - Attaching patch. This is mostly a back compat issue for JSON based output formats.
        Hide
        Yonik Seeley added a comment -

        Isn't getting the terms in order more important then being able to look them up in a map?

        Yes - just like faceting.
        The proposal is not to change that part, but the top-level terms container.
        In the example above "features" is the name of a field. It's "terms" that changes from a list to a map (the way faceting already is).

        Show
        Yonik Seeley added a comment - Isn't getting the terms in order more important then being able to look them up in a map? Yes - just like faceting. The proposal is not to change that part, but the top-level terms container. In the example above "features" is the name of a field. It's "terms" that changes from a list to a map (the way faceting already is).
        Hide
        Hoss Man added a comment -

        Isn't getting the terms in order more important then being able to look them up in a map?

        Show
        Hoss Man added a comment - Isn't getting the terms in order more important then being able to look them up in a map?
        Hide
        Yonik Seeley added a comment -

        Remember to check the JSON output for new request handlers!

        We currently have this:

         "terms":[
          "features",[
        

        But it should be this:

         "terms": {
          "features" : [
        
        Show
        Yonik Seeley added a comment - Remember to check the JSON output for new request handlers! We currently have this: "terms" :[ "features" ,[ But it should be this: "terms" : { "features" : [

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development