Solr
  1. Solr
  2. SOLR-1812

StreamingUpdateSolrServer creates an OutputStreamWriter that it never closes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Component/s: clients - java
    • Labels:
      None

      Activity

      Hide
      Sami Siren added a comment -

      Since this issue was created the internals have changed so that OutputStreamWriter is no longer used. I am reolving this.

      Show
      Sami Siren added a comment - Since this issue was created the internals have changed so that OutputStreamWriter is no longer used. I am reolving this.
      Hide
      Hoss Man added a comment -

      Bulk changing fixVersion 3.6 to 4.0 for any open issues that are unassigned and have not been updated since March 19.

      Email spam suppressed for this bulk edit; search for hoss20120323nofix36 to identify all issues edited

      Show
      Hoss Man added a comment - Bulk changing fixVersion 3.6 to 4.0 for any open issues that are unassigned and have not been updated since March 19. Email spam suppressed for this bulk edit; search for hoss20120323nofix36 to identify all issues edited
      Hide
      Robert Muir added a comment -

      3.4 -> 3.5

      Show
      Robert Muir added a comment - 3.4 -> 3.5
      Hide
      Robert Muir added a comment -

      Bulk move 3.2 -> 3.3

      Show
      Robert Muir added a comment - Bulk move 3.2 -> 3.3
      Hide
      Hoss Man added a comment -

      Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

      http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

      Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

      A unique token for finding these 240 issues in the future: hossversioncleanup20100527

      Show
      Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
      Hide
      Yonik Seeley added a comment -

      Perhaps SolrServer should have a close() method?

      +1

      Need to take care about what resources we close though... essentially we should only close what we create (i.e. if user passed in an HttpClient instance, it should not be closed).

      Show
      Yonik Seeley added a comment - Perhaps SolrServer should have a close() method? +1 Need to take care about what resources we close though... essentially we should only close what we create (i.e. if user passed in an HttpClient instance, it should not be closed).
      Hide
      Lance Norskog added a comment -

      Perhaps SolrServer should have a close() method?
      This would also take care of the users who create a new SolrServer per upload request and use up sockets (and thus threads at the server).

      Show
      Lance Norskog added a comment - Perhaps SolrServer should have a close() method? This would also take care of the users who create a new SolrServer per upload request and use up sockets (and thus threads at the server).
      Hide
      Mark Miller added a comment -

      I do not agree that this is a correct use of the API.

      OutputStreamWriter.close does not simply close the outputstream, nor does it simply flush and then close the outputstream. What it does it actually impl dependent, but its more than that in either case. This API misuse is just asking for trouble.

      Show
      Mark Miller added a comment - I do not agree that this is a correct use of the API. OutputStreamWriter.close does not simply close the outputstream, nor does it simply flush and then close the outputstream. What it does it actually impl dependent, but its more than that in either case. This API misuse is just asking for trouble.
      Hide
      Shalin Shekhar Mangar added a comment -

      Closing the OutputStreamWriter will close the underlying OutputStream. The HttpClient will automatically do that once the request has been sent so there is no leak here.

      Show
      Shalin Shekhar Mangar added a comment - Closing the OutputStreamWriter will close the underlying OutputStream. The HttpClient will automatically do that once the request has been sent so there is no leak here.

        People

        • Assignee:
          Unassigned
          Reporter:
          Mark Miller
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development