Solr
  1. Solr
  2. SOLR-1789

maven solr-core pom should depend on servlet api

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 3.1
    • Component/s: Build
    • Labels:
      None

      Description

      EmbeddedSolrServer, in Solr core, uses org.apache.solr.servlet.SolrRequestParsers which (as its package reflects) depends on the servlet API.

      Fix:
      Add the following to solr-core-pom.xml.template:
      <dependency>
      <groupId>javax.servlet</groupId>
      <artifactId>servlet-api</artifactId>
      <version>2.4</version>
      </dependency>

        Activity

        Hide
        Hoss Man added a comment -

        Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

        A unique token for finding these 240 issues in the future: hossversioncleanup20100527

        Show
        Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
        Hide
        Erik Hatcher added a comment -

        Tacking this comment on to an open Solr+Maven issue - what's needed to do the right thing now that the VelocityResponseWriter and its dependencies have moved to Solr's core? I know not Maven voodoo. Does this deserve a separate issue?

        Show
        Erik Hatcher added a comment - Tacking this comment on to an open Solr+Maven issue - what's needed to do the right thing now that the VelocityResponseWriter and its dependencies have moved to Solr's core? I know not Maven voodoo. Does this deserve a separate issue?
        Hide
        Chris Male added a comment -

        Hi Erik,

        The fix probably deserves another issue. Maybe an issue related to fixing the dependencies in the poms, which would include this and that for velocity.

        In any case, to include the velocity deps in solr-core-pom.xml.template:

        <dependency>
        <groupId>velocity</groupId>
        <artifactId>velocity</artifactId>
        <version>1.4</version>
        </dependency>

        Needs to be added. (alternatively the version can be 1.5, if thats what we want to use)

        Show
        Chris Male added a comment - Hi Erik, The fix probably deserves another issue. Maybe an issue related to fixing the dependencies in the poms, which would include this and that for velocity. In any case, to include the velocity deps in solr-core-pom.xml.template: <dependency> <groupId>velocity</groupId> <artifactId>velocity</artifactId> <version>1.4</version> </dependency> Needs to be added. (alternatively the version can be 1.5, if thats what we want to use)
        Hide
        Erik Hatcher added a comment -

        New issue created for the Velocity and other dependencies double-check/fix: SOLR-1964

        Show
        Erik Hatcher added a comment - New issue created for the Velocity and other dependencies double-check/fix: SOLR-1964
        Hide
        Steve Rowe added a comment -

        Fixed in LUCENE-2657.

        Show
        Steve Rowe added a comment - Fixed in LUCENE-2657 .

          People

          • Assignee:
            Steve Rowe
            Reporter:
            David Smiley
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development