Solr
  1. Solr
  2. SOLR-1770

move default example core config/data into a collection1 folder

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 4.0-BETA, 5.0
    • Component/s: None
    • Labels:
      None

      Description

      This is a better starting point for adding more cores - perhaps we can also get rid of multi-core example

      1. SOLR-1770.patch
        116 kB
        Mark Miller

        Issue Links

          Activity

          Mark Miller created issue -
          Hide
          Yonik Seeley added a comment -

          +1

          If the normal example is multi-core capable, and it's easy enough to create new cores, there's no need for the /example/multicore.

          Show
          Yonik Seeley added a comment - +1 If the normal example is multi-core capable, and it's easy enough to create new cores, there's no need for the /example/multicore.
          Hide
          Mark Miller added a comment -

          initial patch (won't do it form a patch to handle the moves though)

          Show
          Mark Miller added a comment - initial patch (won't do it form a patch to handle the moves though)
          Mark Miller made changes -
          Field Original Value New Value
          Attachment SOLR-1770.patch [ 12435596 ]
          Hide
          Hoss Man added a comment -

          Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

          A unique token for finding these 240 issues in the future: hossversioncleanup20100527

          Show
          Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
          Hoss Man made changes -
          Fix Version/s Next [ 12315093 ]
          Fix Version/s 1.5 [ 12313566 ]
          Hoss Man made changes -
          Fix Version/s 3.2 [ 12316172 ]
          Fix Version/s Next [ 12315093 ]
          Hide
          Robert Muir added a comment -

          Bulk move 3.2 -> 3.3

          Show
          Robert Muir added a comment - Bulk move 3.2 -> 3.3
          Robert Muir made changes -
          Fix Version/s 3.3 [ 12316471 ]
          Fix Version/s 3.2 [ 12316172 ]
          Robert Muir made changes -
          Fix Version/s 3.4 [ 12316683 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s 3.3 [ 12316471 ]
          Hide
          Robert Muir added a comment -

          3.4 -> 3.5

          Show
          Robert Muir added a comment - 3.4 -> 3.5
          Robert Muir made changes -
          Fix Version/s 3.5 [ 12317876 ]
          Fix Version/s 3.4 [ 12316683 ]
          Mark Miller made changes -
          Assignee Mark Miller [ markrmiller@gmail.com ]
          Hide
          Mark Miller added a comment -

          I should take another crack at this - probably just for 4 though.

          Show
          Mark Miller added a comment - I should take another crack at this - probably just for 4 though.
          Simon Willnauer made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Fix Version/s 3.5 [ 12317876 ]
          Robert Muir made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Hide
          Mark Miller added a comment -

          Okay, I'm going to look at doing this now.

          Show
          Mark Miller added a comment - Okay, I'm going to look at doing this now.
          Hide
          Mark Miller added a comment -

          Not sure what happened to the last attempt, I must have got sidetracked. We really need this in 4 though - otherwise creating new cores/collections is really ugly.

          Show
          Mark Miller added a comment - Not sure what happened to the last attempt, I must have got sidetracked. We really need this in 4 though - otherwise creating new cores/collections is really ugly.
          Mark Miller made changes -
          Fix Version/s 5.0 [ 12321664 ]
          Priority Major [ 3 ] Critical [ 2 ]
          Hide
          Jan Høydahl added a comment -

          +1, but perhaps choose a better name than "collection1" for the "products" example core?

          Show
          Jan Høydahl added a comment - +1, but perhaps choose a better name than "collection1" for the "products" example core?
          markrmiller committed 1354308 (592 files)
          Reviews: none

          SOLR-1770: Move the default core instance directory into a collection1 folder

          Lucene trunk
          Hide
          Mark Miller added a comment -

          This was not an easy refactor due to the tests (and then conflicts on my svn moves as it took so long to resolve everything). I'm committing what I have now so that I don't get out of date again. I think I've covered the major bases, all the tests pass and I've played around with solr example with success. I'll continue looking for anything I've missed over the next couple of days.

          Show
          Mark Miller added a comment - This was not an easy refactor due to the tests (and then conflicts on my svn moves as it took so long to resolve everything). I'm committing what I have now so that I don't get out of date again. I think I've covered the major bases, all the tests pass and I've played around with solr example with success. I'll continue looking for anything I've missed over the next couple of days.
          Hide
          Mark Miller added a comment -

          I just did my best to backport this to the 4 branch.

          Show
          Mark Miller added a comment - I just did my best to backport this to the 4 branch.
          markrmiller committed 1354482 (607 files)
          Reviews: none

          SOLR-1770: Move the default core instance directory into a collection1 folder

          Lucene branch_4x
          Hide
          David Smiley added a comment -

          +1 to remove the multicore example. Furthermore, I think integrating example-DIH into the same configuration would simply things even more.

          Show
          David Smiley added a comment - +1 to remove the multicore example. Furthermore, I think integrating example-DIH into the same configuration would simply things even more.
          Hide
          Mark Miller added a comment -

          I need to remember to check the Solr tutorial around this ... we really need to start doing versioned documentation...

          Our confluence wikis were just created the other day I read...

          Show
          Mark Miller added a comment - I need to remember to check the Solr tutorial around this ... we really need to start doing versioned documentation... Our confluence wikis were just created the other day I read...
          Mark Miller made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hoss Man added a comment -

          hoss20120711-manual-post-40alpha-change

          Show
          Hoss Man added a comment - hoss20120711-manual-post-40alpha-change
          Hoss Man made changes -
          Fix Version/s 4.0 [ 12322455 ]
          Fix Version/s 4.0-ALPHA [ 12314992 ]
          Jan Høydahl made changes -
          Link This issue blocks SOLR-3624 [ SOLR-3624 ]
          Hoss Man committed 1365390 (2 files)
          Reviews: none

          SOLR-1770: fix svn:ignore props for data and lib dirs now that example/solr/collection1/ is used as the instancedir (note: lib was explicitly left in svn:ignore for example/solr/ since it is the suggested path for registering a sharedLib in solr.xml)

          Hoss Man committed 1365391 (53 files)
          Reviews: none

          SOLR-1770: fix svn:ignore props for data and lib dirs now that example/solr/collection1/ is used as the instancedir (note: lib was explicitly left in svn:ignore for example/solr/ since it is the suggested path for registering a sharedLib in solr.xml) (merge r1365390)

          Hide
          Hoss Man added a comment -

          FYI: i updated hte svn:ignore props so lib & data dirs would be correctly ignored in the new example/solr/collection1 instancedir as they were before in example/solr/ ...

          Committed revision 1365390.
          Committed revision 1365391.

          Show
          Hoss Man added a comment - FYI: i updated hte svn:ignore props so lib & data dirs would be correctly ignored in the new example/solr/collection1 instancedir as they were before in example/solr/ ... Committed revision 1365390. Committed revision 1365391.
          Gavin made changes -
          Link This issue blocks SOLR-3624 [ SOLR-3624 ]
          Gavin made changes -
          Link This issue is depended upon by SOLR-3624 [ SOLR-3624 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development