Solr
  1. Solr
  2. SOLR-1735

shut down TimeLimitedCollection timer thread on application unload

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3, 1.4
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      As described in https://issues.apache.org/jira/browse/LUCENE-2237, shutting down the timer thread created by Lucene's TimeLimitedCollector allows Tomcat or another application server to cleanly unload solr.war (or any application using Lucene, for that matter).

      I'm attaching two patches for Solr 1.3 which use the patch provided in LUCENE-2237 to shut down the timer thread when a new servlet context listener for the solr.war application is informed the application is about to be unloaded.

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment

          Show
          Hoss Man added a comment - bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment
          Hide
          Robert Muir added a comment -

          rmuir20120906-bulk-40-change

          Show
          Robert Muir added a comment - rmuir20120906-bulk-40-change
          Hide
          Hoss Man added a comment -

          Unless I'm missing something, this issue was actually resolved by the commit in LUCENE-2822 that added the TimeLimitingCollector.getGlobalCounter() (and made Solr start using it).

          Not sure why this issue was left open.

          (If i'm wrong, and this still affects 3.6 and 4.0-BETA, then someone please re-open with more details)

          Show
          Hoss Man added a comment - Unless I'm missing something, this issue was actually resolved by the commit in LUCENE-2822 that added the TimeLimitingCollector.getGlobalCounter() (and made Solr start using it). Not sure why this issue was left open. (If i'm wrong, and this still affects 3.6 and 4.0-BETA, then someone please re-open with more details)

            People

            • Assignee:
              Simon Willnauer
              Reporter:
              Chris Darroch
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development