[SOLR-17256] Remove SolrRequest.getBasePath setBasePath

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: SolrJ
• Labels: newdev pull-request-available
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 25/Apr/24 14:29
• Updated: 05/Oct/24 01:15

Description

SolrRequest has a getBasePath & setBasePath. The naming is poor; it's the URL base to the Solr node like "http://localhost:8983/solr". It's only recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores it and will in fact mutate the passed in request to its liking, which is rather ugly because it means a request cannot be used concurrently if the user wants to. But moreover I think there's a conceptual discordance of placing this concept on SolrRequest given that some clients want to route requests to nodes they choose. I propose removing this from SolrRequest and instead adding a method specific to HttpSolrClient. Almost all existing usages of setBasePath immediately execute the request on an HttpSolrClient, so should be easy to change.

Issue Links

• relates to: SOLR-17314 SolrClient implementations should not mutate request objects
• links to: GitHub Pull Request #2494
• links to: GitHub Pull Request #2714