Solr
  1. Solr
  2. SOLR-1723

VelocityResponseWriter improvements

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 5.0, 6.0
    • Component/s: Response Writers
    • Labels:
      None

      Description

      Catch-all for a number of VelocityResponseWriter cleanups/improvements for 5.0:

      • CSS overhaul needed. Color scheme change. Add styling for <em> tags so highlighting stands out better.
      • Look up uniqueKey field name (for use by highlighting, explain, and other response extras)
      • spurious velocity.log's => route to logging to Solr's logging facility
      • Add back Velocity file resource loader, off by default. Set template.base.dir writer init param to enable. This was in pre-SOLR-4882 (4.6), enabled by a request-time v.base_dir parameter. Current implementation is enabled by an init-time parameter if specified and exists
      • Make params resource loader optional, off by default. Set params.resource.loader.enabled=true to enable.
      • Make solr resource loader optional, on by default. Set solr.resource.loader.enabled=false to disable.
      • Allow custom Velocity engine init properties to load from custom file: init.properties.file (formerly there was v.properties request-time)
      • Allow layout to be disabled, even if v.layout is set; use v.layout.enabled=false to disable layout (request-time)
      • Added $debug to context (it's just QueryResponse#getDebugMap()); makes it easy to #if($debug)...#end
      • Improve macros facility, put macros in your macros.vm. (with legacy support for VM_global_library.vm)

        Activity

        Hide
        Erik Hatcher added a comment -

        Clean up debug.vm to make a collapsible tree view of request and response

        Show
        Erik Hatcher added a comment - Clean up debug.vm to make a collapsible tree view of request and response
        Hide
        Hoss Man added a comment -

        Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

        A unique token for finding these 240 issues in the future: hossversioncleanup20100527

        Show
        Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
        Hide
        Erik Hatcher added a comment -

        Add range facets (on price for example data) and facet query support to the base templates.

        Add date range faceting support too.

        Show
        Erik Hatcher added a comment - Add range facets (on price for example data) and facet query support to the base templates. Add date range faceting support too.
        Hide
        Erik Hatcher added a comment -

        rmuir suggests paging controls with Sooooolr

        Show
        Erik Hatcher added a comment - rmuir suggests paging controls with Sooooolr
        Hide
        Erik Hatcher added a comment -

        CSS overhaul needed. Color scheme change. Add styling for <em> tags so highlighting stands out better.

        Show
        Erik Hatcher added a comment - CSS overhaul needed. Color scheme change. Add styling for <em> tags so highlighting stands out better.
        Hide
        Erik Hatcher added a comment -

        Great suggestion from Yonik - add a button to the UI to (re)build the spellcheck index. Easy enough to do.

        Show
        Erik Hatcher added a comment - Great suggestion from Yonik - add a button to the UI to (re)build the spellcheck index. Easy enough to do.
        Hide
        Robert Muir added a comment -

        Bulk move 3.2 -> 3.3

        Show
        Robert Muir added a comment - Bulk move 3.2 -> 3.3
        Hide
        Robert Muir added a comment -

        3.4 -> 3.5

        Show
        Robert Muir added a comment - 3.4 -> 3.5
        Hide
        Erik Hatcher added a comment -

        Targeting 4.0 only, not going to have anything for 3.5 for this.

        Show
        Erik Hatcher added a comment - Targeting 4.0 only, not going to have anything for 3.5 for this.
        Hide
        Hoss Man added a comment -

        bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment

        Show
        Hoss Man added a comment - bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment
        Hide
        Robert Muir added a comment -

        rmuir20120906-bulk-40-change

        Show
        Robert Muir added a comment - rmuir20120906-bulk-40-change
        Hide
        Hoss Man added a comment -

        There is no indication that anyone is actively working on this issue, so removing 4.0 from the fixVersion.

        Show
        Hoss Man added a comment - There is no indication that anyone is actively working on this issue, so removing 4.0 from the fixVersion.
        Hide
        Erik Hatcher added a comment -

        I'm usurping this issue to encompass a number of improvements for VelocityResponseWriter strictly for 5.0. Other items not tackled for 5.0 will be spun out into separate tickets.

        Show
        Erik Hatcher added a comment - I'm usurping this issue to encompass a number of improvements for VelocityResponseWriter strictly for 5.0. Other items not tackled for 5.0 will be spun out into separate tickets.
        Hide
        Erik Hatcher added a comment -

        Do we still need a button for rebuilding the spell check index as mentioned above? I don't think so, but if so let's open a new ticket for that one.

        Show
        Erik Hatcher added a comment - Do we still need a button for rebuilding the spell check index as mentioned above? I don't think so, but if so let's open a new ticket for that one.
        Hide
        ASF subversion and git services added a comment -

        Commit 1650685 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1650685 ]

        SOLR-1723: VelocityResponseWriter improvements
        SOLR-2035: Add a VelocityResponseWriter $resource tool for locale-specific string lookups.
        Lots of VrW code cleanup, more and improved test cases.

        Show
        ASF subversion and git services added a comment - Commit 1650685 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1650685 ] SOLR-1723 : VelocityResponseWriter improvements SOLR-2035 : Add a VelocityResponseWriter $resource tool for locale-specific string lookups. Lots of VrW code cleanup, more and improved test cases.
        Hide
        ASF subversion and git services added a comment -

        Commit 1650687 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1650687 ]

        SOLR-1723: VelocityResponseWriter improvements
        SOLR-2035: Add a VelocityResponseWriter $resource tool for locale-specific string lookups.
        Lots of VrW code cleanup, more and improved test cases.
        (merged from r1650685 of trunk)

        Show
        ASF subversion and git services added a comment - Commit 1650687 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1650687 ] SOLR-1723 : VelocityResponseWriter improvements SOLR-2035 : Add a VelocityResponseWriter $resource tool for locale-specific string lookups. Lots of VrW code cleanup, more and improved test cases. (merged from r1650685 of trunk)
        Hide
        Erik Hatcher added a comment -

        Closing this out; if there's anything lingering that needs to be done please make a new JIRA.

        Show
        Erik Hatcher added a comment - Closing this out; if there's anything lingering that needs to be done please make a new JIRA.
        Hide
        ASF subversion and git services added a comment -

        Commit 1650831 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1650831 ]

        SOLR-1723: polished the content-type capability

        Show
        ASF subversion and git services added a comment - Commit 1650831 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1650831 ] SOLR-1723 : polished the content-type capability
        Hide
        ASF subversion and git services added a comment -

        Commit 1650832 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1650832 ]

        SOLR-1723: polished the content-type capability (merged from trunk r1650831)

        Show
        ASF subversion and git services added a comment - Commit 1650832 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1650832 ] SOLR-1723 : polished the content-type capability (merged from trunk r1650831)
        Hide
        ASF subversion and git services added a comment -

        Commit 1651543 from Use account "steve_rowe" instead in branch 'dev/trunk'
        [ https://svn.apache.org/r1651543 ]

        SOLR-1723,SOLR-2035: maven config

        Show
        ASF subversion and git services added a comment - Commit 1651543 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1651543 ] SOLR-1723 , SOLR-2035 : maven config
        Hide
        ASF subversion and git services added a comment -

        Commit 1651553 from Use account "steve_rowe" instead in branch 'dev/trunk'
        [ https://svn.apache.org/r1651553 ]

        SOLR-1723,SOLR-2035: maven config: put resource bundles under velocity/ in output dir

        Show
        ASF subversion and git services added a comment - Commit 1651553 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1651553 ] SOLR-1723 , SOLR-2035 : maven config: put resource bundles under velocity/ in output dir
        Hide
        ASF subversion and git services added a comment -

        Commit 1651823 from Use account "steve_rowe" instead in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1651823 ]

        SOLR-1723,SOLR-2035: maven config (merged trunk r1651543 and r1651553)

        Show
        ASF subversion and git services added a comment - Commit 1651823 from Use account "steve_rowe" instead in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1651823 ] SOLR-1723 , SOLR-2035 : maven config (merged trunk r1651543 and r1651553)
        Hide
        ASF subversion and git services added a comment -

        Commit 1651825 from Use account "steve_rowe" instead in branch 'dev/branches/lucene_solr_5_0'
        [ https://svn.apache.org/r1651825 ]

        SOLR-1723,SOLR-2035: maven config (merged trunk r1651543 and r1651553)

        Show
        ASF subversion and git services added a comment - Commit 1651825 from Use account "steve_rowe" instead in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1651825 ] SOLR-1723 , SOLR-2035 : maven config (merged trunk r1651543 and r1651553)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development