Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-17222

QueryResponseWriterUtil.NonFlushingStream should support bulk write methods

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • main (10.0), 9.5
    • 9.6
    • None
    • None

    Description

      All text responses (non-javabin) are currently serialized through QueryResponseWriterUtil.NonFlushingStream. The minimal method override in that class means that every byte written on all text responses is iterated and copied byte-for-byte.

      It is trivial to extend FilterOutputStream and override the bulk write methods, eliminating this potential bottleneck. This came on my radar while doing general investigation into response serialization slowness. I haven't bothered to benchmark this, but it's a trivial change and could only be a good thing, in terms of performance.

      Attachments

        Issue Links

          Activity

            People

              magibney Michael Gibney
              magibney Michael Gibney
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m