Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16757 Umbrella Ticket for Revamping Solr CLI's for the Future
  3. SOLR-17147

To commit or not to commit? That is the question on bin/solr post

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 9.5
    • main (10.0), 9.6.0
    • cli
    • None

    Description

      The way we have set up most boolean options in the bin/solr is that you specific the option to mean "true". Versus doing a "option=true" or "option=false". In the bin/post command, the commit is a explicit true/false, and if you don't specifiy it, then there is automatically a commit. However, with bin/solr post, if you don't specify -commit, then you don't get a commit.

      Which makes sense from how the options are laid out "yes I want to opt into a commit", however I suspect the vast majority of users who use the command will immediatly go look for the doc, and wonder why it isn't visible.. which is proably why bin/post commits if you don't specify it.

      Our options are to have an explicit -commit=true/false OR we commit by default and have a -nocommit option.

      I guess I am leaning towards having a -nocommit as a boolean option, so that wihtout it you get the commit...

      Fortunantly optimize story is better. by default we do NOT issue an optimize, but you can do -optimize to requiest that .

      Attachments

        Issue Links

          Activity

            People

              epugh Eric Pugh
              epugh Eric Pugh
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m