[SOLR-16997] OTEL configurator NPE when SOLR_HOST not set

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.4
• Component/s: tracing
• Assignee: Jan Høydahl
• Reporter: Jan Høydahl
• Created: 26/Sep/23 10:29
• Updated: 15/Oct/23 20:13
• Resolved: 26/Sep/23 13:02

Description

If you start Solr 9.3 with OTEL tracing enabled, but do not set SOLR_HOST, solr will not come up due to it trying to read sysprop "host" which is null and Map.of() requires non-null key and value.

Simple workaround is to set SOLR_HOST but for dev environment it would be nice to fix the bug by checking before setting the "host.name" trace-property.

at java.base/java.util.Objects.requireNonNull(Unknown Source)
java.lang.NullPointerException: null
at java.util.Objects.requireNonNull(Unknown Source) ~[?:?]
at java.util.ImmutableCollections$Map1.<init>(Unknown Source) ~[?:?]
at java.util.Map.of(Unknown Source) ~[?:?]
at org.apache.solr.opentelemetry.OtelTracerConfigurator.getTracer(OtelTracerConfigurator.java:50) ~[?:?] 

Issue Links

• links to: GitHub Pull Request #1959