Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1688

Inner class FieldCacheSources should be refactored into their own classes

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.4
    • Fix Version/s: 4.9, 6.0
    • Component/s: search
    • Labels:
      None
    • Environment:

      indep. of env.

      Description

      While working on SOLR-1586 I noticed that outside of class level access (or package level), you can't really reference FieldCacheSources that are defined inside of their FieldType constituents (e.g., in the case of StrFieldSource as defined in StrField). What's more troubling is that the FieldType/FieldCacheSources are defined in an inconsistent fashion: some are done as inner classes, e.g., StrFieldSource and SortableFloatFieldSource, while others are defined as individual classes (e.g., FloatFIeldSource). This patch will make them all consistent and define each FieldCacheSource as an outside class, present in o.a.solr.search.function.

        Attachments

        1. SOLR-1688.Mattmann.122609.patch.txt
          41 kB
          Chris A. Mattmann

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                chrismattmann Chris A. Mattmann
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated: