[SOLR-16834] Remove unused AddReplicaCmd properties

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: main (10.0)
• Component/s: SolrCloud
• Labels: newdev
• Assignee: Unassigned
• Reporter: Jason Gerlowski
• Created: 01/Jun/23 12:15
• Updated: 21/Jul/23 20:42
• Resolved: 26/Jun/23 17:36

Description

AddReplicaCmd currently has logic to read and use a parameter called 'skipCreateReplicaInClusterState' (which defaults to false). Unfortunately, CollectionsHandler doesn't actually pass that parameter.

It looks like the parameter was added for use by the autoscaling "simulation" framework (see SOLR-11285). When that was cut from Solr later on the parameter was removed from CollectionsHandler, but the corresponding change to AddReplicaCmd was never made.

We should remove this line from AddReplicaCmd, and any other references to that now-defunct param.