Solr
  1. Solr
  2. SOLR-1679

SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      As mentioned by Fuad on solr-user, there is some non-trivial log message construction happening in SolreCore.execute that should be wrapped in "if (log.isInfoEnabled())" ...

      http://old.nabble.com/SOLR-Performance-Tuning%3A-Disable-INFO-Logging.-to26866730.html#a26866943

      ...the warn level message in that same method could probably also be wrapped since it does some large string building as well.

        Activity

        Hide
        Hoss Man added a comment -

        Committed revision 911216.

        Thanks for the suggestion Fuad.

        Show
        Hoss Man added a comment - Committed revision 911216. Thanks for the suggestion Fuad.
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development