[SOLR-16732] Misc SonarQube findings

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.3
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 01/Apr/23 14:32
• Updated: 21/Jul/23 20:40
• Resolved: 03/Apr/23 14:52

Description

I have been running SonarQube against the Solr project and there are some low hanging fruit things that can be addressed

• String non regex replaceAll with replace
• indexOf -> contains
• NBSP in log
• unindented if statements missing {}
• Use && instead of & for boolean comparisons
• Replace "".equals with isEmpty

Issue Links

• links to: GitHub Pull Request #1525