Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      as part of converting tests for SOLR-1657, I ran into a problem with synonymfilter

      the test for 'repeats' has a flaw, it uses this assertTokEqual construct which does not really validate that two lists of token are equal, it just stops at the shorted one.

          // repeats
          map.add(strings("a b"), tokens("ab"), orig, merge);
          map.add(strings("a b"), tokens("ab"), orig, merge);
          assertTokEqual(getTokList(map,"a b",false), tokens("ab"));
          /* in reality the result from getTokList is ab ab ab!!!!! */
      

      when converted to assertTokenStreamContents this problem surfaced. attached is an additional assertion to the existing testcase.

      1. SOLR-1670.patch
        13 kB
        Steve Rowe
      2. SOLR-1670.patch
        13 kB
        Steve Rowe
      3. SOLR-1670.patch
        4 kB
        Yonik Seeley
      4. SOLR-1670_test.patch
        0.6 kB
        Robert Muir

        Issue Links

          Activity

            People

            • Assignee:
              Yonik Seeley
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Development