Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16694

Shortcut Http2SolrClient mimeType check for default response parse

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • main (10.0), 9.3
    • None
    • None

    Description

      Http2SolrClient has some logic to get the list of content types supported by the response parser, parse those from String into ContentType objects to then get the mimeType of those and put them on a Set, to later check against the response content type.

      In practice, most users of Http2SolrClient (including Solr itself) will be using javabin with the BinaryResponseParser, for which we know the exact mimeType that will accept. We could avoid the logic I've described above for cases where the response parser is the default one

       

      Attachments

        1. screenshot-2.png
          284 kB
          Tomas Eduardo Fernandez Lobbe
        2. screenshot-1.png
          218 kB
          Tomas Eduardo Fernandez Lobbe

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tflobbe Tomas Eduardo Fernandez Lobbe
            tflobbe Tomas Eduardo Fernandez Lobbe
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                Slack

                  Issue deployment