Solr
  1. Solr
  2. SOLR-1667

PatternTokenizer does not clearAttributes()

    Details

      Description

      PatternTokenizer creates tokens, but never calls clearAttributes()

      because of this things like positionIncrementGap are never reset to their default value.
      trivial patch

      1. SOLR-1667.patch
        0.5 kB
        Robert Muir

        Issue Links

          Activity

          Robert Muir created issue -
          Robert Muir made changes -
          Field Original Value New Value
          Attachment SOLR-1667.patch [ 12428340 ]
          Robert Muir made changes -
          Link This issue blocks SOLR-1657 [ SOLR-1657 ]
          Hide
          Uwe Schindler added a comment -

          Too bad, this tokenizer was rewritten by me. How could i forget that? puuuuuh

          Show
          Uwe Schindler added a comment - Too bad, this tokenizer was rewritten by me. How could i forget that? puuuuuh
          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 892217.

          Thanks Robert!

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 892217. Thanks Robert!
          Shalin Shekhar Mangar made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Shalin Shekhar Mangar [ shalinmangar ]
          Fix Version/s 1.5 [ 12313566 ]
          Resolution Fixed [ 1 ]
          Hide
          Hoss Man added a comment -

          Correcting Fix Version based on CHANGES.txt, see this thread for more details...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Show
          Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
          Hoss Man made changes -
          Fix Version/s 3.1 [ 12314371 ]
          Fix Version/s 4.0 [ 12314992 ]
          Hide
          Robert Muir added a comment -

          reopening to backport to solr 1.4.x branch.

          Show
          Robert Muir added a comment - reopening to backport to solr 1.4.x branch.
          Robert Muir made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Shalin Shekhar Mangar [ shalinmangar ] Robert Muir [ rcmuir ]
          Hide
          Robert Muir added a comment -

          Committed revision 1035982.

          Show
          Robert Muir added a comment - Committed revision 1035982.
          Robert Muir made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Fix Version/s 1.4.2 [ 12315231 ]
          Fix Version/s 1.5 [ 12313566 ]
          Resolution Fixed [ 1 ]
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release
          Grant Ingersoll made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          14h 35m 1 Shalin Shekhar Mangar 18/Dec/09 10:43
          Resolved Resolved Reopened Reopened
          334d 37m 1 Robert Muir 17/Nov/10 11:21
          Reopened Reopened Resolved Resolved
          13m 17s 1 Robert Muir 17/Nov/10 11:34
          Resolved Resolved Closed Closed
          133d 4h 11m 1 Grant Ingersoll 30/Mar/11 16:45

            People

            • Assignee:
              Robert Muir
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development